<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[26040] trunk/tests/qunit/wp-admin/js/password-strength-meter.js: Use only one var per scope in our password-strength-meter tests.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/26040">26040</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2013-11-07 20:40:12 +0000 (Thu, 07 Nov 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Use only one var per scope in our password-strength-meter tests.
props kadamwhite.
see <a href="http://core.trac.wordpress.org/ticket/25187">#25187</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsqunitwpadminjspasswordstrengthmeterjs">trunk/tests/qunit/wp-admin/js/password-strength-meter.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsqunitwpadminjspasswordstrengthmeterjs"></a>
<div class="modfile"><h4>Modified: trunk/tests/qunit/wp-admin/js/password-strength-meter.js (26039 => 26040)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/qunit/wp-admin/js/password-strength-meter.js 2013-11-07 20:36:09 UTC (rev 26039)
+++ trunk/tests/qunit/wp-admin/js/password-strength-meter.js 2013-11-07 20:40:12 UTC (rev 26040)
</span><span class="lines">@@ -12,9 +12,9 @@
</span><span class="cx">
</span><span class="cx"> test( 'long complicated passwords should return 4', function() {
</span><span class="cx"> var password = function( length ) {
</span><del>- var possibility = 'abcdefghijklnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789',
- retVal = '';
- for ( var i = 0, n = possibility.length; i < length; i++ ) {
</del><ins>+ var i, n, retVal = '',
+ possibility = 'abcdefghijklnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789';
+ for ( i = 0, n = possibility.length; i < length; i++ ) {
</ins><span class="cx"> retVal += possibility.charAt( Math.floor( Math.random() * n ) );
</span><span class="cx"> }
</span><span class="cx"> return retVal + 'aB2'; // add a lower case, uppercase and number just to make sure we always have one of each
</span><span class="lines">@@ -36,7 +36,8 @@
</span><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> test( 'zxcvbn password tests should return the score we expect', function() {
</span><del>- var passwords = [
</del><ins>+ var passwords, i;
+ passwords = [
</ins><span class="cx"> { pw: 'zxcvbn', score: 0 },
</span><span class="cx"> { pw: 'qwER43@!', score: 1 },
</span><span class="cx"> { pw: 'Tr0ub4dour&3', score: 2 },
</span><span class="lines">@@ -73,7 +74,7 @@
</span><span class="cx"> { pw: 'Ba9ZyWABu99[BK#6MBgbH88Tofv)vs$w', score: 4 }
</span><span class="cx"> ];
</span><span class="cx">
</span><del>- for ( var i = 0; i < passwords.length; i++ ) {
</del><ins>+ for ( i = 0; i < passwords.length; i++ ) {
</ins><span class="cx"> equal( passwordStrength( passwords[i].pw, 'username', passwords[i].pw ), passwords[i].score, 'password of `' + passwords[i].pw + '` returns ' + passwords[i].score );
</span><span class="cx"> }
</span><span class="cx"> });
</span></span></pre>
</div>
</div>
</body>
</html>