<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[26041] trunk: Update jshint grunt task to exclude eqeqeq and curly for now, until we've resolved other code smells.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/26041">26041</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2013-11-07 21:14:49 +0000 (Thu, 07 Nov 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Update jshint grunt task to exclude eqeqeq and curly for now, until we've resolved other code smells.
props kadamwhite.
see <a href="http://core.trac.wordpress.org/ticket/25187">#25187</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkjshintrc">trunk/.jshintrc</a></li>
<li><a href="#trunkGruntfilejs">trunk/Gruntfile.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkjshintrc"></a>
<div class="modfile"><h4>Modified: trunk/.jshintrc (26040 => 26041)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/.jshintrc 2013-11-07 20:40:12 UTC (rev 26040)
+++ trunk/.jshintrc 2013-11-07 21:14:49 UTC (rev 26041)
</span><span class="lines">@@ -3,20 +3,22 @@
</span><span class="cx"> "curly": true,
</span><span class="cx"> "eqeqeq": true,
</span><span class="cx"> "eqnull": true,
</span><ins>+ "es3": true,
</ins><span class="cx"> "expr": true,
</span><span class="cx"> "immed": true,
</span><span class="cx"> "noarg": true,
</span><ins>+ "onevar": true,
</ins><span class="cx"> "quotmark": "single",
</span><span class="cx"> "smarttabs": true,
</span><span class="cx"> "trailing": true,
</span><span class="cx"> "undef": true,
</span><span class="cx"> "unused": true,
</span><del>- "es3": true,
- "onevar": true,
</del><span class="cx">
</span><span class="cx"> "browser": true,
</span><span class="cx">
</span><span class="cx"> "globals": {
</span><ins>+ "_": false,
+ "Backbone": false,
</ins><span class="cx"> "jQuery": false,
</span><span class="cx"> "wp": false
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkGruntfilejs"></a>
<div class="modfile"><h4>Modified: trunk/Gruntfile.js (26040 => 26041)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Gruntfile.js 2013-11-07 20:40:12 UTC (rev 26040)
+++ trunk/Gruntfile.js 2013-11-07 21:14:49 UTC (rev 26041)
</span><span class="lines">@@ -83,55 +83,48 @@
</span><span class="cx"> jshint: {
</span><span class="cx"> options: grunt.file.readJSON('.jshintrc'),
</span><span class="cx"> grunt: {
</span><del>- files: {
- src: ['Gruntfile.js']
- },
- options: {
- onevar: true
- }
</del><ins>+ src: ['Gruntfile.js']
</ins><span class="cx"> },
</span><span class="cx"> tests: {
</span><del>- files: {
- src: [
- 'tests/qunit/**/*.js',
- '!tests/qunit/vendor/qunit.js'
- ]
- },
</del><ins>+ src: [
+ 'tests/qunit/**/*.js',
+ '!tests/qunit/vendor/qunit.js'
+ ],
</ins><span class="cx"> options: grunt.file.readJSON('tests/qunit/.jshintrc')
</span><span class="cx"> },
</span><del>- 'wp-admin': {
- files: {
- src: [
- 'src/wp-admin/js/**/*.js',
- '!src/wp-admin/js/farbtastic.js',
- '!src/wp-admin/js/iris.min.js'
- ]
</del><ins>+ core: {
+ expand: true,
+ cwd: SOURCE_DIR,
+ src: [
+ 'wp-admin/js/*.js',
+ 'wp-includes/js/*.js',
+ // WordPress scripts inside directories
+ 'wp-includes/js/jquery/jquery.table-hotkeys.js',
+ 'wp-includes/js/mediaelement/wp-mediaelement.js',
+ 'wp-includes/js/plupload/handlers.js',
+ 'wp-includes/js/plupload/wp-plupload.js',
+ 'wp-includes/js/tinymce/langs/wp-langs-en.js',
+ 'wp-includes/js/tinymce/plugins/wordpress/editor_plugin_src.js',
+ 'wp-includes/js/tinymce/plugins/wp*/editor_plugin_src.js',
+ 'wp-includes/js/tinymce/mark_loaded_src.js',
+ 'wp-includes/js/tinymce/wp-tinymce-schema.js',
+ // Third party scripts
+ '!wp-admin/js/farbtastic.js',
+ '!wp-admin/js/iris.min.js',
+ '!wp-includes/js/backbone.min.js',
+ '!wp-includes/js/swfobject.js',
+ '!wp-includes/js/underscore.min.js',
+ '!wp-includes/js/zxcvbn.min.js',
+ '!wp-includes/js/colorpicker.js',
+ '!wp-includes/js/hoverIntent.js',
+ '!wp-includes/js/json2.js',
+ '!wp-includes/js/tw-sack.js'
+ ],
+ // Remove once other JSHint errors are resolved
+ options: {
+ curly: false,
+ eqeqeq: false
</ins><span class="cx"> }
</span><del>- },
- 'wp-includes': {
- files: {
- src: [
- 'src/wp-includes/js/**/*.js',
- // 3rd-Party Scripts
- '!src/wp-includes/js/backbone.min.js',
- '!src/wp-includes/js/colorpicker.js',
- '!src/wp-includes/js/crop/**/*.js',
- '!src/wp-includes/js/hoverIntent.js',
- '!src/wp-includes/js/imgareaselect/**/*.js',
- '!src/wp-includes/js/jcrop/**/*.js',
- '!src/wp-includes/js/jquery/**/*.js',
- '!src/wp-includes/js/json2.js',
- '!src/wp-includes/js/mediaelement/**/*.js',
- '!src/wp-includes/js/plupload/**/*.js',
- '!src/wp-includes/js/swfobject.js',
- '!src/wp-includes/js/swfupload/**/*.js',
- '!src/wp-includes/js/thickbox/**/*.js',
- '!src/wp-includes/js/tinymce/**/*.js',
- '!src/wp-includes/js/tw-sack.js',
- '!src/wp-includes/js/underscore.min.js',
- '!src/wp-includes/js/zxcvbn.min.js'
- ]
- }
</del><span class="cx"> }
</span><span class="cx"> },
</span><span class="cx"> qunit: {
</span></span></pre>
</div>
</div>
</body>
</html>