<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[25960] trunk: Add a .jshintrc file and associated jshint grunt task.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/25960">25960</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2013-10-27 21:53:11 +0000 (Sun, 27 Oct 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add a .jshintrc file and associated jshint grunt task.
This .jshintrc is adopted from the jQuery project, with some basic modifications (such as single quotes instead of double quotes). This pretty closely follows our current JS standards and rather closely resembles our PHP standards, especially the love of whitespace. The major changes are enforcing === and always using braces for if statements.
props kadamwhite, gnarf37, with mattwiebe and carldanley.
see <a href="http://core.trac.wordpress.org/ticket/25187">#25187</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkGruntfilejs">trunk/Gruntfile.js</a></li>
<li><a href="#trunkpackagejson">trunk/package.json</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkjshintrc">trunk/.jshintrc</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkjshintrc"></a>
<div class="addfile"><h4>Added: trunk/.jshintrc (0 => 25960)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/.jshintrc (rev 0)
+++ trunk/.jshintrc 2013-10-27 21:53:11 UTC (rev 25960)
</span><span class="lines">@@ -0,0 +1,21 @@
</span><ins>+{
+ "boss": true,
+ "curly": true,
+ "eqeqeq": true,
+ "eqnull": true,
+ "expr": true,
+ "immed": true,
+ "noarg": true,
+ "quotmark": "single",
+ "smarttabs": true,
+ "trailing": true,
+ "undef": true,
+ "unused": true,
+
+ "browser": true,
+
+ "globals": {
+ "jQuery": false,
+ "wp": false
+ }
+}
</ins></span></pre></div>
<a id="trunkGruntfilejs"></a>
<div class="modfile"><h4>Modified: trunk/Gruntfile.js (25959 => 25960)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Gruntfile.js 2013-10-27 21:39:51 UTC (rev 25959)
+++ trunk/Gruntfile.js 2013-10-27 21:53:11 UTC (rev 25960)
</span><span class="lines">@@ -1,8 +1,8 @@
</span><del>-/*global module:false*/
</del><ins>+/* jshint node:true */
</ins><span class="cx"> module.exports = function(grunt) {
</span><del>- var path = require('path');
- var SOURCE_DIR = 'src/';
- var BUILD_DIR = 'build/';
</del><ins>+ var path = require('path'),
+ SOURCE_DIR = 'src/',
+ BUILD_DIR = 'build/';
</ins><span class="cx">
</span><span class="cx"> // Load tasks.
</span><span class="cx"> require('matchdep').filterDev('grunt-*').forEach( grunt.loadNpmTasks );
</span><span class="lines">@@ -47,8 +47,8 @@
</span><span class="cx"> },
</span><span class="cx"> version: {
</span><span class="cx"> options: {
</span><del>- processContent: function( src, filepath ) {
- return src.replace( /^(\$wp_version.+?)-src';/m, "$1';" );
</del><ins>+ processContent: function( src ) {
+ return src.replace( /^(\$wp_version.+?)-src';/m, '$1\';' );
</ins><span class="cx"> }
</span><span class="cx"> },
</span><span class="cx"> files: [
</span><span class="lines">@@ -80,6 +80,60 @@
</span><span class="cx"> ]
</span><span class="cx"> }
</span><span class="cx"> },
</span><ins>+ jshint: {
+ options: grunt.file.readJSON('.jshintrc'),
+ grunt: {
+ files: {
+ src: ['Gruntfile.js']
+ },
+ options: {
+ onevar: true
+ }
+ },
+ tests: {
+ files: {
+ src: [
+ 'tests/qunit/**/*.js',
+ '!tests/qunit/vendor/qunit.js'
+ ]
+ },
+ options: grunt.file.readJSON('tests/qunit/.jshintrc')
+ },
+ 'wp-admin': {
+ files: {
+ src: [
+ 'src/wp-admin/js/**/*.js',
+ '!src/wp-admin/js/farbtastic.js',
+ '!src/wp-admin/js/iris.min.js'
+ ]
+ }
+ },
+ 'wp-includes': {
+ files: {
+ src: [
+ 'src/wp-includes/js/**/*.js',
+ // 3rd-Party Scripts
+ '!src/wp-includes/js/backbone.min.js',
+ '!src/wp-includes/js/colorpicker.js',
+ '!src/wp-includes/js/crop/**/*.js',
+ '!src/wp-includes/js/hoverIntent.js',
+ '!src/wp-includes/js/imgareaselect/**/*.js',
+ '!src/wp-includes/js/jcrop/**/*.js',
+ '!src/wp-includes/js/jquery/**/*.js',
+ '!src/wp-includes/js/json2.js',
+ '!src/wp-includes/js/mediaelement/**/*.js',
+ '!src/wp-includes/js/plupload/**/*.js',
+ '!src/wp-includes/js/swfobject.js',
+ '!src/wp-includes/js/swfupload/**/*.js',
+ '!src/wp-includes/js/thickbox/**/*.js',
+ '!src/wp-includes/js/tinymce/**/*.js',
+ '!src/wp-includes/js/tw-sack.js',
+ '!src/wp-includes/js/underscore.min.js',
+ '!src/wp-includes/js/zxcvbn.min.js'
+ ]
+ }
+ }
+ },
</ins><span class="cx"> qunit: {
</span><span class="cx"> files: ['tests/qunit/**/*.html']
</span><span class="cx"> },
</span><span class="lines">@@ -194,12 +248,13 @@
</span><span class="cx"> // On `watch:all`, automatically updates the `copy:dynamic` and `clean:dynamic`
</span><span class="cx"> // configurations so that only the changed files are updated.
</span><span class="cx"> grunt.event.on('watch', function( action, filepath, target ) {
</span><del>- if ( target != 'all' )
</del><ins>+ if ( target !== 'all' ) {
</ins><span class="cx"> return;
</span><ins>+ }
</ins><span class="cx">
</span><del>- var relativePath = path.relative( SOURCE_DIR, filepath );
- var cleanSrc = ( action == 'deleted' ) ? [relativePath] : [];
- var copySrc = ( action == 'deleted' ) ? [] : [relativePath];
</del><ins>+ var relativePath = path.relative( SOURCE_DIR, filepath ),
+ cleanSrc = ( action === 'deleted' ) ? [relativePath] : [],
+ copySrc = ( action === 'deleted' ) ? [] : [relativePath];
</ins><span class="cx">
</span><span class="cx"> grunt.config(['clean', 'dynamic', 'src'], cleanSrc);
</span><span class="cx"> grunt.config(['copy', 'dynamic', 'src'], copySrc);
</span></span></pre></div>
<a id="trunkpackagejson"></a>
<div class="modfile"><h4>Modified: trunk/package.json (25959 => 25960)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/package.json 2013-10-27 21:39:51 UTC (rev 25959)
+++ trunk/package.json 2013-10-27 21:53:11 UTC (rev 25960)
</span><span class="lines">@@ -18,6 +18,7 @@
</span><span class="cx"> "grunt-contrib-watch": "~0.5.1",
</span><span class="cx"> "grunt-contrib-compress": "~0.5.2",
</span><span class="cx"> "grunt-contrib-concat": "~0.3.0",
</span><ins>+ "grunt-contrib-jshint": "~0.7.0",
</ins><span class="cx"> "matchdep": "~0.1.2"
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>