<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[25920] trunk/tools/i18n: Extract: rename method `extract_entries` to `extract_from_code`</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/25920">25920</a></dd>
<dt>Author</dt> <dd>nbachiyski</dd>
<dt>Date</dt> <dd>2013-10-26 00:54:27 +0000 (Sat, 26 Oct 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Extract: rename method `extract_entries` to `extract_from_code`
The other extract methods are named `extract_from_<something>`, this was
te only one, which wasn't.
Also, it was returning an instance of `Translations`,
not an array of entries, which the name suggested.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktoolsi18nextractphp">trunk/tools/i18n/extract.php</a></li>
<li><a href="#trunktoolsi18ntExtractTestphp">trunk/tools/i18n/t/ExtractTest.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktoolsi18nextractphp"></a>
<div class="modfile"><h4>Modified: trunk/tools/i18n/extract.php (25919 => 25920)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tools/i18n/extract.php 2013-10-26 00:46:34 UTC (rev 25919)
+++ trunk/tools/i18n/extract.php 2013-10-26 00:54:27 UTC (rev 25920)
</span><span class="lines">@@ -40,7 +40,7 @@
</span><span class="cx">
</span><span class="cx"> function extract_from_file( $file_name, $prefix ) {
</span><span class="cx"> $code = file_get_contents( $file_name );
</span><del>- return $this->extract_entries( $code, $prefix . $file_name );
</del><ins>+ return $this->extract_from_code( $code, $prefix . $file_name );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function does_file_name_match( $path, $excludes, $includes ) {
</span><span class="lines">@@ -126,7 +126,7 @@
</span><span class="cx"> return $entry;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- function extract_entries( $code, $file_name ) {
</del><ins>+ function extract_from_code( $code, $file_name ) {
</ins><span class="cx"> $translations = new Translations;
</span><span class="cx"> $function_calls = $this->find_function_calls( array_keys( $this->rules ), $code );
</span><span class="cx"> foreach( $function_calls as $call ) {
</span></span></pre></div>
<a id="trunktoolsi18ntExtractTestphp"></a>
<div class="modfile"><h4>Modified: trunk/tools/i18n/t/ExtractTest.php (25919 => 25920)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tools/i18n/t/ExtractTest.php 2013-10-26 00:46:34 UTC (rev 25919)
+++ trunk/tools/i18n/t/ExtractTest.php 2013-10-26 00:54:27 UTC (rev 25920)
</span><span class="lines">@@ -13,7 +13,7 @@
</span><span class="cx">
</span><span class="cx"> function test_with_just_a_string() {
</span><span class="cx"> $expected = new Translation_Entry( array( 'singular' => 'baba', 'references' => array('baba.php:1') ) );
</span><del>- $result = $this->extractor->extract_entries('<?php __("baba"); ?>', 'baba.php' );
</del><ins>+ $result = $this->extractor->extract_from_code('<?php __("baba"); ?>', 'baba.php' );
</ins><span class="cx"> $this->assertEquals( $expected, $result->entries['baba'] );
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>