<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[25886] branches/3.7: About page, updates section: Don't show a message on about.php if the updater is 100% disabled.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/25886">25886</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2013-10-23 19:53:56 +0000 (Wed, 23 Oct 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>About page, updates section: Don't show a message on about.php if the updater is 100% disabled. Don't show it if the user can't update core. Don't show the email if notifications are disabled. New string.
Merges <a href="http://core.trac.wordpress.org/changeset/25883">[25883]</a> to the 3.7 branch.
see <a href="http://core.trac.wordpress.org/ticket/25603">#25603</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branches37srcwpadminaboutphp">branches/3.7/src/wp-admin/about.php</a></li>
</ul>
<h3>Property Changed</h3>
<ul>
<li><a href="#branches37">branches/3.7/</a></li>
<li><a href="#branches37src">branches/3.7/src/</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<span class="cx">Index: branches/3.7
</span><span class="cx">===================================================================
</span><del>--- branches/3.7 2013-10-23 19:53:21 UTC (rev 25885)
</del><ins>+++ branches/3.7 2013-10-23 19:53:56 UTC (rev 25886)
</ins><a id="branches37"></a>
<div class="propset"><h4>Property changes: branches/3.7</h4>
<pre class="diff"><span>
</span></pre></div>
<a id="svnmergeinfo"></a>
<div class="modfile"><h4>Modified: svn:mergeinfo</h4></div>
<span class="cx"> /branches/3.1:18031
</span><span class="cx"> /branches/3.3:20543
</span><span class="cx"> /branches/3.4:21757
</span><del>-/trunk:18512,25882
</del><ins>+/trunk:18512,25882-25883
</ins><span class="cx">\ No newline at end of property
</span><span class="cx">Index: branches/3.7/src
</span><span class="cx">===================================================================
</span><del>--- branches/3.7/src 2013-10-23 19:53:21 UTC (rev 25885)
</del><ins>+++ branches/3.7/src 2013-10-23 19:53:56 UTC (rev 25886)
</ins><a id="branches37src"></a>
<div class="propset"><h4>Property changes: branches/3.7/src</h4>
<pre class="diff"><span>
</span></pre></div>
<a id="svnmergeinfo"></a>
<div class="modfile"><h4>Modified: svn:mergeinfo</h4></div>
<span class="cx"> /branches/3.1/src:18031
</span><span class="cx"> /branches/3.3/src:20543
</span><span class="cx"> /branches/3.4/src:21757
</span><del>-/trunk/src:18512,25880,25882
</del><ins>+/trunk/src:18512,25880,25882-25883
</ins><span class="cx">\ No newline at end of property
</span><a id="branches37srcwpadminaboutphp"></a>
<div class="modfile"><h4>Modified: branches/3.7/src/wp-admin/about.php (25885 => 25886)</h4>
<pre class="diff"><span>
<span class="info">--- branches/3.7/src/wp-admin/about.php 2013-10-23 19:53:21 UTC (rev 25885)
+++ branches/3.7/src/wp-admin/about.php 2013-10-23 19:53:56 UTC (rev 25886)
</span><span class="lines">@@ -52,23 +52,36 @@
</span><span class="cx"> <p><?php _e( 'You’ll still need to click “Update Now” once WordPress 3.8 is released, but we’ve never had more confidence in that beautiful blue button.' ); ?></p>
</span><span class="cx"> </div>
</span><span class="cx"> <?php
</span><del>- $can_auto_update = wp_http_supports( 'ssl' );
</del><ins>+ if ( current_user_can( 'update_core' ) ) {
+ $future_minor_update = (object) array(
+ 'current' => $wp_version . '.1.next.minor',
+ 'version' => $wp_version . '.1.next.minor',
+ 'php_version' => $required_php_version,
+ 'mysql_version' => $required_mysql_version,
+ );
+ require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
+ $updater = new WP_Automatic_Updater;
+ $can_auto_update = wp_http_supports( 'ssl' ) && $updater->should_update( 'core', $future_minor_update, ABSPATH );
+
</ins><span class="cx"> if ( $can_auto_update ) {
</span><del>- require_once ABSPATH . 'wp-admin/includes/class-wp-upgrader.php';
- $upgrader = new WP_Automatic_Updater;
- $future_minor_update = (object) array(
- 'current' => $wp_version . '.1.next.minor',
- 'version' => $wp_version . '.1.next.minor',
- 'php_version' => $required_php_version,
- 'mysql_version' => $required_mysql_version,
- );
- $can_auto_update = $upgrader->should_update( 'core', $future_minor_update, ABSPATH );
</del><ins>+ echo '<p class="about-auto-update cool">' . __( 'This site <strong>is</strong> able to apply these updates automatically. Cool!' ). '</p>';
+
+ // If the updater is disabled entirely, don't show them anything.
+ } elseif ( ! $updater->is_disabled() ) {
+ echo '<p class="about-auto-update">';
+ // If this is is filtered to false, they won't get emails, so don't claim we will.
+ // Assumption: If the user can update core, they can see what the admin email is.
+
+ /** This filter is documented in wp-admin/includes/class-wp-upgrader.php */
+ if ( apply_filters( 'send_core_update_notification_email', true, $future_minor_update ) ) {
+ printf( __( 'This site <strong>is not</strong> able to apply these updates automatically. But we’ll email %s when there is a new security release.' ), esc_html( get_site_option( 'admin_email' ) ) );
+ } else {
+ _e( 'This site <strong>is not</strong> able to apply these updates automatically.' );
+ }
+ echo '</p>';
</ins><span class="cx"> }
</span><del>- if ( $can_auto_update ) : ?>
- <p class="about-auto-update cool"><?php _e( 'This site <strong>is</strong> able to apply these updates automatically. Cool!' ); ?></p>
- <?php else : ?>
- <p class="about-auto-update"><?php printf( __( 'This site <strong>is not</strong> able to apply these updates automatically. But we’ll email %s when there is a new security release.' ), esc_html( get_site_option( 'admin_email' ) ) ); ?></p>
- <?php endif; ?>
</del><ins>+ }
+ ?>
</ins><span class="cx"> </div>
</span><span class="cx"> </div>
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>