<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[25708] trunk/src/wp-admin/js/nav-menu.js: Optimize the accessibility JS on the Menus screen to avoid browser crashes with very large menus.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/25708">25708</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2013-10-07 13:37:00 +0000 (Mon, 07 Oct 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Optimize the accessibility JS on the Menus screen to avoid browser crashes with very large menus.
props atimmer.
fixes <a href="http://core.trac.wordpress.org/ticket/25112">#25112</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpadminjsnavmenujs">trunk/src/wp-admin/js/nav-menu.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpadminjsnavmenujs"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-admin/js/nav-menu.js (25707 => 25708)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-admin/js/nav-menu.js 2013-10-07 13:18:31 UTC (rev 25707)
+++ trunk/src/wp-admin/js/nav-menu.js 2013-10-07 13:37:00 UTC (rev 25708)
</span><span class="lines">@@ -403,16 +403,16 @@
</span><span class="cx"> refreshAdvancedAccessibility : function() {
</span><span class="cx">
</span><span class="cx"> // Hide all links by default
</span><del>- $( '.menu-item-settings .field-move a' ).hide();
</del><ins>+ $( '.menu-item-settings .field-move a' ).css( 'display', 'none' );
</ins><span class="cx">
</span><span class="cx"> $( '.item-edit' ).each( function() {
</span><span class="cx"> var $this = $(this),
</span><span class="cx"> movement = [],
</span><span class="cx"> availableMovement = '',
</span><del>- menuItem = $this.parents( 'li.menu-item' ).first(),
</del><ins>+ menuItem = $this.closest( 'li.menu-item' ).first(),
</ins><span class="cx"> depth = menuItem.menuItemDepth(),
</span><span class="cx"> isPrimaryMenuItem = ( 0 === depth ),
</span><del>- itemName = $this.parents( '.menu-item-handle' ).find( '.menu-item-title' ).text(),
</del><ins>+ itemName = $this.closest( '.menu-item-handle' ).find( '.menu-item-title' ).text(),
</ins><span class="cx"> position = parseInt( menuItem.index() ),
</span><span class="cx"> prevItemDepth = ( isPrimaryMenuItem ) ? depth : parseInt( depth - 1 ),
</span><span class="cx"> prevItemNameLeft = menuItem.prevAll('.menu-item-depth-' + prevItemDepth).first().find( '.menu-item-title' ).text(),
</span><span class="lines">@@ -423,35 +423,35 @@
</span><span class="cx"> // Where can they move this menu item?
</span><span class="cx"> if ( 0 !== position ) {
</span><span class="cx"> var thisLink = menuItem.find( '.menus-move-up' );
</span><del>- thisLink.prop( 'title', menus.moveUp ).show();
</del><ins>+ thisLink.prop( 'title', menus.moveUp ).css( 'display', 'inline' );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if ( 0 !== position && isPrimaryMenuItem ) {
</span><span class="cx"> var thisLink = menuItem.find( '.menus-move-top' );
</span><del>- thisLink.prop( 'title', menus.moveToTop ).show();
</del><ins>+ thisLink.prop( 'title', menus.moveToTop ).css( 'display', 'inline' );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if ( position + 1 !== totalMenuItems && 0 !== position ) {
</span><span class="cx"> var thisLink = menuItem.find( '.menus-move-down' );
</span><del>- thisLink.prop( 'title', menus.moveDown ).show();
</del><ins>+ thisLink.prop( 'title', menus.moveDown ).css( 'display', 'inline' );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if ( 0 === position && 0 !== hasSameDepthSibling ) {
</span><span class="cx"> var thisLink = menuItem.find( '.menus-move-down' );
</span><del>- thisLink.prop( 'title', menus.moveDown ).show();
</del><ins>+ thisLink.prop( 'title', menus.moveDown ).css( 'display', 'inline' );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if ( ! isPrimaryMenuItem ) {
</span><span class="cx"> var thisLink = menuItem.find( '.menus-move-left' ),
</span><span class="cx"> thisLinkText = menus.outFrom.replace( '%s', prevItemNameLeft );
</span><del>- thisLink.prop( 'title', menus.moveOutFrom.replace( '%s', prevItemNameLeft ) ).html( thisLinkText ).show();
</del><ins>+ thisLink.prop( 'title', menus.moveOutFrom.replace( '%s', prevItemNameLeft ) ).html( thisLinkText ).css( 'display', 'inline' );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if ( 0 !== position ) {
</span><span class="cx"> if ( menuItem.find( '.menu-item-data-parent-id' ).val() !== menuItem.prev().find( '.menu-item-data-db-id' ).val() ) {
</span><span class="cx"> var thisLink = menuItem.find( '.menus-move-right' ),
</span><span class="cx"> thisLinkText = menus.under.replace( '%s', prevItemNameRight );
</span><del>- thisLink.prop( 'title', menus.moveUnder.replace( '%s', prevItemNameRight ) ).html( thisLinkText ).show();
</del><ins>+ thisLink.prop( 'title', menus.moveUnder.replace( '%s', prevItemNameRight ) ).html( thisLinkText ).css( 'display', 'inline' );
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>