<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[25373] trunk/tests/phpunit: Fix the PHP 5.4 `Only variables should be passed by reference` notices in `tests/action.php`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/25373">25373</a></dd>
<dt>Author</dt> <dd>wonderboymusic</dd>
<dt>Date</dt> <dd>2013-09-12 03:53:56 +0000 (Thu, 12 Sep 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix the PHP 5.4 `Only variables should be passed by reference` notices in `tests/action.php`.
See <a href="http://core.trac.wordpress.org/ticket/25282">#25282</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunitdataimagesa2small100x75jpg">trunk/tests/phpunit/data/images/a2-small-100x75.jpg</a></li>
<li><a href="#trunktestsphpunittestsactionsphp">trunk/tests/phpunit/tests/actions.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunitdataimagesa2small100x75jpg"></a>
<div class="binary"><h4>Modified: trunk/tests/phpunit/data/images/a2-small-100x75.jpg</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<a id="trunktestsphpunittestsactionsphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/phpunit/tests/actions.php (25372 => 25373)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/phpunit/tests/actions.php 2013-09-12 03:43:48 UTC (rev 25372)
+++ trunk/tests/phpunit/tests/actions.php 2013-09-12 03:53:56 UTC (rev 25373)
</span><span class="lines">@@ -19,7 +19,8 @@
</span><span class="cx"> // only our hook was called
</span><span class="cx"> $this->assertEquals(array($tag), $a->get_tags());
</span><span class="cx">
</span><del>- $args = array_pop($a->get_args());
</del><ins>+ $argsvar = $a->get_args();
+ $args = array_pop( $argsvar );
</ins><span class="cx"> $this->assertEquals(array(''), $args);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -43,17 +44,17 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function test_has_action() {
</span><del>- $tag = rand_str();
- $func = rand_str();
</del><ins>+ $tag = rand_str();
+ $func = rand_str();
</ins><span class="cx">
</span><del>- $this->assertFalse( has_action($tag, $func) );
- $this->assertFalse( has_action($tag) );
- add_action($tag, $func);
- $this->assertEquals( 10, has_action($tag, $func) );
- $this->assertTrue( has_action($tag) );
- remove_action($tag, $func);
- $this->assertFalse( has_action($tag, $func) );
- $this->assertFalse( has_action($tag) );
</del><ins>+ $this->assertFalse( has_action($tag, $func) );
+ $this->assertFalse( has_action($tag) );
+ add_action($tag, $func);
+ $this->assertEquals( 10, has_action($tag, $func) );
+ $this->assertTrue( has_action($tag) );
+ remove_action($tag, $func);
+ $this->assertFalse( has_action($tag, $func) );
+ $this->assertFalse( has_action($tag) );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // one tag with multiple actions
</span><span class="lines">@@ -82,8 +83,10 @@
</span><span class="cx"> // call the action with a single argument
</span><span class="cx"> do_action($tag, $val);
</span><span class="cx">
</span><del>- $this->assertEquals(1, $a->get_call_count());
- $this->assertEquals(array($val), array_pop($a->get_args()));
</del><ins>+ $call_count = $a->get_call_count();
+ $this->assertEquals(1, $call_count);
+ $argsvar = $a->get_args();
+ $this->assertEquals( array( $val ), array_pop( $argsvar ) );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function test_action_args_2() {
</span><span class="lines">@@ -99,13 +102,16 @@
</span><span class="cx"> // call the action with two arguments
</span><span class="cx"> do_action($tag, $val1, $val2);
</span><span class="cx">
</span><ins>+ $call_count = $a1->get_call_count();
</ins><span class="cx"> // a1 should be called with both args
</span><del>- $this->assertEquals(1, $a1->get_call_count());
- $this->assertEquals(array($val1, $val2), array_pop($a1->get_args()));
</del><ins>+ $this->assertEquals(1, $call_count);
+ $argsvar1 = $a1->get_args();
+ $this->assertEquals( array( $val1, $val2 ), array_pop( $argsvar1 ) );
</ins><span class="cx">
</span><span class="cx"> // a2 should be called with one only
</span><span class="cx"> $this->assertEquals(1, $a2->get_call_count());
</span><del>- $this->assertEquals(array($val1), array_pop($a2->get_args()));
</del><ins>+ $argsvar2 = $a2->get_args();
+ $this->assertEquals( array( $val1 ), array_pop( $argsvar2 ) );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function test_action_priority() {
</span></span></pre>
</div>
</div>
</body>
</html>