<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[25292] trunk: Check the value passed to `get_post_type_object()`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/25292">25292</a></dd>
<dt>Author</dt> <dd>wonderboymusic</dd>
<dt>Date</dt> <dd>2013-09-06 23:38:51 +0000 (Fri, 06 Sep 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Check the value passed to `get_post_type_object()`. If it's an array, use the first item. `get_query_var( 'post_type' )` can be an array if the query has been altered via filters/actions. There are several places in core that pass the query var. Adds unit tests.
In `template-loader.php`, move `is_post_type_archive()` and `is_tax()` directly below `is_home()`.
See <a href="http://core.trac.wordpress.org/ticket/18614">#18614</a>, <a href="http://core.trac.wordpress.org/changeset/25291">[25291]</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludespostphp">trunk/src/wp-includes/post.php</a></li>
<li><a href="#trunksrcwpincludestemplateloaderphp">trunk/src/wp-includes/template-loader.php</a></li>
<li><a href="#trunktestsphpunittestsqueryconditionalsphp">trunk/tests/phpunit/tests/query/conditionals.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludespostphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/post.php (25291 => 25292)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/post.php 2013-09-06 22:06:40 UTC (rev 25291)
+++ trunk/src/wp-includes/post.php 2013-09-06 23:38:51 UTC (rev 25292)
</span><span class="lines">@@ -1058,6 +1058,9 @@
</span><span class="cx"> function get_post_type_object( $post_type ) {
</span><span class="cx"> global $wp_post_types;
</span><span class="cx">
</span><ins>+ if ( is_array( $post_type ) )
+ $post_type = reset( $post_type );
+
</ins><span class="cx"> if ( empty($wp_post_types[$post_type]) )
</span><span class="cx"> return null;
</span><span class="cx">
</span></span></pre></div>
<a id="trunksrcwpincludestemplateloaderphp"></a>
<div class="modfile"><h4>Modified: trunk/src/wp-includes/template-loader.php (25291 => 25292)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/wp-includes/template-loader.php 2013-09-06 22:06:40 UTC (rev 25291)
+++ trunk/src/wp-includes/template-loader.php 2013-09-06 23:38:51 UTC (rev 25292)
</span><span class="lines">@@ -26,10 +26,10 @@
</span><span class="cx"> $template = false;
</span><span class="cx"> if ( is_404() && $template = get_404_template() ) :
</span><span class="cx"> elseif ( is_search() && $template = get_search_template() ) :
</span><del>- elseif ( is_post_type_archive() && $template = get_post_type_archive_template() ) :
- elseif ( is_tax() && $template = get_taxonomy_template() ) :
</del><span class="cx"> elseif ( is_front_page() && $template = get_front_page_template() ) :
</span><span class="cx"> elseif ( is_home() && $template = get_home_template() ) :
</span><ins>+ elseif ( is_post_type_archive() && $template = get_post_type_archive_template() ) :
+ elseif ( is_tax() && $template = get_taxonomy_template() ) :
</ins><span class="cx"> elseif ( is_attachment() && $template = get_attachment_template() ) :
</span><span class="cx"> remove_filter('the_content', 'prepend_attachment');
</span><span class="cx"> elseif ( is_single() && $template = get_single_template() ) :
</span></span></pre></div>
<a id="trunktestsphpunittestsqueryconditionalsphp"></a>
<div class="modfile"><h4>Modified: trunk/tests/phpunit/tests/query/conditionals.php (25291 => 25292)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/phpunit/tests/query/conditionals.php 2013-09-06 22:06:40 UTC (rev 25291)
+++ trunk/tests/phpunit/tests/query/conditionals.php 2013-09-06 23:38:51 UTC (rev 25292)
</span><span class="lines">@@ -683,4 +683,37 @@
</span><span class="cx"> array( 'taxonomy' => 'post_tag', 'field' => 'term_id', 'terms' => $term->term_id )
</span><span class="cx"> ) );
</span><span class="cx"> }
</span><ins>+
+ function test_post_type_array() {
+ delete_option( 'rewrite_rules' );
+
+ $cpt_name = 'thearray';
+ register_post_type( $cpt_name, array(
+ 'taxonomies' => array( 'post_tag', 'category' ),
+ 'rewrite' => true,
+ 'has_archive' => true,
+ 'public' => true
+ ) );
+ $this->factory->post->create( array( 'post_type' => $cpt_name ) );
+
+ $this->go_to( "/$cpt_name/" );
+ $this->assertQueryTrue( 'is_post_type_archive', 'is_archive' );
+ $this->assertEquals( get_queried_object(), get_post_type_object( $cpt_name ) );
+ $this->assertEquals( get_queried_object(), get_post_type_object( array( $cpt_name ) ) );
+ $this->assertEquals( get_queried_object(), get_post_type_object( array( $cpt_name, 'post' ) ) );
+
+ add_action( 'pre_get_posts', array( $this, 'pre_get_posts_with_type_array' ) );
+
+ $this->go_to( "/$cpt_name/" );
+ $this->assertQueryTrue( 'is_post_type_archive', 'is_archive' );
+ $this->assertEquals( get_queried_object(), get_post_type_object( 'post' ) );
+ $this->assertEquals( get_queried_object(), get_post_type_object( array( 'post' ) ) );
+ $this->assertEquals( get_queried_object(), get_post_type_object( array( 'post', $cpt_name ) ) );
+
+ remove_action( 'pre_get_posts', array( $this, 'pre_get_posts_with_type_array' ) );
+ }
+
+ function pre_get_posts_with_type_array( &$query ) {
+ $query->set( 'post_type', array( 'post', 'thearray' ) );
+ }
</ins><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>