<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[24768] trunk/wp-admin: Revisions: tweak how tickmarks are rendered, to play nice with browsers who always round subpixel values down (Safari, Opera).</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/24768">24768</a></dd>
<dt>Author</dt> <dd>markjaquith</dd>
<dt>Date</dt> <dd>2013-07-22 21:09:49 +0000 (Mon, 22 Jul 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Revisions: tweak how tickmarks are rendered, to play nice with browsers who always round subpixel values down (Safari, Opera).
Also, some IE tweaks.
Fixes <a href="http://core.trac.wordpress.org/ticket/24736">#24736</a>. Props adamsilverstein, markjaquith, ocean90.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadmincsswpadminrtlcss">trunk/wp-admin/css/wp-admin-rtl.css</a></li>
<li><a href="#trunkwpadmincsswpadmincss">trunk/wp-admin/css/wp-admin.css</a></li>
<li><a href="#trunkwpadminjsrevisionsjs">trunk/wp-admin/js/revisions.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadmincsswpadminrtlcss"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/css/wp-admin-rtl.css (24767 => 24768)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/css/wp-admin-rtl.css 2013-07-22 18:55:05 UTC (rev 24767)
+++ trunk/wp-admin/css/wp-admin-rtl.css 2013-07-22 21:09:49 UTC (rev 24768)
</span><span class="lines">@@ -1030,7 +1030,7 @@
</span><span class="cx">
</span><span class="cx"> .revisions-tooltip {
</span><span class="cx"> margin-left: 0;
</span><del>- margin-right: -70px;
</del><ins>+ margin-right: -69px;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .revisions-tooltip.flipped {
</span><span class="lines">@@ -1042,6 +1042,10 @@
</span><span class="cx"> margin-right: -75px;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.ie8 .revisions-tooltip.flipped {
+ margin-left: -63px;
+}
+
</ins><span class="cx"> .revisions-tooltip-arrow {
</span><span class="cx"> right: 0;
</span><span class="cx"> margin-left: 0;
</span><span class="lines">@@ -1064,6 +1068,10 @@
</span><span class="cx"> left: 20px;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.ie8 .revisions-tooltip-arrow > span {
+ right: 21px;
+}
+
</ins><span class="cx"> .revisions-tooltip img {
</span><span class="cx"> float: right;
</span><span class="cx"> margin: 2px 0 0 5px;
</span></span></pre></div>
<a id="trunkwpadmincsswpadmincss"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/css/wp-admin.css (24767 => 24768)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/css/wp-admin.css 2013-07-22 18:55:05 UTC (rev 24767)
+++ trunk/wp-admin/css/wp-admin.css 2013-07-22 21:09:49 UTC (rev 24768)
</span><span class="lines">@@ -3539,17 +3539,15 @@
</span><span class="cx"> margin: 0 auto;
</span><span class="cx"> height: 0.8em;
</span><span class="cx"> top: 7px;
</span><del>- width: 100%;
- padding: 0 15%;
</del><ins>+ width: 70%;
</ins><span class="cx"> -moz-box-sizing: border-box;
</span><span class="cx"> -webkit-box-sizing: border-box;
</span><span class="cx"> box-sizing: border-box;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .revisions-tickmarks > div {
</span><del>- position: relative;
</del><ins>+ position: absolute;
</ins><span class="cx"> height: 100%;
</span><del>- float: left;
</del><span class="cx"> border-style: solid;
</span><span class="cx"> border-width: 0 1px 0 0;
</span><span class="cx"> -moz-box-sizing: border-box;
</span><span class="lines">@@ -3557,7 +3555,7 @@
</span><span class="cx"> box-sizing: border-box;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.revisions-tickmarks > div:last-child {
</del><ins>+.revisions-tickmarks > div:first-child {
</ins><span class="cx"> border-width: 0;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -3764,7 +3762,7 @@
</span><span class="cx"> position: absolute;
</span><span class="cx"> bottom: 105px;
</span><span class="cx"> margin-right: 0;
</span><del>- margin-left: -70px;
</del><ins>+ margin-left: -69px;
</ins><span class="cx"> z-index: 1;
</span><span class="cx"> max-width: 350px;
</span><span class="cx"> min-width: 130px;
</span><span class="lines">@@ -3824,11 +3822,15 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .ie8 .revisions-tooltip-arrow > span {
</span><del>- left: 14px;
</del><ins>+ left: 15px;
</ins><span class="cx"> top: -25px;
</span><span class="cx"> -ms-filter: "progid:DXImageTransform.Microsoft.Matrix(SizingMethod='auto expand', M11=0.7071067811865476, M12=-0.7071067811865475, M21=0.7071067811865475, M22=0.7071067811865476)";
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.ie8 .revisions-tooltip.flipped .revisions-tooltip-arrow > span {
+ right: 25px;
+}
+
</ins><span class="cx"> .revisions-tooltip,
</span><span class="cx"> .revisions-tooltip-arrow > span {
</span><span class="cx"> border-width: 1px;
</span></span></pre></div>
<a id="trunkwpadminjsrevisionsjs"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/js/revisions.js (24767 => 24768)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/js/revisions.js 2013-07-22 18:55:05 UTC (rev 24767)
+++ trunk/wp-admin/js/revisions.js 2013-07-22 21:09:49 UTC (rev 24768)
</span><span class="lines">@@ -615,30 +615,34 @@
</span><span class="cx"> // The tickmarks view
</span><span class="cx"> revisions.view.Tickmarks = wp.Backbone.View.extend({
</span><span class="cx"> className: 'revisions-tickmarks',
</span><ins>+ direction: isRtl ? 'right' : 'left',
</ins><span class="cx">
</span><span class="cx"> initialize: function() {
</span><span class="cx"> this.listenTo( this.model, 'change:revision', this.reportTickPosition );
</span><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> reportTickPosition: function( model, revision ) {
</span><del>- var elWidth, offset, tick, index = this.model.revisions.indexOf( revision );
</del><ins>+ var offset, thisOffset, parentOffset, tick, index = this.model.revisions.indexOf( revision );
+ thisOffset = this.$el.allOffsets();
+ parentOffset = this.$el.parent().allOffsets();
</ins><span class="cx"> if ( index === this.model.revisions.length - 1 ) {
</span><span class="cx"> // Last one
</span><del>- tick = this.$('div:nth-of-type(' + index + ')');
- offset = tick.allPositions();
- elWidth = tick.outerWidth();
- _.extend( offset, {
- rightPlusWidth: offset.right,
- leftPlusWidth: offset.left
- });
</del><ins>+ offset = {
+ rightPlusWidth: thisOffset.left - parentOffset.left + 1,
+ leftPlusWidth: thisOffset.right - parentOffset.right + 1
+ };
</ins><span class="cx"> } else {
</span><span class="cx"> // Normal tick
</span><span class="cx"> tick = this.$('div:nth-of-type(' + (index + 1) + ')');
</span><span class="cx"> offset = tick.allPositions();
</span><span class="cx"> _.extend( offset, {
</span><del>- leftPlusWidth: offset.left + tick.outerWidth() + 1,
- rightPlusWidth: offset.right + tick.outerWidth() + 1
</del><ins>+ left: offset.left + thisOffset.left - parentOffset.left,
+ right: offset.right + thisOffset.right - parentOffset.right
</ins><span class="cx"> });
</span><ins>+ _.extend( offset, {
+ leftPlusWidth: offset.left + tick.outerWidth(),
+ rightPlusWidth: offset.right + tick.outerWidth()
+ });
</ins><span class="cx"> }
</span><span class="cx"> this.model.set({ offset: offset });
</span><span class="cx"> },
</span><span class="lines">@@ -648,9 +652,8 @@
</span><span class="cx"> tickCount = this.model.revisions.length - 1;
</span><span class="cx"> tickWidth = 1 / tickCount;
</span><span class="cx">
</span><del>- _(tickCount).times( function(){ this.$el.append( '<div></div>' ); }, this );
-
- this.$('div').css( 'width', ( 100 * tickWidth ) + '%' );
</del><ins>+ _(tickCount).times( function( index ){
+ this.$el.append( '<div style="' + this.direction + ': ' + ( 100 * tickWidth * index ) + '%"></div>' ); }, this );
</ins><span class="cx"> }
</span><span class="cx"> });
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>