<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[24208] trunk: Logged out warnings:</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/24208">24208</a></dd>
<dt>Author</dt> <dd>azaozz</dd>
<dt>Date</dt> <dd>2013-05-08 22:45:58 +0000 (Wed, 08 May 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Logged out warnings:
- Don't use <base> tag to set target="_blank". It can break form submission. Instead, set target only on links with JS.
- Fix same domain comparison in wp_auth_check_html() when FORCE_SSL_LOGIN == true.
- Properly show/hide the "Close" button when the dialog is shown multiple times.
See <a href="http://core.trac.wordpress.org/ticket/23295">#23295</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludesfunctionsphp">trunk/wp-includes/functions.php</a></li>
<li><a href="#trunkwpincludesjswpauthcheckjs">trunk/wp-includes/js/wp-auth-check.js</a></li>
<li><a href="#trunkwploginphp">trunk/wp-login.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludesfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/functions.php (24207 => 24208)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/functions.php 2013-05-08 21:27:31 UTC (rev 24207)
+++ trunk/wp-includes/functions.php 2013-05-08 22:45:58 UTC (rev 24208)
</span><span class="lines">@@ -3921,7 +3921,7 @@
</span><span class="cx"> * Output the HTML that shows the wp-login dialog when the user is no longer logged in
</span><span class="cx"> */
</span><span class="cx"> function wp_auth_check_html() {
</span><del>- $login_url = wp_login_url();
</del><ins>+ $login_url = site_url( 'wp-login.php', 'login_post' );
</ins><span class="cx"> $current_domain = ( is_ssl() ? 'https://' : 'http://' ) . $_SERVER['HTTP_HOST'];
</span><span class="cx"> $same_domain = ( strpos( $login_url, $current_domain ) === 0 );
</span><span class="cx">
</span></span></pre></div>
<a id="trunkwpincludesjswpauthcheckjs"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/js/wp-auth-check.js (24207 => 24208)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/js/wp-auth-check.js 2013-05-08 21:27:31 UTC (rev 24207)
+++ trunk/wp-includes/js/wp-auth-check.js 2013-05-08 22:45:58 UTC (rev 24208)
</span><span class="lines">@@ -64,7 +64,7 @@
</span><span class="cx"> $(window).off( 'beforeunload.wp-auth-check' );
</span><span class="cx">
</span><span class="cx"> wrap.fadeOut( 200, function() {
</span><del>- wrap.addClass('hidden').css('display', '');
</del><ins>+ wrap.addClass('hidden').css('display', '').find('.wp-auth-check-close').css('display', '');
</ins><span class="cx"> $('#wp-auth-check-frame').remove();
</span><span class="cx"> });
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkwploginphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-login.php (24207 => 24208)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-login.php 2013-05-08 21:27:31 UTC (rev 24207)
+++ trunk/wp-login.php 2013-05-08 22:45:58 UTC (rev 24208)
</span><span class="lines">@@ -100,7 +100,6 @@
</span><span class="cx"> $classes[] = 'interim-login';
</span><span class="cx"> ?>
</span><span class="cx"> <style type="text/css">html{background-color: transparent;}</style>
</span><del>- <base target="_blank">
</del><span class="cx"> <?php
</span><span class="cx">
</span><span class="cx"> if ( 'success' === $interim_login )
</span><span class="lines">@@ -663,9 +662,7 @@
</span><span class="cx"> if ( isset($_POST['testcookie']) && empty($_COOKIE[TEST_COOKIE]) )
</span><span class="cx"> $errors->add('test_cookie', __("<strong>ERROR</strong>: Cookies are blocked or not supported by your browser. You must <a href='http://www.google.com/cookies.html'>enable cookies</a> to use WordPress."));
</span><span class="cx">
</span><del>- $form_target = '';
</del><span class="cx"> if ( $interim_login ) {
</span><del>- $form_target = ' target="_self"';
</del><span class="cx"> if ( ! $errors->get_error_code() )
</span><span class="cx"> $errors->add('expired', __('Session expired. Please log in again. You will not move away from this page.'), 'message');
</span><span class="cx"> } else {
</span><span class="lines">@@ -697,7 +694,7 @@
</span><span class="cx"> $rememberme = ! empty( $_POST['rememberme'] );
</span><span class="cx"> ?>
</span><span class="cx">
</span><del>-<form name="loginform" id="loginform" action="<?php echo esc_url( site_url( 'wp-login.php', 'login_post' ) ); ?>" method="post"<?php echo $form_target; ?>>
</del><ins>+<form name="loginform" id="loginform" action="<?php echo esc_url( site_url( 'wp-login.php', 'login_post' ) ); ?>" method="post">
</ins><span class="cx"> <p>
</span><span class="cx"> <label for="user_login"><?php _e('Username') ?><br />
</span><span class="cx"> <input type="text" name="log" id="user_login" class="input" value="<?php echo esc_attr($user_login); ?>" size="20" /></label>
</span><span class="lines">@@ -757,6 +754,17 @@
</span><span class="cx"> wp_attempt_focus();
</span><span class="cx"> <?php } ?>
</span><span class="cx"> if(typeof wpOnload=='function')wpOnload();
</span><ins>+<?php if ( $interim_login ) { ?>
+(function(){
+try {
+ var i, links = document.getElementsByTagName('a');
+ for ( i in links ) {
+ if ( links[i].href )
+ links[i].target = '_blank';
+ }
+} catch(e){}
+}());
+<?php } ?>
</ins><span class="cx"> </script>
</span><span class="cx">
</span><span class="cx"> <?php
</span></span></pre>
</div>
</div>
</body>
</html>