<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[23885] trunk/wp-includes: Revisions: remove the new _wp_last_revision_matches_current_post(), can be replaced by a simple revisions version check.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/23885">23885</a></dd>
<dt>Author</dt> <dd>azaozz</dd>
<dt>Date</dt> <dd>2013-04-02 19:39:48 +0000 (Tue, 02 Apr 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Revisions: remove the new _wp_last_revision_matches_current_post(), can be replaced by a simple revisions version check. Fixes <a href="http://core.trac.wordpress.org/ticket/23913">#23913</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludesposttemplatephp">trunk/wp-includes/post-template.php</a></li>
<li><a href="#trunkwpincludesrevisionphp">trunk/wp-includes/revision.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludesposttemplatephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/post-template.php (23884 => 23885)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/post-template.php 2013-04-01 15:21:19 UTC (rev 23884)
+++ trunk/wp-includes/post-template.php 2013-04-02 19:39:48 UTC (rev 23885)
</span><span class="lines">@@ -1424,7 +1424,7 @@
</span><span class="cx">
</span><span class="cx"> // Since 3.6 revisions include a copy of the current post data as a revision.
</span><span class="cx"> // The following removes that revision when $parent == false
</span><del>- $parent_included = _wp_last_revision_matches_current_post( $post_id );
</del><ins>+ $parent_included = _wp_get_post_revision_version( reset( $revisions ) ) > 0;
</ins><span class="cx"> if ( $parent_included && ! $parent )
</span><span class="cx"> array_shift( $revisions );
</span><span class="cx"> elseif ( ! $parent_included && $parent )
</span></span></pre></div>
<a id="trunkwpincludesrevisionphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/revision.php (23884 => 23885)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/revision.php 2013-04-01 15:21:19 UTC (rev 23884)
+++ trunk/wp-includes/revision.php 2013-04-02 19:39:48 UTC (rev 23885)
</span><span class="lines">@@ -658,49 +658,6 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><del>- * Determines if the specified post's most recent revision matches the post (by checking post_modified).
- *
- * @package WordPress
- * @subpackage Post_Revisions
- * @since 3.6.0
- *
- * @param int|object $post Post ID or post object.
- * @return bool false if not a match, otherwise true.
- */
-function _wp_last_revision_matches_current_post( $post ) {
- if ( ! $post = get_post( $post ) )
- return false;
-
- if ( ! $revisions = wp_get_post_revisions( $post->ID ) )
- return false;
-
- foreach ( $revisions as $revision ) {
- if ( false !== strpos( $revision->post_name, "{$revision->post_parent}-revision" ) ) {
- $last_revision = $revision;
- break;
- }
- }
-
- // No revisions yet, only autosaves
- if ( ! isset( $last_revision ) )
- return false;
-
- $post_has_changed = false;
- if ( $last_revision->post_modified == $post->post_modified ) {
- foreach ( array_keys( _wp_post_revision_fields() ) as $field ) {
- if ( normalize_whitespace( $post->$field ) != normalize_whitespace( $last_revision->$field ) ) {
- $post_has_changed = true;
- break;
- }
- }
- } else {
- return false;
- }
-
- return ! $post_has_changed;
-}
-
-/**
</del><span class="cx"> * Displays a human readable HTML representation of the difference between two strings.
</span><span class="cx"> * similar to wp_text_diff, but tracks and returns could of lines added and removed
</span><span class="cx"> *
</span></span></pre>
</div>
</div>
</body>
</html>