<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[23742] trunk/wp-admin/includes: Don't allow changing the post format from quick edit and bulk edit.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/23742">23742</a></dd>
<dt>Author</dt> <dd>ryan</dd>
<dt>Date</dt> <dd>2013-03-18 17:24:24 +0000 (Mon, 18 Mar 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Don't allow changing the post format from quick edit and bulk edit. These do not have sufficient context to set the post format.
Props kovshenin
fixes <a href="http://core.trac.wordpress.org/ticket/23426">#23426</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminincludesclasswppostslisttablephp">trunk/wp-admin/includes/class-wp-posts-list-table.php</a></li>
<li><a href="#trunkwpadminincludespostphp">trunk/wp-admin/includes/post.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminincludesclasswppostslisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/class-wp-posts-list-table.php (23741 => 23742)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/class-wp-posts-list-table.php 2013-03-18 17:17:55 UTC (rev 23741)
+++ trunk/wp-admin/includes/class-wp-posts-list-table.php 2013-03-18 17:24:24 UTC (rev 23742)
</span><span class="lines">@@ -1032,32 +1032,6 @@
</span><span class="cx"> <?php endif; // 'post' && $can_publish && current_user_can( 'edit_others_cap' ) ?>
</span><span class="cx">
</span><span class="cx"> </div>
</span><del>-
- <?php if ( post_type_supports( $screen->post_type, 'post-formats' ) && current_theme_supports( 'post-formats' ) ) :
- $post_formats = get_theme_support( 'post-formats' );
- if ( isset( $post_formats[0] ) && is_array( $post_formats[0] ) ) :
- $all_post_formats = get_post_format_strings();
- unset( $all_post_formats['standard'] ); ?>
- <div class="inline-edit-group">
- <label class="alignleft" for="post_format">
- <span class="title"><?php _ex( 'Format', 'post format' ); ?></span>
- <select name="post_format">
- <?php if ( $bulk ) : ?>
- <option value="-1"><?php _e( '&mdash; No Change &mdash;' ); ?></option>
- <?php endif; ?>
- <option value="0"><?php _ex( 'Standard', 'Post format' ); ?></option>
- <?php foreach ( $all_post_formats as $slug => $format ) :
- $unsupported = ! in_array( $slug, $post_formats[0] );
- if ( $bulk && $unsupported )
- continue;
- ?>
- <option value="<?php echo esc_attr( $slug ); ?>"<?php if ( $unsupported ) echo ' class="unsupported"'; ?>><?php echo esc_html( $format ); ?></option>
- <?php endforeach; ?>
- </select></label>
- </div>
- <?php endif; ?>
- <?php endif; // post-formats ?>
-
</del><span class="cx"> </div></fieldset>
</span><span class="cx">
</span><span class="cx"> <?php
</span></span></pre></div>
<a id="trunkwpadminincludespostphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/post.php (23741 => 23742)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/post.php 2013-03-18 17:17:55 UTC (rev 23741)
+++ trunk/wp-admin/includes/post.php 2013-03-18 17:24:24 UTC (rev 23742)
</span><span class="lines">@@ -352,14 +352,6 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if ( isset( $post_data['post_format'] ) ) {
- if ( '0' == $post_data['post_format'] )
- $post_data['post_format'] = false;
- // don't change the post format if it's not supported or not '0' (standard)
- elseif ( ! current_theme_supports( 'post-formats', $post_data['post_format'] ) )
- unset( $post_data['post_format'] );
- }
-
</del><span class="cx"> $updated = $skipped = $locked = array();
</span><span class="cx"> foreach ( $post_IDs as $post_ID ) {
</span><span class="cx"> $post_type_object = get_post_type_object( get_post_type( $post_ID ) );
</span><span class="lines">@@ -409,9 +401,6 @@
</span><span class="cx"> else
</span><span class="cx"> unstick_post( $post_ID );
</span><span class="cx"> }
</span><del>-
- if ( isset( $post_data['post_format'] ) )
- set_post_format( $post_ID, $post_data['post_format'] );
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> return array( 'updated' => $updated, 'skipped' => $skipped, 'locked' => $locked );
</span></span></pre>
</div>
</div>
</body>
</html>