<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[23492] trunk/wp-content/themes/twentythirteen: Twenty Thirteen: header area with no site title or tagline should still be clickable to home.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/23492">23492</a></dd>
<dt>Author</dt> <dd>lancewillett</dd>
<dt>Date</dt> <dd>2013-02-26 04:50:09 +0000 (Tue, 26 Feb 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Twenty Thirteen: header area with no site title or tagline should still be clickable to home. Fixes <a href="http://core.trac.wordpress.org/ticket/23549">#23549</a>.
Fix also removes several `!important` flags that aren't necessary, relating to header text color.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpcontentthemestwentythirteenheaderphp">trunk/wp-content/themes/twentythirteen/header.php</a></li>
<li><a href="#trunkwpcontentthemestwentythirteeninccustomheaderphp">trunk/wp-content/themes/twentythirteen/inc/custom-header.php</a></li>
<li><a href="#trunkwpcontentthemestwentythirteenjsthemecustomizerjs">trunk/wp-content/themes/twentythirteen/js/theme-customizer.js</a></li>
<li><a href="#trunkwpcontentthemestwentythirteenstylecss">trunk/wp-content/themes/twentythirteen/style.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpcontentthemestwentythirteenheaderphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-content/themes/twentythirteen/header.php (23491 => 23492)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-content/themes/twentythirteen/header.php 2013-02-26 04:42:46 UTC (rev 23491)
+++ trunk/wp-content/themes/twentythirteen/header.php 2013-02-26 04:50:09 UTC (rev 23492)
</span><span class="lines">@@ -39,10 +39,12 @@
</span><span class="cx"> <body <?php body_class(); ?>>
</span><span class="cx"> <div id="page" class="hfeed site">
</span><span class="cx"> <header id="masthead" class="site-header" role="banner">
</span><del>- <hgroup>
- <h1 class="site-title"><a href="<?php echo esc_url( home_url( '/' ) ); ?>" title="<?php echo esc_attr( get_bloginfo( 'name', 'display' ) ); ?>" rel="home"><?php bloginfo( 'name' ); ?></a></h1>
- <h2 class="site-description"><?php bloginfo( 'description' ); ?></h2>
- </hgroup>
</del><ins>+ <a href="<?php echo esc_url( home_url( '/' ) ); ?>" title="<?php echo esc_attr( get_bloginfo( 'name', 'display' ) ); ?>" rel="home">
+ <hgroup>
+ <h1 class="site-title"><?php bloginfo( 'name' ); ?></h1>
+ <h2 class="site-description"><?php bloginfo( 'description' ); ?></h2>
+ </hgroup>
+ </a>
</ins><span class="cx">
</span><span class="cx"> <div id="navbar" class="navbar">
</span><span class="cx"> <nav id="site-navigation" class="navigation main-navigation" role="navigation">
</span></span></pre></div>
<a id="trunkwpcontentthemestwentythirteeninccustomheaderphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-content/themes/twentythirteen/inc/custom-header.php (23491 => 23492)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-content/themes/twentythirteen/inc/custom-header.php 2013-02-26 04:42:46 UTC (rev 23491)
+++ trunk/wp-content/themes/twentythirteen/inc/custom-header.php 2013-02-26 04:50:09 UTC (rev 23492)
</span><span class="lines">@@ -112,9 +112,9 @@
</span><span class="cx"> // If the user has set a custom color for the text, use that.
</span><span class="cx"> elseif ( $text_color != get_theme_support( 'custom-header', 'default-text-color' ) ) :
</span><span class="cx"> ?>
</span><del>- .site-title a,
</del><ins>+ .site-title,
</ins><span class="cx"> .site-description {
</span><del>- color: #<?php echo esc_attr( $text_color ); ?> !important;
</del><ins>+ color: #<?php echo esc_attr( $text_color ); ?>;
</ins><span class="cx"> }
</span><span class="cx"> <?php endif; ?>
</span><span class="cx"> </style>
</span></span></pre></div>
<a id="trunkwpcontentthemestwentythirteenjsthemecustomizerjs"></a>
<div class="modfile"><h4>Modified: trunk/wp-content/themes/twentythirteen/js/theme-customizer.js (23491 => 23492)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-content/themes/twentythirteen/js/theme-customizer.js 2013-02-26 04:42:46 UTC (rev 23491)
+++ trunk/wp-content/themes/twentythirteen/js/theme-customizer.js 2013-02-26 04:50:09 UTC (rev 23492)
</span><span class="lines">@@ -9,7 +9,7 @@
</span><span class="cx"> // Site title and description.
</span><span class="cx"> wp.customize( 'blogname', function( value ) {
</span><span class="cx"> value.bind( function( to ) {
</span><del>- $( '.site-title a' ).text( to );
</del><ins>+ $( '.site-title' ).text( to );
</ins><span class="cx"> } );
</span><span class="cx"> } );
</span><span class="cx"> wp.customize( 'blogdescription', function( value ) {
</span></span></pre></div>
<a id="trunkwpcontentthemestwentythirteenstylecss"></a>
<div class="modfile"><h4>Modified: trunk/wp-content/themes/twentythirteen/style.css (23491 => 23492)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-content/themes/twentythirteen/style.css 2013-02-26 04:42:46 UTC (rev 23491)
+++ trunk/wp-content/themes/twentythirteen/style.css 2013-02-26 04:50:09 UTC (rev 23492)
</span><span class="lines">@@ -828,8 +828,13 @@
</span><span class="cx">
</span><span class="cx"> .site-header a {
</span><span class="cx"> color: #141412;
</span><ins>+ text-decoration: none;
</ins><span class="cx"> }
</span><span class="cx">
</span><ins>+.site-header .site-title:hover {
+ text-decoration: underline;
+}
+
</ins><span class="cx"> .site-title {
</span><span class="cx"> font-size: 60px;
</span><span class="cx"> font-weight: bold;
</span><span class="lines">@@ -1005,8 +1010,8 @@
</span><span class="cx"> z-index: 3;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.navbar-fixed #masthead .site-title a {
- color: #141412 !important; /* Must override custom header text color. */
</del><ins>+.navbar-fixed #masthead .site-title {
+ color: #141412;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .navbar-fixed .navbar {
</span></span></pre>
</div>
</div>
</body>
</html>