<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[23401] trunk/wp-includes: Use microtime() instead of incrementors for last_changed to to avoid race conditions with cache evictions.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/23401">23401</a></dd>
<dt>Author</dt> <dd>ryan</dd>
<dt>Date</dt> <dd>2013-02-11 18:08:14 +0000 (Mon, 11 Feb 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>Use microtime() instead of incrementors for last_changed to to avoid race conditions with cache evictions.
Props westi
fixes <a href="http://core.trac.wordpress.org/ticket/23448">#23448</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludescommentphp">trunk/wp-includes/comment.php</a></li>
<li><a href="#trunkwpincludesgeneraltemplatephp">trunk/wp-includes/general-template.php</a></li>
<li><a href="#trunkwpincludespostphp">trunk/wp-includes/post.php</a></li>
<li><a href="#trunkwpincludestaxonomyphp">trunk/wp-includes/taxonomy.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludescommentphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/comment.php (23400 => 23401)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/comment.php 2013-02-08 22:58:42 UTC (rev 23400)
+++ trunk/wp-includes/comment.php 2013-02-11 18:08:14 UTC (rev 23401)
</span><span class="lines">@@ -251,7 +251,7 @@
</span><span class="cx"> $key = md5( serialize( compact(array_keys($defaults)) ) );
</span><span class="cx"> $last_changed = wp_cache_get( 'last_changed', 'comment' );
</span><span class="cx"> if ( ! $last_changed ) {
</span><del>- $last_changed = 1;
</del><ins>+ $last_changed = microtime();
</ins><span class="cx"> wp_cache_set( 'last_changed', $last_changed, 'comment' );
</span><span class="cx"> }
</span><span class="cx"> $cache_key = "get_comments:$key:$last_changed";
</span><span class="lines">@@ -1292,12 +1292,7 @@
</span><span class="cx"> $comment = get_comment($id);
</span><span class="cx"> do_action('wp_insert_comment', $id, $comment);
</span><span class="cx">
</span><del>- if ( function_exists( 'wp_cache_incr' ) ) {
- wp_cache_incr( 'last_changed', 1, 'comment' );
- } else {
- $last_changed = wp_cache_get( 'last_changed', 'comment' );
- wp_cache_set( 'last_changed', $last_changed + 1, 'comment' );
- }
</del><ins>+ wp_cache_set( 'last_changed', microtime(), 'comment' );
</ins><span class="cx">
</span><span class="cx"> return $id;
</span><span class="cx"> }
</span><span class="lines">@@ -2050,12 +2045,7 @@
</span><span class="cx"> foreach ( (array) $ids as $id )
</span><span class="cx"> wp_cache_delete($id, 'comment');
</span><span class="cx">
</span><del>- if ( function_exists( 'wp_cache_incr' ) ) {
- wp_cache_incr( 'last_changed', 1, 'comment' );
- } else {
- $last_changed = wp_cache_get( 'last_changed', 'comment' );
- wp_cache_set( 'last_changed', $last_changed + 1, 'comment' );
- }
</del><ins>+ wp_cache_set( 'last_changed', microtime(), 'comment' );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span></span></pre></div>
<a id="trunkwpincludesgeneraltemplatephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/general-template.php (23400 => 23401)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/general-template.php 2013-02-08 22:58:42 UTC (rev 23400)
+++ trunk/wp-includes/general-template.php 2013-02-11 18:08:14 UTC (rev 23401)
</span><span class="lines">@@ -919,7 +919,7 @@
</span><span class="cx">
</span><span class="cx"> $last_changed = wp_cache_get( 'last_changed', 'posts' );
</span><span class="cx"> if ( ! $last_changed ) {
</span><del>- $last_changed = 1;
</del><ins>+ $last_changed = microtime();
</ins><span class="cx"> wp_cache_set( 'last_changed', $last_changed, 'posts' );
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkwpincludespostphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/post.php (23400 => 23401)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/post.php 2013-02-08 22:58:42 UTC (rev 23400)
+++ trunk/wp-includes/post.php 2013-02-11 18:08:14 UTC (rev 23401)
</span><span class="lines">@@ -3653,7 +3653,7 @@
</span><span class="cx"> $key = md5( serialize( compact(array_keys($defaults)) ) );
</span><span class="cx"> $last_changed = wp_cache_get( 'last_changed', 'posts' );
</span><span class="cx"> if ( ! $last_changed ) {
</span><del>- $last_changed = 1;
</del><ins>+ $last_changed = microtime();
</ins><span class="cx"> wp_cache_set( 'last_changed', $last_changed, 'posts' );
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -4672,12 +4672,7 @@
</span><span class="cx"> do_action( 'clean_page_cache', $post->ID );
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if ( function_exists( 'wp_cache_incr' ) ) {
- wp_cache_incr( 'last_changed', 1, 'posts' );
- } else {
- $last_changed = wp_cache_get( 'last_changed', 'posts' );
- wp_cache_set( 'last_changed', $last_changed + 1, 'posts' );
- }
</del><ins>+ wp_cache_set( 'last_changed', microtime(), 'posts' );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span></span></pre></div>
<a id="trunkwpincludestaxonomyphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/taxonomy.php (23400 => 23401)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/taxonomy.php 2013-02-08 22:58:42 UTC (rev 23400)
+++ trunk/wp-includes/taxonomy.php 2013-02-11 18:08:14 UTC (rev 23401)
</span><span class="lines">@@ -1242,7 +1242,7 @@
</span><span class="cx"> $key = md5( serialize( compact(array_keys($defaults)) ) . serialize( $taxonomies ) . $filter_key );
</span><span class="cx"> $last_changed = wp_cache_get( 'last_changed', 'terms' );
</span><span class="cx"> if ( ! $last_changed ) {
</span><del>- $last_changed = 1;
</del><ins>+ $last_changed = microtime();
</ins><span class="cx"> wp_cache_set( 'last_changed', $last_changed, 'terms' );
</span><span class="cx"> }
</span><span class="cx"> $cache_key = "get_terms:$key:$last_changed";
</span><span class="lines">@@ -2711,12 +2711,7 @@
</span><span class="cx"> do_action('clean_term_cache', $ids, $taxonomy);
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if ( function_exists( 'wp_cache_incr' ) ) {
- wp_cache_incr( 'last_changed', 1, 'terms' );
- } else {
- $last_changed = wp_cache_get( 'last_changed', 'terms' );
- wp_cache_set( 'last_changed', $last_changed + 1, 'terms' );
- }
</del><ins>+ wp_cache_set( 'last_changed', microtime(), 'terms' );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span></span></pre>
</div>
</div>
</body>
</html>