<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[23255] trunk/wp-includes: HTTP API: Introduce wp_is_writable() to wrap win_is_writable() and is_writable() to work around PHP Windows ACL issues.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/23255">23255</a></dd>
<dt>Author</dt> <dd>dd32</dd>
<dt>Date</dt> <dd>2013-01-03 08:04:11 +0000 (Thu, 03 Jan 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>HTTP API: Introduce wp_is_writable() to wrap win_is_writable() and is_writable() to work around PHP Windows ACL issues. See <a href="http://core.trac.wordpress.org/ticket/22900">#22900</a> for trunk</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludesclasshttpphp">trunk/wp-includes/class-http.php</a></li>
<li><a href="#trunkwpincludesfunctionsphp">trunk/wp-includes/functions.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludesclasshttpphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/class-http.php (23254 => 23255)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/class-http.php 2013-01-03 07:56:38 UTC (rev 23254)
+++ trunk/wp-includes/class-http.php 2013-01-03 08:04:11 UTC (rev 23255)
</span><span class="lines">@@ -141,7 +141,7 @@
</span><span class="cx"> // Force some settings if we are streaming to a file and check for existence and perms of destination directory
</span><span class="cx"> if ( $r['stream'] ) {
</span><span class="cx"> $r['blocking'] = true;
</span><del>- if ( ! is_writable( dirname( $r['filename'] ) ) )
</del><ins>+ if ( ! wp_is_writable( dirname( $r['filename'] ) ) )
</ins><span class="cx"> return new WP_Error( 'http_request_failed', __( 'Destination directory for file streaming does not exist or is not writable.' ) );
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkwpincludesfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/functions.php (23254 => 23255)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/functions.php 2013-01-03 07:56:38 UTC (rev 23254)
+++ trunk/wp-includes/functions.php 2013-01-03 08:04:11 UTC (rev 23255)
</span><span class="lines">@@ -1401,21 +1401,18 @@
</span><span class="cx"> if ( $temp )
</span><span class="cx"> return trailingslashit( rtrim( $temp, '\\' ) );
</span><span class="cx">
</span><del>- $is_win = ( 'WIN' === strtoupper( substr( PHP_OS, 0, 3 ) ) );
-
</del><span class="cx"> if ( function_exists('sys_get_temp_dir') ) {
</span><span class="cx"> $temp = sys_get_temp_dir();
</span><del>- if ( @is_dir( $temp ) && ( $is_win ? win_is_writable( $temp ) : @is_writable( $temp ) ) ) {
</del><ins>+ if ( @is_dir( $temp ) && wp_is_writable( $temp ) )
</ins><span class="cx"> return trailingslashit( rtrim( $temp, '\\' ) );
</span><del>- }
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> $temp = ini_get('upload_tmp_dir');
</span><del>- if ( is_dir( $temp ) && ( $is_win ? win_is_writable( $temp ) : @is_writable( $temp ) ) )
</del><ins>+ if ( is_dir( $temp ) && wp_is_writable( $temp ) )
</ins><span class="cx"> return trailingslashit( rtrim( $temp, '\\' ) );
</span><span class="cx">
</span><span class="cx"> $temp = WP_CONTENT_DIR . '/';
</span><del>- if ( is_dir( $temp ) && ( $is_win ? win_is_writable( $temp ) : @is_writable( $temp ) ) )
</del><ins>+ if ( is_dir( $temp ) && wp_is_writable( $temp ) )
</ins><span class="cx"> return $temp;
</span><span class="cx">
</span><span class="cx"> $temp = '/tmp/';
</span><span class="lines">@@ -1423,6 +1420,26 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><ins>+ * Determine if a directory is writable.
+ *
+ * This function is used to work around certain ACL issues
+ * in PHP primarily affecting Windows Servers.
+ *
+ * @see win_is_writable()
+ *
+ * @since 3.6.0
+ *
+ * @param string $path
+ * @return bool
+ */
+function wp_is_writable( $path ) {
+ if ( 'WIN' === strtoupper( substr( PHP_OS, 0, 3 ) ) )
+ return win_is_writable( $path );
+ else
+ return @is_writable( $path );
+}
+
+/**
</ins><span class="cx"> * Workaround for Windows bug in is_writable() function
</span><span class="cx"> *
</span><span class="cx"> * PHP has issues with Windows ACL's for determine if a
</span></span></pre>
</div>
</div>
</body>
</html>