<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[23029] trunk/wp-includes/js/media-views.js: Fix a Firefox "scroll to bottom" bug when launching the media modal.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/23029">23029</a></dd>
<dt>Author</dt> <dd>markjaquith</dd>
<dt>Date</dt> <dd>2012-12-04 17:58:24 +0000 (Tue, 04 Dec 2012)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix a Firefox "scroll to bottom" bug when launching the media modal.
* Records main document scroll position when launching media modal.
* Restores position when media modal is closed.
* Also locks background document scrolling while media modal is open, preventing inadvertent scrolling there.
props koopersmith. fixes <a href="http://core.trac.wordpress.org/ticket/22716">#22716</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludesjsmediaviewsjs">trunk/wp-includes/js/media-views.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludesjsmediaviewsjs"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/js/media-views.js (23028 => 23029)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/js/media-views.js 2012-12-04 17:45:24 UTC (rev 23028)
+++ trunk/wp-includes/js/media-views.js 2012-12-04 17:58:24 UTC (rev 23029)
</span><span class="lines">@@ -1866,7 +1866,8 @@
</span><span class="cx"> _.defaults( this.options, {
</span><span class="cx"> container: document.body,
</span><span class="cx"> title: '',
</span><del>- propagate: true
</del><ins>+ propagate: true,
+ freeze: document.body
</ins><span class="cx"> });
</span><span class="cx"> },
</span><span class="cx">
</span><span class="lines">@@ -1902,23 +1903,47 @@
</span><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> open: function() {
</span><del>- if ( this.$el.is(':visible') )
</del><ins>+ var $el = this.$el,
+ options = this.options,
+ $freeze;
+
+ if ( $el.is(':visible') )
</ins><span class="cx"> return this;
</span><span class="cx">
</span><span class="cx"> if ( ! this.views.attached )
</span><span class="cx"> this.attach();
</span><span class="cx">
</span><del>- this.$el.show().focus();
</del><ins>+ // If the `freeze` option is set, record the window's scroll
+ // position and the body's overflow, and then set overflow to hidden.
+ if ( options.freeze ) {
+ $freeze = $( options.freeze );
+ this._freeze = {
+ overflow: $freeze.css('overflow'),
+ scrollTop: $( window ).scrollTop()
+ };
+ $freeze.css( 'overflow', 'hidden' );
+ }
+
+ $el.show().focus();
</ins><span class="cx"> return this.propagate('open');
</span><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> close: function( options ) {
</span><ins>+ var freeze = this._freeze;
+
</ins><span class="cx"> if ( ! this.views.attached || ! this.$el.is(':visible') )
</span><span class="cx"> return this;
</span><span class="cx">
</span><span class="cx"> this.$el.hide();
</span><span class="cx"> this.propagate('close');
</span><span class="cx">
</span><ins>+ // If the `freeze` option is set, restore the container's scroll
+ // position and overflow property.
+ if ( freeze ) {
+ $( this.options.freeze ).css( 'overflow', freeze.overflow );
+ $( window ).scrollTop( freeze.scrollTop );
+ }
+
</ins><span class="cx"> if ( options && options.escape )
</span><span class="cx"> this.propagate('escape');
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>