<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[22725] trunk/wp-admin: Don't load autosave.js on the attachment editing screen, add simple AYS on unload if there are changes, props helenyhou, fixes #22491</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/22725">22725</a></dd>
<dt>Author</dt> <dd>azaozz</dd>
<dt>Date</dt> <dd>2012-11-20 19:46:38 +0000 (Tue, 20 Nov 2012)</dd>
</dl>
<h3>Log Message</h3>
<pre>Don't load autosave.js on the attachment editing screen, add simple AYS on unload if there are changes, props helenyhou, fixes <a href="http://core.trac.wordpress.org/ticket/22491">#22491</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadmineditformadvancedphp">trunk/wp-admin/edit-form-advanced.php</a></li>
<li><a href="#trunkwpadminpostnewphp">trunk/wp-admin/post-new.php</a></li>
<li><a href="#trunkwpadminpostphp">trunk/wp-admin/post.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadmineditformadvancedphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/edit-form-advanced.php (22724 => 22725)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/edit-form-advanced.php        2012-11-20 18:58:31 UTC (rev 22724)
+++ trunk/wp-admin/edit-form-advanced.php        2012-11-20 19:46:38 UTC (rev 22725)
</span><span class="lines">@@ -418,3 +418,21 @@
</span><span class="cx"> try{document.post.title.focus();}catch(e){}
</span><span class="cx"> </script>
</span><span class="cx"> <?php endif; ?>
</span><ins>+
+<?php if ( 'attachment' == $post_type ) { ?>
+<script type="text/javascript">
+(function($){
+        function getFieldsContent() {
+                return ($('#title').val() || '') + ($('#attachment_caption').val() || '') +
+                ($('#attachment_alt').val() || '') + ($('#attachment_content').val() || '') + ($('#post_name').val() || '');
+        }
+
+        var initial = getFieldsContent();
+
+        window.onbeforeunload = function() {
+                if ( initial != getFieldsContent() )
+                        return '<?php _e('The changes you made will be lost if you navigate away from this page.'); ?>';
+        };
+})(jQuery);
+</script>
+<?php } ?>
</ins></span></pre></div>
<a id="trunkwpadminpostnewphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/post-new.php (22724 => 22725)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/post-new.php        2012-11-20 18:58:31 UTC (rev 22724)
+++ trunk/wp-admin/post-new.php        2012-11-20 19:46:38 UTC (rev 22725)
</span><span class="lines">@@ -43,7 +43,8 @@
</span><span class="cx"> if ( ! wp_next_scheduled( 'wp_scheduled_auto_draft_delete' ) )
</span><span class="cx">         wp_schedule_event( time(), 'daily', 'wp_scheduled_auto_draft_delete' );
</span><span class="cx">
</span><del>-wp_enqueue_script('autosave');
</del><ins>+if ( 'attachment' !== $post_type )
+        wp_enqueue_script('autosave');
</ins><span class="cx">
</span><span class="cx"> // Show post form.
</span><span class="cx"> $post = get_default_post_to_edit( $post_type, true );
</span></span></pre></div>
<a id="trunkwpadminpostphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/post.php (22724 => 22725)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/post.php        2012-11-20 18:58:31 UTC (rev 22724)
+++ trunk/wp-admin/post.php        2012-11-20 19:46:38 UTC (rev 22725)
</span><span class="lines">@@ -169,7 +169,9 @@
</span><span class="cx">                 add_action('admin_notices', '_admin_notice_post_locked' );
</span><span class="cx">         } else {
</span><span class="cx">                 $active_post_lock = wp_set_post_lock( $post->ID );
</span><del>-                wp_enqueue_script('autosave');
</del><ins>+
+                if ( 'attachment' !== $post_type )
+                        wp_enqueue_script('autosave');
</ins><span class="cx">         }
</span><span class="cx">
</span><span class="cx">         $title = $post_type_object->labels->edit_item;
</span></span></pre>
</div>
</div>
</body>
</html>