<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[22268] trunk: Improve visible focus in the admin, props lessbloat, fixes #21324</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/22268">22268</a></dd>
<dt>Author</dt> <dd>azaozz</dd>
<dt>Date</dt> <dd>2012-10-22 19:51:51 +0000 (Mon, 22 Oct 2012)</dd>
</dl>
<h3>Log Message</h3>
<pre>Improve visible focus in the admin, props lessbloat, fixes <a href="http://core.trac.wordpress.org/ticket/21324">#21324</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadmincsscolorsclassiccss">trunk/wp-admin/css/colors-classic.css</a></li>
<li><a href="#trunkwpadmincsscolorsfreshcss">trunk/wp-admin/css/colors-fresh.css</a></li>
<li><a href="#trunkwpadmincsswpadmincss">trunk/wp-admin/css/wp-admin.css</a></li>
<li><a href="#trunkwpadminjscommonjs">trunk/wp-admin/js/common.js</a></li>
<li><a href="#trunkwpadminjspostjs">trunk/wp-admin/js/post.js</a></li>
<li><a href="#trunkwpincludescsseditorcss">trunk/wp-includes/css/editor.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadmincsscolorsclassiccss"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/css/colors-classic.css (22267 => 22268)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/css/colors-classic.css 2012-10-22 17:40:06 UTC (rev 22267)
+++ trunk/wp-admin/css/colors-classic.css 2012-10-22 19:51:51 UTC (rev 22268)
</span><span class="lines">@@ -195,10 +195,6 @@
</span><span class="cx"> background: #f1f1f1;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.wrap .add-new-h2:focus {
- background: #c7e7fd;
-}
-
</del><span class="cx"> .subtitle {
</span><span class="cx"> color: #777;
</span><span class="cx"> }
</span><span class="lines">@@ -324,19 +320,9 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> a:focus {
</span><del>- background: #c7e7fd;
</del><span class="cx"> color: #124964;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-a:active {
- background: none;
- outline: thin dotted;
-}
-
-#adminmenu a:active {
- outline: none;
-}
-
</del><span class="cx"> #adminmenu a:hover,
</span><span class="cx"> #adminmenu li.menu-top > a:focus,
</span><span class="cx"> #adminmenu .wp-submenu a:hover,
</span><span class="lines">@@ -793,6 +779,10 @@
</span><span class="cx"> color: #888;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.wp-admin .wp-editor-wrap .wp-switch-editor:active {
+ background-color: #f5fafd;
+}
+
</ins><span class="cx"> .wp-admin .wp-editor-wrap.tmce-active .switch-tmce,
</span><span class="cx"> .wp-admin .wp-editor-wrap.html-active .switch-html {
</span><span class="cx"> background: #f7fcfe;
</span><span class="lines">@@ -1420,11 +1410,6 @@
</span><span class="cx"> background: transparent url(../images/arrows.png) no-repeat right 4px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-#screen-meta-links a:focus {
- background-color: #c7e7fd;
- color: #124964;
-}
-
</del><span class="cx"> #screen-meta-links a:hover,
</span><span class="cx"> #screen-meta-links a:active {
</span><span class="cx"> color: #000;
</span></span></pre></div>
<a id="trunkwpadmincsscolorsfreshcss"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/css/colors-fresh.css (22267 => 22268)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/css/colors-fresh.css 2012-10-22 17:40:06 UTC (rev 22267)
+++ trunk/wp-admin/css/colors-fresh.css 2012-10-22 19:51:51 UTC (rev 22268)
</span><span class="lines">@@ -191,10 +191,6 @@
</span><span class="cx"> background: #f1f1f1;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.wrap .add-new-h2:focus {
- background: #c7e7fd;
-}
-
</del><span class="cx"> .subtitle {
</span><span class="cx"> color: #777;
</span><span class="cx"> }
</span><span class="lines">@@ -320,19 +316,9 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> a:focus {
</span><del>- background: #c7e7fd;
</del><span class="cx"> color: #124964;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-a:active {
- background: none;
- outline: thin dotted;
-}
-
-#adminmenu a:active {
- outline: none;
-}
-
</del><span class="cx"> #adminmenu a:hover,
</span><span class="cx"> #adminmenu li.menu-top > a:focus,
</span><span class="cx"> #adminmenu .wp-submenu a:hover,
</span><span class="lines">@@ -746,11 +732,6 @@
</span><span class="cx"> background: transparent url(../images/arrows.png) no-repeat right 4px;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-#screen-meta-links a:focus {
- background-color: #c7e7fd;
- color: #124964;
-}
-
</del><span class="cx"> #screen-meta-links a:hover,
</span><span class="cx"> #screen-meta-links a:active {
</span><span class="cx"> color: #333;
</span></span></pre></div>
<a id="trunkwpadmincsswpadmincss"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/css/wp-admin.css (22267 => 22268)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/css/wp-admin.css 2012-10-22 17:40:06 UTC (rev 22267)
+++ trunk/wp-admin/css/wp-admin.css 2012-10-22 19:51:51 UTC (rev 22268)
</span><span class="lines">@@ -309,13 +309,29 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> a,
</span><del>-input,
</del><ins>+input[type="text"],
+input[type="password"],
+input[type="number"],
+input[type="search"],
+input[type="email"],
+input[type="url"],
</ins><span class="cx"> select,
</span><span class="cx"> textarea,
</span><span class="cx"> div {
</span><span class="cx"> outline: 0;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+a:focus,
+a:active {
+ outline: thin dotted;
+}
+
+#adminmenu a:focus,
+#adminmenu a:active,
+.screen-reader-text:focus {
+ outline: none;
+}
+
</ins><span class="cx"> blockquote,
</span><span class="cx"> q {
</span><span class="cx"> quotes: none;
</span><span class="lines">@@ -706,7 +722,7 @@
</span><span class="cx"> input[type="tel"]:focus,
</span><span class="cx"> input[type="url"]:focus,
</span><span class="cx"> select:focus {
</span><del>- border-color: #a1a1a1;
</del><ins>+ border-color: #aaa;
</ins><span class="cx"> -webkit-box-shadow: 1px 1px 2px rgba(0,0,0,0.1);
</span><span class="cx"> box-shadow: 1px 1px 2px rgba(0,0,0,0.1);
</span><span class="cx"> }
</span><span class="lines">@@ -1159,6 +1175,12 @@
</span><span class="cx"> margin: 0 24px 0 0;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+#screen-meta-links a:focus {
+ -webkit-box-shadow: 1px 1px 1px rgba(0,0,0,0.4);
+ box-shadow: 1px 1px 1px rgba(0,0,0,0.4);
+ outline: none;
+}
+
</ins><span class="cx"> /* screen options and help tabs revert */
</span><span class="cx"> #screen-meta {
</span><span class="cx"> display: none;
</span><span class="lines">@@ -4538,6 +4560,10 @@
</span><span class="cx"> overflow: hidden;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.available-theme a.screenshot:focus {
+ border-color: #777;
+}
+
</ins><span class="cx"> #current-theme .theme-info li,
</span><span class="cx"> .theme-options li,
</span><span class="cx"> .available-theme .action-links li {
</span><span class="lines">@@ -6495,6 +6521,7 @@
</span><span class="cx"> width: 326px;
</span><span class="cx"> height: 67px;
</span><span class="cx"> text-indent: -9999px;
</span><ins>+ outline: none;
</ins><span class="cx"> overflow: hidden;
</span><span class="cx"> padding-bottom: 15px;
</span><span class="cx"> display: block;
</span></span></pre></div>
<a id="trunkwpadminjscommonjs"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/js/common.js (22267 => 22268)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/js/common.js 2012-10-22 17:40:06 UTC (rev 22267)
+++ trunk/wp-admin/js/common.js 2012-10-22 19:51:51 UTC (rev 22268)
</span><span class="lines">@@ -383,11 +383,6 @@
</span><span class="cx"> });
</span><span class="cx"> }
</span><span class="cx">
</span><del>- // Blur accessibility link background color onclick
- $(document).on('click.wp-accessibility-blur', 'a', function() {
- $(this).blur();
- });
-
</del><span class="cx"> // Scroll into view when focused
</span><span class="cx"> $('#contextual-help-link, #show-settings-link').on( 'focus.scroll-into-view', function(e){
</span><span class="cx"> if ( e.target.scrollIntoView )
</span></span></pre></div>
<a id="trunkwpadminjspostjs"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/js/post.js (22267 => 22268)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/js/post.js 2012-10-22 17:40:06 UTC (rev 22267)
+++ trunk/wp-admin/js/post.js 2012-10-22 19:51:51 UTC (rev 22268)
</span><span class="lines">@@ -124,9 +124,9 @@
</span><span class="cx"> init : function() {
</span><span class="cx"> var t = this, ajaxtag = $('div.ajaxtag');
</span><span class="cx">
</span><del>- $('.tagsdiv').each( function() {
- tagBox.quickClicks(this);
- });
</del><ins>+ $('.tagsdiv').each( function() {
+ tagBox.quickClicks(this);
+ });
</ins><span class="cx">
</span><span class="cx"> $('input.tagadd', ajaxtag).click(function(){
</span><span class="cx"> t.flushTags( $(this).closest('.tagsdiv') );
</span><span class="lines">@@ -138,8 +138,8 @@
</span><span class="cx">
</span><span class="cx"> $('input.newtag', ajaxtag).blur(function() {
</span><span class="cx"> if ( this.value == '' )
</span><del>- $(this).parent().siblings('.taghint').css('visibility', '');
- }).focus(function(){
</del><ins>+ $(this).parent().siblings('.taghint').css('visibility', '');
+ }).focus(function(){
</ins><span class="cx"> $(this).parent().siblings('.taghint').css('visibility', 'hidden');
</span><span class="cx"> }).keyup(function(e){
</span><span class="cx"> if ( 13 == e.which ) {
</span><span class="lines">@@ -156,20 +156,18 @@
</span><span class="cx"> $(this).suggest( ajaxurl + '?action=ajax-tag-search&tax=' + tax, { delay: 500, minchars: 2, multiple: true, multipleSep: postL10n.comma + ' ' } );
</span><span class="cx"> });
</span><span class="cx">
</span><del>- // save tags on post save/publish
- $('#post').submit(function(){
</del><ins>+ // save tags on post save/publish
+ $('#post').submit(function(){
</ins><span class="cx"> $('div.tagsdiv').each( function() {
</span><del>- tagBox.flushTags(this, false, 1);
</del><ins>+ tagBox.flushTags(this, false, 1);
</ins><span class="cx"> });
</span><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> // tag cloud
</span><span class="cx"> $('a.tagcloud-link').click(function(){
</span><del>- tagBox.get( $(this).attr('id') );
- $(this).unbind().click(function(){
- $(this).siblings('.the-tagcloud').toggle();
- return false;
- });
</del><ins>+ if ( ! $('.the-tagcloud').length )
+ tagBox.get( $(this).attr('id') );
+ $(this).siblings('.the-tagcloud').toggle();
</ins><span class="cx"> return false;
</span><span class="cx"> });
</span><span class="cx"> }
</span><span class="lines">@@ -277,9 +275,9 @@
</span><span class="cx"> taxonomyParts = this_id.split('-');
</span><span class="cx"> taxonomyParts.shift();
</span><span class="cx"> taxonomy = taxonomyParts.join('-');
</span><del>- settingName = taxonomy + '_tab';
- if ( taxonomy == 'category' )
- settingName = 'cats';
</del><ins>+ settingName = taxonomy + '_tab';
+ if ( taxonomy == 'category' )
+ settingName = 'cats';
</ins><span class="cx">
</span><span class="cx"> // TODO: move to jQuery 1.3+, support for multiple hierarchical taxonomies, see wp-lists.js
</span><span class="cx"> $('a', '#' + taxonomy + '-tabs').click( function(){
</span></span></pre></div>
<a id="trunkwpincludescsseditorcss"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/css/editor.css (22267 => 22268)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/css/editor.css 2012-10-22 17:40:06 UTC (rev 22267)
+++ trunk/wp-includes/css/editor.css 2012-10-22 19:51:51 UTC (rev 22268)
</span><span class="lines">@@ -1019,6 +1019,10 @@
</span><span class="cx"> float: left;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+.wp-switch-editor:active {
+ background-color: #f1f1f1;
+}
+
</ins><span class="cx"> .wp-switch-editor:hover {
</span><span class="cx"> text-decoration: none !important;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>