<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[22249] trunk: Accessibility shortcuts: new looks and fix for the WebKit focus bug, props lessbloat, fixes #21471</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/22249">22249</a></dd>
<dt>Author</dt> <dd>azaozz</dd>
<dt>Date</dt> <dd>2012-10-16 21:26:59 +0000 (Tue, 16 Oct 2012)</dd>
</dl>
<h3>Log Message</h3>
<pre>Accessibility shortcuts: new looks and fix for the WebKit focus bug, props lessbloat, fixes <a href="http://core.trac.wordpress.org/ticket/21471">#21471</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminadminheaderphp">trunk/wp-admin/admin-header.php</a></li>
<li><a href="#trunkwpadmincsswpadmincss">trunk/wp-admin/css/wp-admin.css</a></li>
<li><a href="#trunkwpadminjscommonjs">trunk/wp-admin/js/common.js</a></li>
<li><a href="#trunkwpincludesclasswpadminbarphp">trunk/wp-includes/class-wp-admin-bar.php</a></li>
<li><a href="#trunkwpincludescssadminbarcss">trunk/wp-includes/css/admin-bar.css</a></li>
<li><a href="#trunkwpincludesjsadminbarjs">trunk/wp-includes/js/admin-bar.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminadminheaderphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/admin-header.php (22248 => 22249)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/admin-header.php 2012-10-16 20:05:40 UTC (rev 22248)
+++ trunk/wp-admin/admin-header.php 2012-10-16 21:26:59 UTC (rev 22249)
</span><span class="lines">@@ -126,7 +126,7 @@
</span><span class="cx">
</span><span class="cx"> ?>
</span><span class="cx">
</span><del>-<div id="wpbody-content" aria-label="<?php esc_attr_e('Main content'); ?>">
</del><ins>+<div id="wpbody-content" aria-label="<?php esc_attr_e('Main content'); ?>" tabindex="0">
</ins><span class="cx"> <?php
</span><span class="cx">
</span><span class="cx"> $current_screen->render_screen_meta();
</span></span></pre></div>
<a id="trunkwpadmincsswpadmincss"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/css/wp-admin.css (22248 => 22249)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/css/wp-admin.css 2012-10-16 20:05:40 UTC (rev 22248)
+++ trunk/wp-admin/css/wp-admin.css 2012-10-16 21:26:59 UTC (rev 22249)
</span><span class="lines">@@ -192,23 +192,35 @@
</span><span class="cx"> .screen-reader-text span {
</span><span class="cx"> position: absolute;
</span><span class="cx"> left: -1000em;
</span><ins>+ top: -1000em;
</ins><span class="cx"> height: 1px;
</span><span class="cx"> width: 1px;
</span><span class="cx"> overflow: hidden;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .screen-reader-shortcut:focus {
</span><del>- left: 5px;
- top: 5px;
</del><ins>+ left: 6px;
+ top: -21px;
</ins><span class="cx"> height: auto;
</span><span class="cx"> width: auto;
</span><span class="cx"> display: block;
</span><del>- padding: 10px 15px;
- background: #fff;
- color: #000;
- border: 2px solid #333;
</del><ins>+ font-size: 14px;
+ font-weight: bold;
+ padding: 15px 23px 14px;
+ background: #8cc1ea;
+ background-image: -webkit-gradient(linear, left top, left bottom, from(#8cc1ea), to(#72a7cf));
+ background-image: -webkit-linear-gradient(top, #8cc1ea, #72a7cf);
+ background-image: -moz-linear-gradient(top, #8cc1ea, #72a7cf);
+ background-image: -o-linear-gradient(top, #8cc1ea, #72a7cf);
+ background-image: linear-gradient(to bottom, #8cc1ea, #72a7cf);
+ color: #fff;
</ins><span class="cx"> border-radius: 3px;
</span><span class="cx"> z-index: 100000;
</span><ins>+ text-shadow: 0 -1px 0 rgba(22, 57, 81, 0.3);
+ line-height: normal;
+ -webkit-box-shadow: 0 0 2px 2px rgba(0,0,0,.6);
+ box-shadow: 0 0 2px 2px rgba(0,0,0,.6);
+ text-decoration: none;
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> .hidden,
</span></span></pre></div>
<a id="trunkwpadminjscommonjs"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/js/common.js (22248 => 22249)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/js/common.js 2012-10-16 20:05:40 UTC (rev 22248)
+++ trunk/wp-admin/js/common.js 2012-10-16 21:26:59 UTC (rev 22249)
</span><span class="lines">@@ -369,6 +369,12 @@
</span><span class="cx"> $(document).on('click.wp-accessibility-blur', 'a', function() {
</span><span class="cx"> $(this).blur();
</span><span class="cx"> });
</span><ins>+
+ // Scroll into view when focused
+ $('#contextual-help-link, #show-settings-link').on( 'focus.scroll-into-view', function(e){
+ if ( e.target.scrollIntoView )
+ e.target.scrollIntoView(false);
+ });
</ins><span class="cx"> });
</span><span class="cx">
</span><span class="cx"> // internal use
</span></span></pre></div>
<a id="trunkwpincludesclasswpadminbarphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/class-wp-admin-bar.php (22248 => 22249)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/class-wp-admin-bar.php 2012-10-16 20:05:40 UTC (rev 22248)
+++ trunk/wp-includes/class-wp-admin-bar.php 2012-10-16 21:26:59 UTC (rev 22249)
</span><span class="lines">@@ -349,7 +349,7 @@
</span><span class="cx"> ?>
</span><span class="cx"> <div id="wpadminbar" class="<?php echo $class; ?>" role="navigation">
</span><span class="cx"> <a class="screen-reader-text screen-reader-shortcut" href="#wp-toolbar" tabindex="1"><?php _e('Skip to toolbar'); ?></a>
</span><del>- <div class="quicklinks" id="wp-toolbar" role="navigation" aria-label="<?php esc_attr_e('Top navigation toolbar.'); ?>">
</del><ins>+ <div class="quicklinks" id="wp-toolbar" role="navigation" aria-label="<?php esc_attr_e('Top navigation toolbar.'); ?>" tabindex="0">
</ins><span class="cx"> <?php foreach ( $root->children as $group ) {
</span><span class="cx"> $this->_render_group( $group );
</span><span class="cx"> } ?>
</span></span></pre></div>
<a id="trunkwpincludescssadminbarcss"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/css/admin-bar.css (22248 => 22249)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/css/admin-bar.css 2012-10-16 20:05:40 UTC (rev 22248)
+++ trunk/wp-includes/css/admin-bar.css 2012-10-16 21:26:59 UTC (rev 22249)
</span><span class="lines">@@ -608,25 +608,30 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> #wpadminbar .screen-reader-shortcut:focus {
</span><del>- left: 5px;
- top: 5px;
</del><ins>+ left: 6px;
+ top: 7px;
</ins><span class="cx"> height: auto;
</span><span class="cx"> width: auto;
</span><span class="cx"> display: block;
</span><del>- padding: 10px 15px;
- background: #fff;
- color: #000;
- border: 2px solid #333;
</del><ins>+ font-size: 14px;
+ font-weight: bold;
+ padding: 15px 23px 14px;
+ background: #8cc1ea;
+ background-image: -webkit-gradient(linear, left top, left bottom, from(#8cc1ea), to(#72a7cf));
+ background-image: -webkit-linear-gradient(top, #8cc1ea, #72a7cf);
+ background-image: -moz-linear-gradient(top, #8cc1ea, #72a7cf);
+ background-image: -o-linear-gradient(top, #8cc1ea, #72a7cf);
+ background-image: linear-gradient(to bottom, #8cc1ea, #72a7cf);
+ color: #fff;
</ins><span class="cx"> border-radius: 3px;
</span><span class="cx"> z-index: 100000;
</span><del>- text-shadow: none;
</del><ins>+ text-shadow: 0 -1px 0 rgba(22, 57, 81, 0.3);
</ins><span class="cx"> line-height: normal;
</span><ins>+ -webkit-box-shadow: 0 0 2px 2px rgba(0,0,0,.6);
+ box-shadow: 0 0 2px 2px rgba(0,0,0,.6);
+ text-decoration: none;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-#wpadminbar a.screen-reader-shortcut {
- text-decoration: underline;
-}
-
</del><span class="cx"> /**
</span><span class="cx"> * IE 6-targeted rules
</span><span class="cx"> */
</span></span></pre></div>
<a id="trunkwpincludesjsadminbarjs"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/js/admin-bar.js (22248 => 22249)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/js/admin-bar.js 2012-10-16 20:05:40 UTC (rev 22248)
+++ trunk/wp-includes/js/admin-bar.js 2012-10-16 21:26:59 UTC (rev 22249)
</span><span class="lines">@@ -67,6 +67,19 @@
</span><span class="cx"> $('html, body').animate({ scrollTop: 0 }, 'fast');
</span><span class="cx"> });
</span><span class="cx">
</span><ins>+ // fix focus bug in WebKit
+ $('.screen-reader-shortcut').keydown( function(e) {
+ if ( 13 != e.which )
+ return;
+
+ var id = $(this).attr('href');
+
+ if ( $.browser.webkit && id && id.charAt(0) == '#' ) {
+ setTimeout(function () {
+ $(id).focus();
+ }, 100);
+ }
+ });
</ins><span class="cx"> });
</span><span class="cx"> } else {
</span><span class="cx"> (function(d, w) {
</span></span></pre>
</div>
</div>
</body>
</html>