<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[22158] trunk/wp-includes: Media JS: Improve markup and CSS of the modal view's title.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/22158">22158</a></dd>
<dt>Author</dt> <dd>koopersmith</dd>
<dt>Date</dt> <dd>2012-10-10 09:40:22 +0000 (Wed, 10 Oct 2012)</dd>
</dl>
<h3>Log Message</h3>
<pre>Media JS: Improve markup and CSS of the modal view's title.
Also improves the accuracy of closing the modal when the backdrop is clicked (which became error-prone around the title bar in <a href="http://core.trac.wordpress.org/changeset/22144">[22144]</a>).
see <a href="http://core.trac.wordpress.org/ticket/21390">#21390</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludescssmediaviewscss">trunk/wp-includes/css/media-views.css</a></li>
<li><a href="#trunkwpincludesmediaphp">trunk/wp-includes/media.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludescssmediaviewscss"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/css/media-views.css (22157 => 22158)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/css/media-views.css 2012-10-10 09:30:22 UTC (rev 22157)
+++ trunk/wp-includes/css/media-views.css 2012-10-10 09:40:22 UTC (rev 22158)
</span><span class="lines">@@ -3,7 +3,7 @@
</span><span class="cx"> */
</span><span class="cx"> .media-modal {
</span><span class="cx"> position: fixed;
</span><del>- top: 40px;
</del><ins>+ top: 80px;
</ins><span class="cx"> left: 60px;
</span><span class="cx"> right: 60px;
</span><span class="cx"> bottom: 60px;
</span><span class="lines">@@ -21,30 +21,28 @@
</span><span class="cx"> z-index: 120000;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.media-modal-header {
</del><ins>+.media-modal-title,
+.media-modal-close {
</ins><span class="cx"> position: absolute;
</span><del>- top: 0;
- left: 0;
- right: 0;
- height: 28px;
</del><ins>+ top: -40px;
+ height: 40px;
+
+ line-height: 40px;
+ color: #fff;
+ font-weight: 200;
+ text-shadow: 0 0 16px rgba( 0, 0, 0, 0.6 );
</ins><span class="cx"> }
</span><span class="cx">
</span><del>-.media-modal-header h3 {
</del><ins>+.media-modal-title {
+ left: 0;
</ins><span class="cx"> float: left;
</span><span class="cx"> padding: 0;
</span><span class="cx"> margin: 0;
</span><span class="cx"> font-size: 1.4em;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-.media-modal-header h3,
</del><span class="cx"> .media-modal-close {
</span><del>- line-height: 40px;
- color: #fff;
- font-weight: 200;
- text-shadow: 0 0 16px rgba( 0, 0, 0, 0.6 );
-}
-
-.media-modal-close {
</del><ins>+ right: 0;
</ins><span class="cx"> float: right;
</span><span class="cx"> text-decoration: none;
</span><span class="cx"> font-size: 1.8em;
</span><span class="lines">@@ -58,7 +56,7 @@
</span><span class="cx">
</span><span class="cx"> .media-modal-content {
</span><span class="cx"> position: absolute;
</span><del>- top: 40px;
</del><ins>+ top: 0;
</ins><span class="cx"> left: 0;
</span><span class="cx"> right: 0;
</span><span class="cx"> bottom: 0;
</span></span></pre></div>
<a id="trunkwpincludesmediaphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/media.php (22157 => 22158)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/media.php 2012-10-10 09:30:22 UTC (rev 22157)
+++ trunk/wp-includes/media.php 2012-10-10 09:40:22 UTC (rev 22158)
</span><span class="lines">@@ -1296,10 +1296,8 @@
</span><span class="cx"> ?>
</span><span class="cx"> <script type="text/html" id="tmpl-media-modal">
</span><span class="cx"> <div class="media-modal">
</span><del>- <div class="media-modal-header">
- <h3><%- title %></h3>
- <a class="media-modal-close" href="" title="<?php esc_attr_e('Close'); ?>">&times;</a>
- </div>
</del><ins>+ <h3 class="media-modal-title"><%- title %></h3>
+ <a class="media-modal-close" href="" title="<?php esc_attr_e('Close'); ?>">&times;</a>
</ins><span class="cx"> <div class="media-modal-content"></div>
</span><span class="cx"> </div>
</span><span class="cx"> <div class="media-modal-backdrop"></div>
</span></span></pre>
</div>
</div>
</body>
</html>