<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[21921] trunk: Posting: Make it much harder to create posts with invalid dates by enforcing the post date tests in the UI and the backend code.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/21921">21921</a></dd>
<dt>Author</dt> <dd>westi</dd>
<dt>Date</dt> <dd>2012-09-19 21:43:35 +0000 (Wed, 19 Sep 2012)</dd>
</dl>
<h3>Log Message</h3>
<pre>Posting: Make it much harder to create posts with invalid dates by enforcing the post date tests in the UI and the backend code.
Previously you could quite easily send a new post into the back of beyond by specifying an invalid date like the 30th Feb and this was very confusing.
Sometimes it would seem to work and sometimes the post would end up very far in the past - depending on the mysql version and other factors.
Fixes <a href="http://core.trac.wordpress.org/ticket/17180">#17180</a> props jkudish.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminincludespostphp">trunk/wp-admin/includes/post.php</a></li>
<li><a href="#trunkwpadminjspostjs">trunk/wp-admin/js/post.js</a></li>
<li><a href="#trunkwpincludespostphp">trunk/wp-includes/post.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminincludespostphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/post.php (21920 => 21921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/post.php 2012-09-19 18:59:36 UTC (rev 21920)
+++ trunk/wp-admin/includes/post.php 2012-09-19 21:43:35 UTC (rev 21921)
</span><span class="lines">@@ -122,6 +122,10 @@
</span><span class="cx"> $hh = ($hh > 23 ) ? $hh -24 : $hh;
</span><span class="cx"> $mn = ($mn > 59 ) ? $mn -60 : $mn;
</span><span class="cx"> $ss = ($ss > 59 ) ? $ss -60 : $ss;
</span><ins>+ $valid_date = apply_filters( '_wp_translate_postdata_valid_date', checkdate( $mm, $jj, $aa ), $post_data );
+ if ( !$valid_date ) {
+ return new WP_Error( 'invalid_date', __( 'Woops, the provided date is invalid.' ) );
+ }
</ins><span class="cx"> $post_data['post_date'] = sprintf( "%04d-%02d-%02d %02d:%02d:%02d", $aa, $mm, $jj, $hh, $mn, $ss );
</span><span class="cx"> $post_data['post_date_gmt'] = get_gmt_from_date( $post_data['post_date'] );
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkwpadminjspostjs"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/js/post.js (21920 => 21921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/js/post.js 2012-09-19 18:59:36 UTC (rev 21920)
+++ trunk/wp-admin/js/post.js 2012-09-19 21:43:35 UTC (rev 21921)
</span><span class="lines">@@ -528,6 +528,16 @@
</span><span class="cx"> return false;
</span><span class="cx"> });
</span><span class="cx">
</span><ins>+ $('#post').submit(function(e){
+ if ( !updateText() ) {
+ e.preventDefault();
+ $('#timestampdiv').show();
+ $('#publishing-action .ajax-loading').css('visibility', 'hidden');
+ $('#publish').prop('disabled', false).removeClass('button-primary-disabled');
+ return false;
+ }
+ });
+
</ins><span class="cx"> $('#post-status-select').siblings('a.edit-post-status').click(function() {
</span><span class="cx"> if ($('#post-status-select').is(":hidden")) {
</span><span class="cx"> $('#post-status-select').slideDown('fast');
</span></span></pre></div>
<a id="trunkwpincludespostphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/post.php (21920 => 21921)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/post.php 2012-09-19 18:59:36 UTC (rev 21920)
+++ trunk/wp-includes/post.php 2012-09-19 21:43:35 UTC (rev 21921)
</span><span class="lines">@@ -2633,6 +2633,15 @@
</span><span class="cx"> if ( empty($post_date) || '0000-00-00 00:00:00' == $post_date )
</span><span class="cx"> $post_date = current_time('mysql');
</span><span class="cx">
</span><ins>+ // validate the date
+ $mm = substr( $post_date, 5, 2 );
+ $jj = substr( $post_date, 8, 2 );
+ $aa = substr( $post_date, 0, 4 );
+ $valid_date = apply_filters( 'wp_insert_post_validate_date', checkdate( $mm, $jj, $aa ), $post_date );
+ if ( !$valid_date ) {
+ return new WP_Error( 'invalid_date', __( 'Woops, the provided date is invalid.' ) );
+ }
+
</ins><span class="cx"> if ( empty($post_date_gmt) || '0000-00-00 00:00:00' == $post_date_gmt ) {
</span><span class="cx"> if ( !in_array( $post_status, array( 'draft', 'pending', 'auto-draft' ) ) )
</span><span class="cx"> $post_date_gmt = get_gmt_from_date($post_date);
</span></span></pre>
</div>
</div>
</body>
</html>