<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[21317] trunk/wp-admin/includes: Add screen reader text to checkboxes in list tables.</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/21317">21317</a></dd>
<dt>Author</dt> <dd>ryan</dd>
<dt>Date</dt> <dd>2012-07-24 18:01:22 +0000 (Tue, 24 Jul 2012)</dd>
</dl>

<h3>Log Message</h3>
<pre>Add screen reader text to checkboxes in list tables. Props MikeLittle, nacin. see <a href="http://core.trac.wordpress.org/ticket/21325">#21325</a></pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminincludesclasswpcommentslisttablephp">trunk/wp-admin/includes/class-wp-comments-list-table.php</a></li>
<li><a href="#trunkwpadminincludesclasswplinkslisttablephp">trunk/wp-admin/includes/class-wp-links-list-table.php</a></li>
<li><a href="#trunkwpadminincludesclasswplisttablephp">trunk/wp-admin/includes/class-wp-list-table.php</a></li>
<li><a href="#trunkwpadminincludesclasswpmedialisttablephp">trunk/wp-admin/includes/class-wp-media-list-table.php</a></li>
<li><a href="#trunkwpadminincludesclasswppostslisttablephp">trunk/wp-admin/includes/class-wp-posts-list-table.php</a></li>
<li><a href="#trunkwpadminincludesclasswptermslisttablephp">trunk/wp-admin/includes/class-wp-terms-list-table.php</a></li>
<li><a href="#trunkwpadminincludesclasswpuserslisttablephp">trunk/wp-admin/includes/class-wp-users-list-table.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminincludesclasswpcommentslisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/class-wp-comments-list-table.php (21316 => 21317)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/class-wp-comments-list-table.php        2012-07-24 17:32:40 UTC (rev 21316)
+++ trunk/wp-admin/includes/class-wp-comments-list-table.php        2012-07-24 18:01:22 UTC (rev 21317)
</span><span class="lines">@@ -317,8 +317,10 @@
</span><span class="cx">         }
</span><span class="cx"> 
</span><span class="cx">         function column_cb( $comment ) {
</span><del>-                if ( $this-&gt;user_can )
-                        echo &quot;&lt;input type='checkbox' name='delete_comments[]' value='$comment-&gt;comment_ID' /&gt;&quot;;
</del><ins>+                if ( $this-&gt;user_can ) {
+                        echo '&lt;label class=&quot;screen-reader-text&quot; for=&quot;cb-select-' . $comment-&gt;comment_ID . '&quot;&gt;' . __( 'Select comment' )
+                                . &quot;&lt;/label&gt;&lt;input id='cb-select-$comment-&gt;comment_ID' type='checkbox' name='delete_comments[]' value='$comment-&gt;comment_ID' /&gt;&quot;;
+                }
</ins><span class="cx">         }
</span><span class="cx"> 
</span><span class="cx">         function column_comment( $comment ) {
</span></span></pre></div>
<a id="trunkwpadminincludesclasswplinkslisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/class-wp-links-list-table.php (21316 => 21317)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/class-wp-links-list-table.php        2012-07-24 17:32:40 UTC (rev 21316)
+++ trunk/wp-admin/includes/class-wp-links-list-table.php        2012-07-24 18:01:22 UTC (rev 21317)
</span><span class="lines">@@ -129,7 +129,8 @@
</span><span class="cx"> 
</span><span class="cx">                                 switch ( $column_name ) {
</span><span class="cx">                                         case 'cb':
</span><del>-                                                echo '&lt;th scope=&quot;row&quot; class=&quot;check-column&quot;&gt;&lt;input type=&quot;checkbox&quot; name=&quot;linkcheck[]&quot; value=&quot;'. esc_attr( $link-&gt;link_id ) .'&quot; /&gt;&lt;/th&gt;';
</del><ins>+                                                echo '&lt;th scope=&quot;row&quot; class=&quot;check-column&quot;&gt;&lt;label for=&quot;cb-select-' . $link-&gt;link_id . '&quot; class=&quot;screen-reader-text&quot;&gt;' . sprintf( __( 'Select %s' ), $link-&gt;link_name )
+                                                                . '&lt;/label&gt;&lt;input type=&quot;checkbox&quot; name=&quot;linkcheck[]&quot; id=&quot;cb-select-' . $link-&gt;link_id . '&quot; value=&quot;'. esc_attr( $link-&gt;link_id ) .'&quot; /&gt;&lt;/th&gt;';
</ins><span class="cx">                                                 break;
</span><span class="cx"> 
</span><span class="cx">                                         case 'name':
</span></span></pre></div>
<a id="trunkwpadminincludesclasswplisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/class-wp-list-table.php (21316 => 21317)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/class-wp-list-table.php        2012-07-24 17:32:40 UTC (rev 21316)
+++ trunk/wp-admin/includes/class-wp-list-table.php        2012-07-24 18:01:22 UTC (rev 21317)
</span><span class="lines">@@ -664,6 +664,13 @@
</span><span class="cx">                 else
</span><span class="cx">                         $current_order = 'asc';
</span><span class="cx"> 
</span><ins>+                if ( ! empty( $columns['cb'] ) ) {
+                        static $cb_counter = 1;
+                        $columns['cb'] = '&lt;label class=&quot;screen-reader-text&quot; for=&quot;cb-select-all-' . $cb_counter . '&quot;&gt;' . __( 'Select All' )
+                                . '&lt;/label&gt;&lt;input id=&quot;cb-select-all-' . $cb_counter . '&quot; type=&quot;checkbox&quot; /&gt;';
+                        $cb_counter++;
+                }
+
</ins><span class="cx">                 foreach ( $columns as $column_key =&gt; $column_display_name ) {
</span><span class="cx">                         $class = array( 'manage-column', &quot;column-$column_key&quot; );
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkwpadminincludesclasswpmedialisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/class-wp-media-list-table.php (21316 => 21317)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/class-wp-media-list-table.php        2012-07-24 17:32:40 UTC (rev 21316)
+++ trunk/wp-admin/includes/class-wp-media-list-table.php        2012-07-24 18:01:22 UTC (rev 21317)
</span><span class="lines">@@ -191,7 +191,8 @@
</span><span class="cx"> ?&gt;
</span><span class="cx">                 &lt;th scope=&quot;row&quot; class=&quot;check-column&quot;&gt;
</span><span class="cx">                         &lt;?php if ( $user_can_edit ) { ?&gt;
</span><del>-                                &lt;input type=&quot;checkbox&quot; name=&quot;media[]&quot; value=&quot;&lt;?php the_ID(); ?&gt;&quot; /&gt;
</del><ins>+                                &lt;label for=&quot;cb-select-&lt;?php the_ID(); ?&gt;&quot; class=&quot;screen-reader-text&quot;&gt;&lt;?php echo sprintf( __( 'Select %s' ), $att_title );?&gt;&lt;/label&gt;
+                                &lt;input type=&quot;checkbox&quot; name=&quot;media[]&quot; id=&quot;cb-select-&lt;?php the_ID(); ?&gt;&quot; value=&quot;&lt;?php the_ID(); ?&gt;&quot; /&gt;
</ins><span class="cx">                         &lt;?php } ?&gt;
</span><span class="cx">                 &lt;/th&gt;
</span><span class="cx"> &lt;?php
</span></span></pre></div>
<a id="trunkwpadminincludesclasswppostslisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/class-wp-posts-list-table.php (21316 => 21317)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/class-wp-posts-list-table.php        2012-07-24 17:32:40 UTC (rev 21316)
+++ trunk/wp-admin/includes/class-wp-posts-list-table.php        2012-07-24 18:01:22 UTC (rev 21317)
</span><span class="lines">@@ -492,7 +492,10 @@
</span><span class="cx"> 
</span><span class="cx">                         case 'cb':
</span><span class="cx">                         ?&gt;
</span><del>-                        &lt;th scope=&quot;row&quot; class=&quot;check-column&quot;&gt;&lt;?php if ( $can_edit_post ) { ?&gt;&lt;input type=&quot;checkbox&quot; name=&quot;post[]&quot; value=&quot;&lt;?php the_ID(); ?&gt;&quot; /&gt;&lt;?php } ?&gt;&lt;/th&gt;
</del><ins>+                        &lt;th scope=&quot;row&quot; class=&quot;check-column&quot;&gt;&lt;?php if ( $can_edit_post ) { ?&gt;
+                        &lt;label class=&quot;screen-reader-text&quot; for=&quot;cb-select-&lt;?php the_ID(); ?&gt;&quot;&gt;&lt;?php printf( __( 'Select %s' ), $title );
+                        ?&gt;&lt;/label&gt;&lt;input id=&quot;cb-select-&lt;?php the_ID(); ?&gt;&quot; type=&quot;checkbox&quot; name=&quot;post[]&quot; value=&quot;&lt;?php the_ID(); ?&gt;&quot; /&gt;
+                        &lt;?php } ?&gt;&lt;/th&gt;
</ins><span class="cx">                         &lt;?php
</span><span class="cx">                         break;
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkwpadminincludesclasswptermslisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/class-wp-terms-list-table.php (21316 => 21317)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/class-wp-terms-list-table.php        2012-07-24 17:32:40 UTC (rev 21316)
+++ trunk/wp-admin/includes/class-wp-terms-list-table.php        2012-07-24 18:01:22 UTC (rev 21317)
</span><span class="lines">@@ -236,9 +236,10 @@
</span><span class="cx">                 $default_term = get_option( 'default_' . $taxonomy );
</span><span class="cx"> 
</span><span class="cx">                 if ( current_user_can( $tax-&gt;cap-&gt;delete_terms ) &amp;&amp; $tag-&gt;term_id != $default_term )
</span><del>-                        return '&lt;input type=&quot;checkbox&quot; name=&quot;delete_tags[]&quot; value=&quot;' . $tag-&gt;term_id . '&quot; /&gt;';
-                else
-                        return '&amp;nbsp;';
</del><ins>+                        return '&lt;label for=&quot;cb-select-' . $tag-&gt;term_id . '&quot; class=&quot;screen-reader-text&quot;&gt;' . sprintf( __( 'Select %s' ), $tag-&gt;name )
+                                . '&lt;/label&gt;&lt;input type=&quot;checkbox&quot; name=&quot;delete_tags[]&quot; value=&quot;' . $tag-&gt;term_id . '&quot; id=&quot;cb-select-' . $tag-&gt;term_id . '&quot; /&gt;';
+
+                return '&amp;nbsp;';
</ins><span class="cx">         }
</span><span class="cx"> 
</span><span class="cx">         function column_name( $tag ) {
</span></span></pre></div>
<a id="trunkwpadminincludesclasswpuserslisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/class-wp-users-list-table.php (21316 => 21317)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/class-wp-users-list-table.php        2012-07-24 17:32:40 UTC (rev 21316)
+++ trunk/wp-admin/includes/class-wp-users-list-table.php        2012-07-24 18:01:22 UTC (rev 21317)
</span><span class="lines">@@ -256,7 +256,8 @@
</span><span class="cx">                         $edit .= $this-&gt;row_actions( $actions );
</span><span class="cx"> 
</span><span class="cx">                         // Set up the checkbox ( because the user is editable, otherwise its empty )
</span><del>-                        $checkbox = &quot;&lt;input type='checkbox' name='users[]' id='user_{$user_object-&gt;ID}' class='$role' value='{$user_object-&gt;ID}' /&gt;&quot;;
</del><ins>+                        $checkbox = '&lt;label for=&quot;cb-select-' . $user_object-&gt;ID . '&quot; class=&quot;screen-reader-text&quot;&gt;' . sprintf( __( 'Select %s' ), $user_object-&gt;user_login )
+                                                . &quot;&lt;/label&gt;&lt;input type='checkbox' name='users[]' id='user_{$user_object-&gt;ID}' class='$role' value='{$user_object-&gt;ID}' /&gt;&quot;;
</ins><span class="cx"> 
</span><span class="cx">                 } else {
</span><span class="cx">                         $edit = '&lt;strong&gt;' . $user_object-&gt;user_login . '&lt;/strong&gt;';
</span></span></pre>
</div>
</div>

</body>
</html>