<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[21310] trunk/wp-admin: Make it possible to tab out of the plugin and theme editors textareas by pressing Esc followed by Tab, fixes #21347</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/21310">21310</a></dd>
<dt>Author</dt> <dd>azaozz</dd>
<dt>Date</dt> <dd>2012-07-23 23:46:27 +0000 (Mon, 23 Jul 2012)</dd>
</dl>
<h3>Log Message</h3>
<pre>Make it possible to tab out of the plugin and theme editors textareas by pressing Esc followed by Tab, fixes <a href="http://core.trac.wordpress.org/ticket/21347">#21347</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminjscommondevjs">trunk/wp-admin/js/common.dev.js</a></li>
<li><a href="#trunkwpadminplugineditorphp">trunk/wp-admin/plugin-editor.php</a></li>
<li><a href="#trunkwpadminthemeeditorphp">trunk/wp-admin/theme-editor.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminjscommondevjs"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/js/common.dev.js (21309 => 21310)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/js/common.dev.js 2012-07-23 22:58:26 UTC (rev 21309)
+++ trunk/wp-admin/js/common.dev.js 2012-07-23 23:46:27 UTC (rev 21310)
</span><span class="lines">@@ -321,11 +321,25 @@
</span><span class="cx">
</span><span class="cx"> // tab in textareas
</span><span class="cx"> $('#newcontent').bind('keydown.wpevent_InsertTab', function(e) {
</span><del>- if ( e.keyCode != 9 )
- return true;
</del><ins>+ var el = e.target, selStart, selEnd, val, scroll, sel;
</ins><span class="cx">
</span><del>- var el = e.target, selStart = el.selectionStart, selEnd = el.selectionEnd, val = el.value, scroll, sel;
</del><ins>+ if ( e.keyCode == 27 ) { // escape key
+ $(el).data('tab-out', true);
+ return;
+ }
</ins><span class="cx">
</span><ins>+ if ( e.keyCode != 9 || e.ctrlKey || e.altKey || e.shiftKey ) // tab key
+ return;
+
+ if ( $(el).data('tab-out') ) {
+ $(el).data('tab-out', false);
+ return;
+ }
+
+ selStart = el.selectionStart;
+ selEnd = el.selectionEnd;
+ val = el.value;
+
</ins><span class="cx"> try {
</span><span class="cx"> this.lastKey = 9; // not a standard DOM property, lastKey is to help stop Opera tab event. See blur handler below.
</span><span class="cx"> } catch(err) {}
</span></span></pre></div>
<a id="trunkwpadminplugineditorphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/plugin-editor.php (21309 => 21310)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/plugin-editor.php 2012-07-23 22:58:26 UTC (rev 21309)
+++ trunk/wp-admin/plugin-editor.php 2012-07-23 23:46:27 UTC (rev 21310)
</span><span class="lines">@@ -226,7 +226,8 @@
</span><span class="cx"> </div>
</span><span class="cx"> <form name="template" id="template" action="plugin-editor.php" method="post">
</span><span class="cx"> <?php wp_nonce_field('edit-plugin_' . $file) ?>
</span><del>- <div><textarea cols="70" rows="25" name="newcontent" id="newcontent" tabindex="1"><?php echo $content ?></textarea>
</del><ins>+ <div><textarea cols="70" rows="25" name="newcontent" id="newcontent" aria-describedby="newcontent-description" tabindex="1"><?php echo $content ?></textarea>
+ <span id="newcontent-description" class="screen-reader-text"><?php _e('Content of the edited file. The Tab key enters a tab character, to move below this area, press the Esc key followed by the Tab key. Shift + Tab works as expected.'); ?></span>
</ins><span class="cx"> <input type="hidden" name="action" value="update" />
</span><span class="cx"> <input type="hidden" name="file" value="<?php echo esc_attr($file) ?>" />
</span><span class="cx"> <input type="hidden" name="plugin" value="<?php echo esc_attr($plugin) ?>" />
</span><span class="lines">@@ -256,12 +257,10 @@
</span><span class="cx"> <br class="clear" />
</span><span class="cx"> </div>
</span><span class="cx"> <script type="text/javascript">
</span><del>-/* <![CDATA[ */
</del><span class="cx"> jQuery(document).ready(function($){
</span><span class="cx"> $('#template').submit(function(){ $('#scrollto').val( $('#newcontent').scrollTop() ); });
</span><span class="cx"> $('#newcontent').scrollTop( $('#scrollto').val() );
</span><span class="cx"> });
</span><del>-/* ]]> */
</del><span class="cx"> </script>
</span><span class="cx"> <?php
</span><span class="cx"> break;
</span></span></pre></div>
<a id="trunkwpadminthemeeditorphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/theme-editor.php (21309 => 21310)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/theme-editor.php 2012-07-23 22:58:26 UTC (rev 21309)
+++ trunk/wp-admin/theme-editor.php 2012-07-23 23:46:27 UTC (rev 21310)
</span><span class="lines">@@ -198,12 +198,13 @@
</span><span class="cx"> else : ?>
</span><span class="cx"> <form name="template" id="template" action="theme-editor.php" method="post">
</span><span class="cx"> <?php wp_nonce_field( 'edit-theme_' . $file . $stylesheet ); ?>
</span><del>- <div><textarea cols="70" rows="30" name="newcontent" id="newcontent" tabindex="1"><?php echo $content ?></textarea>
- <input type="hidden" name="action" value="update" />
- <input type="hidden" name="file" value="<?php echo esc_attr( $relative_file ); ?>" />
- <input type="hidden" name="theme" value="<?php echo esc_attr( $theme->get_stylesheet() ); ?>" />
- <input type="hidden" name="scrollto" id="scrollto" value="<?php echo $scrollto; ?>" />
- </div>
</del><ins>+ <div><textarea cols="70" rows="30" name="newcontent" id="newcontent" aria-describedby="newcontent-description" tabindex="1"><?php echo $content ?></textarea>
+ <span id="newcontent-description" class="screen-reader-text"><?php _e('Content of the edited file. The Tab key enters a tab character, to move below this area, press the Esc key followed by the Tab key. Shift + Tab works as expected.'); ?></span>
+ <input type="hidden" name="action" value="update" />
+ <input type="hidden" name="file" value="<?php echo esc_attr( $relative_file ); ?>" />
+ <input type="hidden" name="theme" value="<?php echo esc_attr( $theme->get_stylesheet() ); ?>" />
+ <input type="hidden" name="scrollto" id="scrollto" value="<?php echo $scrollto; ?>" />
+ </div>
</ins><span class="cx"> <?php if ( ! empty( $functions ) ) : ?>
</span><span class="cx"> <div id="documentation" class="hide-if-no-js">
</span><span class="cx"> <label for="docs-list"><?php _e('Documentation:') ?></label>
</span></span></pre>
</div>
</div>
</body>
</html>