<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[21281] trunk/wp-admin/js/widgets.dev.js: Widgets UI: make the whole &quot;header&quot; clickable to open/close the widget (same as postboxes), remove deprecated jQuery .live(), part props lessbloat, fixes #21247</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/21281">21281</a></dd>
<dt>Author</dt> <dd>azaozz</dd>
<dt>Date</dt> <dd>2012-07-18 22:41:43 +0000 (Wed, 18 Jul 2012)</dd>
</dl>

<h3>Log Message</h3>
<pre>Widgets UI: make the whole &quot;header&quot; clickable to open/close the widget (same as postboxes), remove deprecated jQuery .live(), part props lessbloat, fixes <a href="http://core.trac.wordpress.org/ticket/21247">#21247</a></pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminjswidgetsdevjs">trunk/wp-admin/js/widgets.dev.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminjswidgetsdevjs"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/js/widgets.dev.js (21280 => 21281)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/js/widgets.dev.js        2012-07-18 18:41:17 UTC (rev 21280)
+++ trunk/wp-admin/js/widgets.dev.js        2012-07-18 22:41:43 UTC (rev 21281)
</span><span class="lines">@@ -31,41 +31,41 @@
</span><span class="cx">                         $(this).css( 'minHeight', h + 'px' );
</span><span class="cx">                 });
</span><span class="cx"> 
</span><del>-                $('a.widget-action').live('click', function(){
-                        var css = {}, widget = $(this).closest('div.widget'), inside = widget.children('.widget-inside'), w = parseInt( widget.find('input.widget-width').val(), 10 );
</del><ins>+                $(document.body).bind('click.widgets-toggle', function(e){
+                        var target = $(e.target), css = {}, widget, inside, w;
</ins><span class="cx"> 
</span><del>-                        if ( inside.is(':hidden') ) {
-                                if ( w &gt; 250 &amp;&amp; inside.closest('div.widgets-sortables').length ) {
-                                        css['width'] = w + 30 + 'px';
-                                        if ( inside.closest('div.widget-liquid-right').length )
-                                                css[margin] = 235 - w + 'px';
-                                        widget.css(css);
</del><ins>+                        if ( target.parents('.widget-top').length &amp;&amp; ! target.parents('#available-widgets').length ) {
+                                widget = target.closest('div.widget');
+                                inside = widget.children('.widget-inside');
+                                w = parseInt( widget.find('input.widget-width').val(), 10 );
+
+                                if ( inside.is(':hidden') ) {
+                                        if ( w &gt; 250 &amp;&amp; inside.closest('div.widgets-sortables').length ) {
+                                                css['width'] = w + 30 + 'px';
+                                                if ( inside.closest('div.widget-liquid-right').length )
+                                                        css[margin] = 235 - w + 'px';
+                                                widget.css(css);
+                                        }
+                                        wpWidgets.fixLabels(widget);
+                                        inside.slideDown('fast');
+                                } else {
+                                        inside.slideUp('fast', function() {
+                                                widget.css({'width':'', margin:''});
+                                        });
</ins><span class="cx">                                 }
</span><del>-                                wpWidgets.fixLabels(widget);
-                                inside.slideDown('fast');
-                        } else {
-                                inside.slideUp('fast', function() {
-                                        widget.css({'width':'', margin:''});
-                                });
</del><ins>+                                e.preventDefault();
+                        } else if ( target.hasClass('widget-control-save') ) {
+                                wpWidgets.save( target.closest('div.widget'), 0, 1, 0 );
+                                e.preventDefault();
+                        } else if ( target.hasClass('widget-control-remove') ) {
+                                wpWidgets.save( target.closest('div.widget'), 1, 1, 0 );
+                                e.preventDefault();
+                        } else if ( target.hasClass('widget-control-close') ) {
+                                wpWidgets.close( target.closest('div.widget') );
+                                e.preventDefault();
</ins><span class="cx">                         }
</span><del>-                        return false;
</del><span class="cx">                 });
</span><span class="cx"> 
</span><del>-                $('input.widget-control-save').live('click', function(){
-                        wpWidgets.save( $(this).closest('div.widget'), 0, 1, 0 );
-                        return false;
-                });
-
-                $('a.widget-control-remove').live('click', function(){
-                        wpWidgets.save( $(this).closest('div.widget'), 1, 1, 0 );
-                        return false;
-                });
-
-                $('a.widget-control-close').live('click', function(){
-                        wpWidgets.close( $(this).closest('div.widget') );
-                        return false;
-                });
-
</del><span class="cx">                 sidebars.children('.widget').each(function() {
</span><span class="cx">                         wpWidgets.appendTitle(this);
</span><span class="cx">                         if ( $('p.widget-error', this).length )
</span></span></pre>
</div>
</div>

</body>
</html>