<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[20797] trunk/wp-includes/js/customize-base.dev.js: Theme Customizer: Make wp.customize.Values.when return a jQuery.Deferred.promise() object, to add additional flexibility.</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/20797">20797</a></dd>
<dt>Author</dt> <dd>koopersmith</dd>
<dt>Date</dt> <dd>2012-05-15 22:01:36 +0000 (Tue, 15 May 2012)</dd>
</dl>

<h3>Log Message</h3>
<pre>Theme Customizer: Make wp.customize.Values.when return a jQuery.Deferred.promise() object, to add additional flexibility. see <a href="http://core.trac.wordpress.org/ticket/19910">#19910</a>.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludesjscustomizebasedevjs">trunk/wp-includes/js/customize-base.dev.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludesjscustomizebasedevjs"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/js/customize-base.dev.js (20796 => 20797)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/js/customize-base.dev.js        2012-05-15 21:58:21 UTC (rev 20796)
+++ trunk/wp-includes/js/customize-base.dev.js        2012-05-15 22:01:36 UTC (rev 20797)
</span><span class="lines">@@ -331,36 +331,46 @@
</span><span class="cx">                 /**
</span><span class="cx">                  * Runs a callback once all requested values exist.
</span><span class="cx">                  *
</span><del>-                 * when( ids*, callback );
</del><ins>+                 * when( ids*, [callback] );
</ins><span class="cx">                  *
</span><span class="cx">                  * For example:
</span><span class="cx">                  *     when( id1, id2, id3, function( value1, value2, value3 ) {} );
</span><ins>+                 *
+                 * @returns $.Deferred.promise();
</ins><span class="cx">                  */
</span><span class="cx">                 when: function() {
</span><span class="cx">                         var self = this,
</span><del>-                                ids = slice.call( arguments ),
-                                callback = ids.pop();
</del><ins>+                                ids  = slice.call( arguments ),
+                                dfd  = $.Deferred();
</ins><span class="cx"> 
</span><ins>+                        // If the last argument is a callback, bind it to .done()
+                        if ( $.isFunction( ids[ ids.length - 1 ] ) )
+                                dfd.done( ids.pop() );
+
</ins><span class="cx">                         $.when.apply( $, $.map( ids, function( id ) {
</span><span class="cx">                                 if ( self.has( id ) )
</span><span class="cx">                                         return;
</span><span class="cx"> 
</span><del>-                                return self._deferreds[ id ] || ( self._deferreds[ id ] = $.Deferred() );
</del><ins>+                                return self._deferreds[ id ] = self._deferreds[ id ] || $.Deferred();
</ins><span class="cx">                         })).done( function() {
</span><span class="cx">                                 var values = $.map( ids, function( id ) {
</span><span class="cx">                                                 return self( id );
</span><span class="cx">                                         });
</span><span class="cx"> 
</span><span class="cx">                                 // If a value is missing, we've used at least one expired deferred.
</span><del>-                                // Call Values.when again to update our master deferred.
</del><ins>+                                // Call Values.when again to generate a new deferred.
</ins><span class="cx">                                 if ( values.length !== ids.length ) {
</span><del>-                                        ids.push( callback );
-                                        self.when.apply( self, ids );
</del><ins>+                                        // ids.push( callback );
+                                        self.when.apply( self, ids ).done( function() {
+                                                dfd.resolveWith( self, values );
+                                        });
</ins><span class="cx">                                         return;
</span><span class="cx">                                 }
</span><span class="cx"> 
</span><del>-                                callback.apply( self, values );
</del><ins>+                                dfd.resolveWith( self, values );
</ins><span class="cx">                         });
</span><ins>+
+                        return dfd.promise();
</ins><span class="cx">                 }
</span><span class="cx">         });
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>