<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[20765] trunk/wp-admin: Normalize star ratings markup.</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/20765">20765</a></dd>
<dt>Author</dt> <dd>ryan</dd>
<dt>Date</dt> <dd>2012-05-10 19:59:48 +0000 (Thu, 10 May 2012)</dd>
</dl>

<h3>Log Message</h3>
<pre>Normalize star ratings markup. Props helenyhou. fixes <a href="http://core.trac.wordpress.org/ticket/20655">#20655</a></pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadmincsswpadminrtldevcss">trunk/wp-admin/css/wp-admin-rtl.dev.css</a></li>
<li><a href="#trunkwpadmincsswpadmindevcss">trunk/wp-admin/css/wp-admin.dev.css</a></li>
<li><a href="#trunkwpadminincludesclasswpthemeinstalllisttablephp">trunk/wp-admin/includes/class-wp-theme-install-list-table.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadmincsswpadminrtldevcss"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/css/wp-admin-rtl.dev.css (20764 => 20765)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/css/wp-admin-rtl.dev.css        2012-05-10 19:58:25 UTC (rev 20764)
+++ trunk/wp-admin/css/wp-admin-rtl.dev.css        2012-05-10 19:59:48 UTC (rev 20765)
</span><span class="lines">@@ -2274,7 +2274,7 @@
</span><span class="cx">         float: right;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-/* plugin-install */
</del><ins>+/* Star ratings */
</ins><span class="cx"> div.star-holder {
</span><span class="cx">         background: url('../images/stars-rtl.png?ver=20120506.png') repeat-x bottom right;
</span><span class="cx"> }
</span><span class="lines">@@ -2282,6 +2282,7 @@
</span><span class="cx">         background: url('../images/stars-rtl.png?ver=20120506.png') repeat-x top right;
</span><span class="cx">         float: right;
</span><span class="cx"> }
</span><ins>+
</ins><span class="cx"> #plugin-information ul#sidemenu {
</span><span class="cx">         left: auto;
</span><span class="cx">         right: 0;
</span><span class="lines">@@ -2426,16 +2427,10 @@
</span><span class="cx">         float: right;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-.theme-details .theme-rating {
</del><ins>+.theme-details .star-holder {
</ins><span class="cx">         float: left;
</span><del>-        background: url('../images/stars-rtl.png?ver=20120307') repeat-x bottom right;
</del><span class="cx"> }
</span><span class="cx"> 
</span><del>-.theme-details .theme-rating div {
-        background: url('../images/stars-rtl.png?ver=20120307') repeat-x top right;
-        float: right;
-}
-
</del><span class="cx"> .feature-filter .feature-group {
</span><span class="cx">         float: right;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkwpadmincsswpadmindevcss"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/css/wp-admin.dev.css (20764 => 20765)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/css/wp-admin.dev.css        2012-05-10 19:58:25 UTC (rev 20764)
+++ trunk/wp-admin/css/wp-admin.dev.css        2012-05-10 19:59:48 UTC (rev 20765)
</span><span class="lines">@@ -5509,20 +5509,11 @@
</span><span class="cx">         float: left;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-.theme-details .theme-rating {
</del><ins>+.theme-details .star-holder {
</ins><span class="cx">         margin: 14px 0;
</span><del>-        width: 100px;
-        height: 17px;
</del><span class="cx">         float: right;
</span><del>-        background: url('../images/stars.png?ver=20120307') repeat-x bottom left;
</del><span class="cx"> }
</span><span class="cx"> 
</span><del>-.theme-details .theme-rating div {
-        background: url('../images/stars.png?ver=20120307') repeat-x top left;
-        height: 17px;
-        float: left;
-}
-
</del><span class="cx"> .theme-details .theme-description {
</span><span class="cx">         float: left;
</span><span class="cx">         color: #777;
</span><span class="lines">@@ -7129,7 +7120,7 @@
</span><span class="cx">         display: block;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-/* plugin-install */
</del><ins>+/* Star ratings */
</ins><span class="cx"> div.star-holder {
</span><span class="cx">         position: relative;
</span><span class="cx">         height: 17px;
</span></span></pre></div>
<a id="trunkwpadminincludesclasswpthemeinstalllisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/class-wp-theme-install-list-table.php (20764 => 20765)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/class-wp-theme-install-list-table.php        2012-05-10 19:58:25 UTC (rev 20764)
+++ trunk/wp-admin/includes/class-wp-theme-install-list-table.php        2012-05-10 19:59:48 UTC (rev 20765)
</span><span class="lines">@@ -338,8 +338,8 @@
</span><span class="cx">                                 &lt;img class=&quot;theme-screenshot&quot; src=&quot;&lt;?php echo esc_url( $theme-&gt;screenshot_url ); ?&gt;&quot; /&gt;
</span><span class="cx">                         &lt;?php endif; ?&gt;
</span><span class="cx">                         &lt;div class=&quot;theme-details&quot;&gt;
</span><del>-                                &lt;div class=&quot;theme-rating&quot; title=&quot;&lt;?php echo esc_attr( $num_ratings ); ?&gt;&quot;&gt;
-                                        &lt;div style=&quot;width:&lt;?php echo esc_attr( intval( $theme-&gt;rating ) . 'px' ); ?&gt;;&quot;&gt;&lt;/div&gt;
</del><ins>+                                &lt;div class=&quot;star-holder&quot; title=&quot;&lt;?php echo esc_attr( $num_ratings ); ?&gt;&quot;&gt;
+                                        &lt;div class=&quot;star-rating&quot; style=&quot;width:&lt;?php echo esc_attr( intval( $theme-&gt;rating ) . 'px' ); ?&gt;;&quot;&gt;&lt;/div&gt;
</ins><span class="cx">                                 &lt;/div&gt;
</span><span class="cx">                                 &lt;div class=&quot;theme-version&quot;&gt;
</span><span class="cx">                                         &lt;strong&gt;&lt;?php _e('Version:') ?&gt; &lt;/strong&gt;
</span></span></pre>
</div>
</div>

</body>
</html>