<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[20754] trunk/wp-admin: Update plugin install screens to use the new stars.</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/20754">20754</a></dd>
<dt>Author</dt> <dd>ryan</dd>
<dt>Date</dt> <dd>2012-05-09 16:27:24 +0000 (Wed, 09 May 2012)</dd>
</dl>

<h3>Log Message</h3>
<pre>Update plugin install screens to use the new stars. Add stars-rtl.png. Remove star.png and gray-star.png and add to old files list.

Props helenyhou
Fixes <a href="http://core.trac.wordpress.org/ticket/20626">#20626</a></pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadmincsscolorsclassicdevcss">trunk/wp-admin/css/colors-classic.dev.css</a></li>
<li><a href="#trunkwpadmincsscolorsfreshdevcss">trunk/wp-admin/css/colors-fresh.dev.css</a></li>
<li><a href="#trunkwpadmincsswpadminrtldevcss">trunk/wp-admin/css/wp-admin-rtl.dev.css</a></li>
<li><a href="#trunkwpadmincsswpadmindevcss">trunk/wp-admin/css/wp-admin.dev.css</a></li>
<li><a href="#trunkwpadminincludesclasswpplugininstalllisttablephp">trunk/wp-admin/includes/class-wp-plugin-install-list-table.php</a></li>
<li><a href="#trunkwpadminincludesplugininstallphp">trunk/wp-admin/includes/plugin-install.php</a></li>
<li><a href="#trunkwpadminincludesupdatecorephp">trunk/wp-admin/includes/update-core.php</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#trunkwpadminimagesstarsrtlpng">trunk/wp-admin/images/stars-rtl.png</a></li>
</ul>

<h3>Removed Paths</h3>
<ul>
<li><a href="#trunkwpadminimagesgraystarpng">trunk/wp-admin/images/gray-star.png</a></li>
<li><a href="#trunkwpadminimagesstarpng">trunk/wp-admin/images/star.png</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadmincsscolorsclassicdevcss"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/css/colors-classic.dev.css (20753 => 20754)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/css/colors-classic.dev.css        2012-05-09 16:16:03 UTC (rev 20753)
+++ trunk/wp-admin/css/colors-classic.dev.css        2012-05-09 16:27:24 UTC (rev 20754)
</span><span class="lines">@@ -1926,20 +1926,6 @@
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> /* Install Plugins */
</span><del>-.star-average,
-.star.star-rating {
-        background-color: #fc0;
-}
-
-div.star.select:hover {
-        background-color: #d00;
-}
-
-div.star img {
-        border-left: 1px solid #fff;
-        border-right: 1px solid #fff;
-}
-
</del><span class="cx"> #plugin-information .fyi ul {
</span><span class="cx">         background-color: #eaf3fa;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkwpadmincsscolorsfreshdevcss"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/css/colors-fresh.dev.css (20753 => 20754)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/css/colors-fresh.dev.css        2012-05-09 16:16:03 UTC (rev 20753)
+++ trunk/wp-admin/css/colors-fresh.dev.css        2012-05-09 16:27:24 UTC (rev 20754)
</span><span class="lines">@@ -1542,25 +1542,6 @@
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> /* Install Plugins */
</span><del>-.star-average,
-.star.star-rating {
-        background-color: #fc0;
-}
-
-div.star.select:hover {
-        background-color: #d00;
-}
-
-div.star img {
-        border-left: 1px solid #fff;
-        border-right: 1px solid #fff;
-}
-
-.widefat div.star img {
-        border-left: 1px solid #f9f9f9;
-        border-right: 1px solid #f9f9f9;
-}
-
</del><span class="cx"> #plugin-information .fyi ul {
</span><span class="cx">         background-color: #eaf3fa;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkwpadmincsswpadminrtldevcss"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/css/wp-admin-rtl.dev.css (20753 => 20754)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/css/wp-admin-rtl.dev.css        2012-05-09 16:16:03 UTC (rev 20753)
+++ trunk/wp-admin/css/wp-admin-rtl.dev.css        2012-05-09 16:27:24 UTC (rev 20754)
</span><span class="lines">@@ -2287,17 +2287,13 @@
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> /* plugin-install */
</span><del>-div.star {
-        left: auto;
-        right: 0;
-        letter-spacing: 0;
</del><ins>+div.star-holder {
+        background: url('../images/stars-rtl.png?ver=20120506.png') repeat-x bottom right;
</ins><span class="cx"> }
</span><del>-
-.star img, div.star a, div.star a:hover, div.star a:visited {
-        right: auto;
-        left: 0;
</del><ins>+div.star-holder .star-rating {
+        background: url('../images/stars-rtl.png?ver=20120506.png') repeat-x top right;
+        float: right;
</ins><span class="cx"> }
</span><del>-
</del><span class="cx"> #plugin-information ul#sidemenu {
</span><span class="cx">         left: auto;
</span><span class="cx">         right: 0;
</span></span></pre></div>
<a id="trunkwpadmincsswpadmindevcss"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/css/wp-admin.dev.css (20753 => 20754)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/css/wp-admin.dev.css        2012-05-09 16:16:03 UTC (rev 20753)
+++ trunk/wp-admin/css/wp-admin.dev.css        2012-05-09 16:27:24 UTC (rev 20754)
</span><span class="lines">@@ -7135,51 +7135,24 @@
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> /* plugin-install */
</span><del>-/* NOTE: the following CSS rules(.star*) are taken more or less straight from the bbPress rating plugin. */
</del><span class="cx"> div.star-holder {
</span><span class="cx">         position: relative;
</span><del>-        height: 19px;
</del><ins>+        height: 17px;
</ins><span class="cx">         width: 100px;
</span><del>-        font-size: 19px;
</del><ins>+        background: url('../images/stars.png?ver=20120307') repeat-x bottom left;
</ins><span class="cx"> }
</span><span class="cx"> 
</span><ins>+div.star-holder .star-rating {
+        background: url('../images/stars.png?ver=20120307') repeat-x top left;
+        height: 17px;
+        float: left;
+}
+
</ins><span class="cx"> div.action-links {
</span><span class="cx">         font-weight: normal;
</span><span class="cx">         margin: 6px 0 0;
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-div.star {
-        height: 100%;
-        position: absolute;
-        top: 0;
-        left: 0;
-        background-color: transparent;
-        letter-spacing: 1ex;
-        border: none;
-}
-
-.star1 { width: 20%; }
-.star2 { width: 40%; }
-.star3 { width: 60%; }
-.star4 { width: 80%; }
-.star5 { width: 100%; }
-
-.star img,
-div.star a,
-div.star a:hover,
-div.star a:visited {
-        display: block;
-        position: absolute;
-        right: 0;
-        border: none;
-        text-decoration: none;
-}
-
-div.star img {
-        width: 19px;
-        height: 19px;
-}
-
</del><span class="cx"> /* Header on thickbox */
</span><span class="cx"> #plugin-information-header {
</span><span class="cx">         margin: 0;
</span></span></pre></div>
<a id="trunkwpadminimagesgraystarpng"></a>
<div class="binary"><h4>Deleted: trunk/wp-admin/images/gray-star.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<a id="trunkwpadminimagesstarpng"></a>
<div class="binary"><h4>Deleted: trunk/wp-admin/images/star.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<a id="trunkwpadminimagesstarsrtlpng"></a>
<div class="binary"><h4>Added: trunk/wp-admin/images/stars-rtl.png</h4>
<pre class="diff"><span>
<span class="cx">(Binary files differ)
</span></span></pre></div>
<span class="cx">Property changes on: trunk/wp-admin/images/stars-rtl.png
</span><span class="cx">___________________________________________________________________
</span><a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<a id="trunkwpadminincludesclasswpplugininstalllisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/class-wp-plugin-install-list-table.php (20753 => 20754)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/class-wp-plugin-install-list-table.php        2012-05-09 16:16:03 UTC (rev 20753)
+++ trunk/wp-admin/includes/class-wp-plugin-install-list-table.php        2012-05-09 16:27:24 UTC (rev 20754)
</span><span class="lines">@@ -218,18 +218,6 @@
</span><span class="cx">                         &lt;td class=&quot;vers column-rating&quot;&lt;?php echo $style['rating']; ?&gt;&gt;
</span><span class="cx">                                 &lt;div class=&quot;star-holder&quot; title=&quot;&lt;?php printf( _n( '(based on %s rating)', '(based on %s ratings)', $plugin['num_ratings'] ), number_format_i18n( $plugin['num_ratings'] ) ) ?&gt;&quot;&gt;
</span><span class="cx">                                         &lt;div class=&quot;star star-rating&quot; style=&quot;width: &lt;?php echo esc_attr( str_replace( ',', '.', $plugin['rating'] ) ); ?&gt;px&quot;&gt;&lt;/div&gt;
</span><del>-                                        &lt;?php
-                                                $color = get_user_option('admin_color');
-                                                if ( empty($color) || 'fresh' == $color )
-                                                        $star_url = admin_url( 'images/gray-star.png?v=20110615' ); // 'Fresh' Gray star for list tables
-                                                else
-                                                        $star_url = admin_url( 'images/star.png?v=20110615' ); // 'Classic' Blue star
-                                        ?&gt;
-                                        &lt;div class=&quot;star star5&quot;&gt;&lt;img src=&quot;&lt;?php echo $star_url; ?&gt;&quot; alt=&quot;&lt;?php esc_attr_e( '5 stars' ) ?&gt;&quot; /&gt;&lt;/div&gt;
-                                        &lt;div class=&quot;star star4&quot;&gt;&lt;img src=&quot;&lt;?php echo $star_url; ?&gt;&quot; alt=&quot;&lt;?php esc_attr_e( '4 stars' ) ?&gt;&quot; /&gt;&lt;/div&gt;
-                                        &lt;div class=&quot;star star3&quot;&gt;&lt;img src=&quot;&lt;?php echo $star_url; ?&gt;&quot; alt=&quot;&lt;?php esc_attr_e( '3 stars' ) ?&gt;&quot; /&gt;&lt;/div&gt;
-                                        &lt;div class=&quot;star star2&quot;&gt;&lt;img src=&quot;&lt;?php echo $star_url; ?&gt;&quot; alt=&quot;&lt;?php esc_attr_e( '2 stars' ) ?&gt;&quot; /&gt;&lt;/div&gt;
-                                        &lt;div class=&quot;star star1&quot;&gt;&lt;img src=&quot;&lt;?php echo $star_url; ?&gt;&quot; alt=&quot;&lt;?php esc_attr_e( '1 star' ) ?&gt;&quot; /&gt;&lt;/div&gt;
</del><span class="cx">                                 &lt;/div&gt;
</span><span class="cx">                         &lt;/td&gt;
</span><span class="cx">                         &lt;td class=&quot;desc column-description&quot;&lt;?php echo $style['description']; ?&gt;&gt;&lt;?php echo $description, $author; ?&gt;&lt;/td&gt;
</span></span></pre></div>
<a id="trunkwpadminincludesplugininstallphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/plugin-install.php (20753 => 20754)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/plugin-install.php        2012-05-09 16:16:03 UTC (rev 20753)
+++ trunk/wp-admin/includes/plugin-install.php        2012-05-09 16:27:24 UTC (rev 20754)
</span><span class="lines">@@ -343,11 +343,6 @@
</span><span class="cx">                 &lt;h2&gt;&lt;?php _e('Average Rating') ?&gt;&lt;/h2&gt;
</span><span class="cx">                 &lt;div class=&quot;star-holder&quot; title=&quot;&lt;?php printf(_n('(based on %s rating)', '(based on %s ratings)', $api-&gt;num_ratings), number_format_i18n($api-&gt;num_ratings)); ?&gt;&quot;&gt;
</span><span class="cx">                         &lt;div class=&quot;star star-rating&quot; style=&quot;width: &lt;?php echo esc_attr( str_replace( ',', '.', $api-&gt;rating ) ); ?&gt;px&quot;&gt;&lt;/div&gt;
</span><del>-                        &lt;div class=&quot;star star5&quot;&gt;&lt;img src=&quot;&lt;?php echo admin_url('images/star.png?v=20110615'); ?&gt;&quot; alt=&quot;&lt;?php esc_attr_e('5 stars') ?&gt;&quot; /&gt;&lt;/div&gt;
-                        &lt;div class=&quot;star star4&quot;&gt;&lt;img src=&quot;&lt;?php echo admin_url('images/star.png?v=20110615'); ?&gt;&quot; alt=&quot;&lt;?php esc_attr_e('4 stars') ?&gt;&quot; /&gt;&lt;/div&gt;
-                        &lt;div class=&quot;star star3&quot;&gt;&lt;img src=&quot;&lt;?php echo admin_url('images/star.png?v=20110615'); ?&gt;&quot; alt=&quot;&lt;?php esc_attr_e('3 stars') ?&gt;&quot; /&gt;&lt;/div&gt;
-                        &lt;div class=&quot;star star2&quot;&gt;&lt;img src=&quot;&lt;?php echo admin_url('images/star.png?v=20110615'); ?&gt;&quot; alt=&quot;&lt;?php esc_attr_e('2 stars') ?&gt;&quot; /&gt;&lt;/div&gt;
-                        &lt;div class=&quot;star star1&quot;&gt;&lt;img src=&quot;&lt;?php echo admin_url('images/star.png?v=20110615'); ?&gt;&quot; alt=&quot;&lt;?php esc_attr_e('1 star') ?&gt;&quot; /&gt;&lt;/div&gt;
</del><span class="cx">                 &lt;/div&gt;
</span><span class="cx">                 &lt;small&gt;&lt;?php printf(_n('(based on %s rating)', '(based on %s ratings)', $api-&gt;num_ratings), number_format_i18n($api-&gt;num_ratings)); ?&gt;&lt;/small&gt;
</span><span class="cx">                 &lt;?php endif; ?&gt;
</span></span></pre></div>
<a id="trunkwpadminincludesupdatecorephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/update-core.php (20753 => 20754)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/update-core.php        2012-05-09 16:16:03 UTC (rev 20753)
+++ trunk/wp-admin/includes/update-core.php        2012-05-09 16:27:24 UTC (rev 20754)
</span><span class="lines">@@ -359,7 +359,9 @@
</span><span class="cx"> 'wp-includes/js/tinymce/themes/advanced/skins/wp_theme/img/fade-butt.png',
</span><span class="cx"> 'wp-includes/js/tinymce/themes/advanced/skins/wp_theme/img/separator.gif',
</span><span class="cx"> // 3.4
</span><ins>+'wp-admin/images/gray-star.png',
</ins><span class="cx"> 'wp-admin/images/logo-login.png',
</span><ins>+'wp-admin/images/star.png',
</ins><span class="cx"> 'wp-admin/index-extra.php',
</span><span class="cx"> 'wp-admin/network/index-extra.php',
</span><span class="cx"> 'wp-admin/user/index-extra.php',
</span></span></pre>
</div>
</div>

</body>
</html>