<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[20656] trunk/wp-includes/category-template.php: Escape term links output in category-template.php functions.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/20656">20656</a></dd>
<dt>Author</dt> <dd>ryan</dd>
<dt>Date</dt> <dd>2012-04-30 21:36:43 +0000 (Mon, 30 Apr 2012)</dd>
</dl>
<h3>Log Message</h3>
<pre>Escape term links output in category-template.php functions. Props SergeyBiryukov, solarissmoke, alex-ye. fixes <a href="http://core.trac.wordpress.org/ticket/20106">#20106</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludescategorytemplatephp">trunk/wp-includes/category-template.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludescategorytemplatephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/category-template.php (20655 => 20656)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/category-template.php 2012-04-30 21:32:44 UTC (rev 20655)
+++ trunk/wp-includes/category-template.php 2012-04-30 21:36:43 UTC (rev 20656)
</span><span class="lines">@@ -56,7 +56,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if ( $link )
</span><del>- $chain .= '<a href="' . get_category_link( $parent->term_id ) . '" title="' . esc_attr( sprintf( __( "View all posts in %s" ), $parent->name ) ) . '">'.$name.'</a>' . $separator;
</del><ins>+ $chain .= '<a href="' . esc_url( get_category_link( $parent->term_id ) ) . '" title="' . esc_attr( sprintf( __( "View all posts in %s" ), $parent->name ) ) . '">'.$name.'</a>' . $separator;
</ins><span class="cx"> else
</span><span class="cx"> $chain .= $name.$separator;
</span><span class="cx"> return $chain;
</span><span class="lines">@@ -171,17 +171,17 @@
</span><span class="cx"> case 'multiple':
</span><span class="cx"> if ( $category->parent )
</span><span class="cx"> $thelist .= get_category_parents( $category->parent, true, $separator );
</span><del>- $thelist .= '<a href="' . get_category_link( $category->term_id ) . '" title="' . esc_attr( sprintf( __( "View all posts in %s" ), $category->name ) ) . '" ' . $rel . '>' . $category->name.'</a></li>';
</del><ins>+ $thelist .= '<a href="' . esc_url( get_category_link( $category->term_id ) ) . '" title="' . esc_attr( sprintf( __( "View all posts in %s" ), $category->name ) ) . '" ' . $rel . '>' . $category->name.'</a></li>';
</ins><span class="cx"> break;
</span><span class="cx"> case 'single':
</span><del>- $thelist .= '<a href="' . get_category_link( $category->term_id ) . '" title="' . esc_attr( sprintf( __( "View all posts in %s" ), $category->name ) ) . '" ' . $rel . '>';
</del><ins>+ $thelist .= '<a href="' . esc_url( get_category_link( $category->term_id ) ) . '" title="' . esc_attr( sprintf( __( "View all posts in %s" ), $category->name ) ) . '" ' . $rel . '>';
</ins><span class="cx"> if ( $category->parent )
</span><span class="cx"> $thelist .= get_category_parents( $category->parent, false, $separator );
</span><span class="cx"> $thelist .= $category->name.'</a></li>';
</span><span class="cx"> break;
</span><span class="cx"> case '':
</span><span class="cx"> default:
</span><del>- $thelist .= '<a href="' . get_category_link( $category->term_id ) . '" title="' . esc_attr( sprintf( __( "View all posts in %s" ), $category->name ) ) . '" ' . $rel . '>' . $category->name.'</a></li>';
</del><ins>+ $thelist .= '<a href="' . esc_url( get_category_link( $category->term_id ) ) . '" title="' . esc_attr( sprintf( __( "View all posts in %s" ), $category->name ) ) . '" ' . $rel . '>' . $category->name.'</a></li>';
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> $thelist .= '</ul>';
</span><span class="lines">@@ -194,17 +194,17 @@
</span><span class="cx"> case 'multiple':
</span><span class="cx"> if ( $category->parent )
</span><span class="cx"> $thelist .= get_category_parents( $category->parent, true, $separator );
</span><del>- $thelist .= '<a href="' . get_category_link( $category->term_id ) . '" title="' . esc_attr( sprintf( __( "View all posts in %s" ), $category->name ) ) . '" ' . $rel . '>' . $category->name.'</a>';
</del><ins>+ $thelist .= '<a href="' . esc_url( get_category_link( $category->term_id ) ) . '" title="' . esc_attr( sprintf( __( "View all posts in %s" ), $category->name ) ) . '" ' . $rel . '>' . $category->name.'</a>';
</ins><span class="cx"> break;
</span><span class="cx"> case 'single':
</span><del>- $thelist .= '<a href="' . get_category_link( $category->term_id ) . '" title="' . esc_attr( sprintf( __( "View all posts in %s" ), $category->name ) ) . '" ' . $rel . '>';
</del><ins>+ $thelist .= '<a href="' . esc_url( get_category_link( $category->term_id ) ) . '" title="' . esc_attr( sprintf( __( "View all posts in %s" ), $category->name ) ) . '" ' . $rel . '>';
</ins><span class="cx"> if ( $category->parent )
</span><span class="cx"> $thelist .= get_category_parents( $category->parent, false, $separator );
</span><span class="cx"> $thelist .= "$category->name</a>";
</span><span class="cx"> break;
</span><span class="cx"> case '':
</span><span class="cx"> default:
</span><del>- $thelist .= '<a href="' . get_category_link( $category->term_id ) . '" title="' . esc_attr( sprintf( __( "View all posts in %s" ), $category->name ) ) . '" ' . $rel . '>' . $category->name.'</a>';
</del><ins>+ $thelist .= '<a href="' . esc_url( get_category_link( $category->term_id ) ) . '" title="' . esc_attr( sprintf( __( "View all posts in %s" ), $category->name ) ) . '" ' . $rel . '>' . $category->name.'</a>';
</ins><span class="cx"> }
</span><span class="cx"> ++$i;
</span><span class="cx"> }
</span><span class="lines">@@ -825,7 +825,7 @@
</span><span class="cx">
</span><span class="cx"> $cat_name = esc_attr( $category->name );
</span><span class="cx"> $cat_name = apply_filters( 'list_cats', $cat_name, $category );
</span><del>- $link = '<a href="' . esc_attr( get_term_link($category) ) . '" ';
</del><ins>+ $link = '<a href="' . esc_url( get_term_link($category) ) . '" ';
</ins><span class="cx"> if ( $use_desc_for_title == 0 || empty($category->description) )
</span><span class="cx"> $link .= 'title="' . esc_attr( sprintf(__( 'View all posts filed under %s' ), $cat_name) ) . '"';
</span><span class="cx"> else
</span><span class="lines">@@ -839,7 +839,7 @@
</span><span class="cx"> if ( empty($feed_image) )
</span><span class="cx"> $link .= '(';
</span><span class="cx">
</span><del>- $link .= '<a href="' . get_term_feed_link( $category->term_id, $category->taxonomy, $feed_type ) . '"';
</del><ins>+ $link .= '<a href="' . esc_url( get_term_feed_link( $category->term_id, $category->taxonomy, $feed_type ) ) . '"';
</ins><span class="cx">
</span><span class="cx"> if ( empty($feed) ) {
</span><span class="cx"> $alt = ' alt="' . sprintf(__( 'Feed for all posts filed under %s' ), $cat_name ) . '"';
</span><span class="lines">@@ -1109,7 +1109,7 @@
</span><span class="cx"> $link = get_term_link( $term, $taxonomy );
</span><span class="cx"> if ( is_wp_error( $link ) )
</span><span class="cx"> return $link;
</span><del>- $term_links[] = '<a href="' . $link . '" rel="tag">' . $term->name . '</a>';
</del><ins>+ $term_links[] = '<a href="' . esc_url( $link ) . '" rel="tag">' . $term->name . '</a>';
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> $term_links = apply_filters( "term_links-$taxonomy", $term_links );
</span></span></pre>
</div>
</div>
</body>
</html>