<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[20637] trunk/wp-includes/class-wp-xmlrpc-server.php: Check for the existence of a post before calling current_user_can() with a meta cap on that object.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/20637">20637</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2012-04-30 00:19:32 +0000 (Mon, 30 Apr 2012)</dd>
</dl>
<h3>Log Message</h3>
<pre>Check for the existence of a post before calling current_user_can() with a meta cap on that object. fixes <a href="http://core.trac.wordpress.org/ticket/20336">#20336</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludesclasswpxmlrpcserverphp">trunk/wp-includes/class-wp-xmlrpc-server.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludesclasswpxmlrpcserverphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/class-wp-xmlrpc-server.php (20636 => 20637)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/class-wp-xmlrpc-server.php 2012-04-28 21:25:25 UTC (rev 20636)
+++ trunk/wp-includes/class-wp-xmlrpc-server.php 2012-04-30 00:19:32 UTC (rev 20637)
</span><span class="lines">@@ -831,6 +831,8 @@
</span><span class="cx"> $update = ! empty( $post_data['ID'] );
</span><span class="cx">
</span><span class="cx"> if ( $update ) {
</span><ins>+ if ( ! get_post( $post_data['ID'] ) )
+ return new IXR_Error( 401, __( 'Invalid post ID.' ) );
</ins><span class="cx"> if ( ! current_user_can( $post_type->cap->edit_post, $post_data['ID'] ) )
</span><span class="cx"> return new IXR_Error( 401, __( 'Sorry, you are not allowed to edit this post.' ) );
</span><span class="cx"> if ( $post_data['post_type'] != get_post_type( $post_data['ID'] ) )
</span><span class="lines">@@ -1814,14 +1816,15 @@
</span><span class="cx"> return $this->error;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ $page = get_page($page_id);
+ if ( ! $page )
+ return new IXR_Error( 404, __( 'Invalid post ID.' ) );
+
</ins><span class="cx"> if ( !current_user_can( 'edit_page', $page_id ) )
</span><span class="cx"> return new IXR_Error( 401, __( 'Sorry, you cannot edit this page.' ) );
</span><span class="cx">
</span><span class="cx"> do_action('xmlrpc_call', 'wp.getPage');
</span><span class="cx">
</span><del>- // Lookup page info.
- $page = get_page($page_id);
-
</del><span class="cx"> // If we found the page then format the data.
</span><span class="cx"> if ( $page->ID && ($page->post_type == 'page') ) {
</span><span class="cx"> // Get all of the page content and link.
</span><span class="lines">@@ -3268,13 +3271,15 @@
</span><span class="cx"> if ( !$user = $this->login($username, $password) )
</span><span class="cx"> return $this->error;
</span><span class="cx">
</span><ins>+ $post_data = wp_get_single_post($post_ID, ARRAY_A);
+ if ( ! $post_data )
+ return new IXR_Error( 404, __( 'Invalid post ID.' ) );
+
</ins><span class="cx"> if ( !current_user_can( 'edit_post', $post_ID ) )
</span><span class="cx"> return new IXR_Error( 401, __( 'Sorry, you cannot edit this post.' ) );
</span><span class="cx">
</span><span class="cx"> do_action('xmlrpc_call', 'blogger.getPost');
</span><span class="cx">
</span><del>- $post_data = wp_get_single_post($post_ID, ARRAY_A);
-
</del><span class="cx"> $categories = implode(',', wp_get_post_categories($post_ID));
</span><span class="cx">
</span><span class="cx"> $content = '<title>'.stripslashes($post_data['post_title']).'</title>';
</span><span class="lines">@@ -4218,13 +4223,15 @@
</span><span class="cx"> if ( !$user = $this->login($username, $password) )
</span><span class="cx"> return $this->error;
</span><span class="cx">
</span><ins>+ $postdata = wp_get_single_post($post_ID, ARRAY_A);
+ if ( ! $postdata )
+ return new IXR_Error( 404, __( 'Invalid post ID.' ) );
+
</ins><span class="cx"> if ( !current_user_can( 'edit_post', $post_ID ) )
</span><span class="cx"> return new IXR_Error( 401, __( 'Sorry, you cannot edit this post.' ) );
</span><span class="cx">
</span><span class="cx"> do_action('xmlrpc_call', 'metaWeblog.getPost');
</span><span class="cx">
</span><del>- $postdata = wp_get_single_post($post_ID, ARRAY_A);
-
</del><span class="cx"> if ($postdata['post_date'] != '') {
</span><span class="cx"> $post_date = $this->_convert_date( $postdata['post_date'] );
</span><span class="cx"> $post_date_gmt = $this->_convert_date_gmt( $postdata['post_date_gmt'], $postdata['post_date'] );
</span><span class="lines">@@ -4686,6 +4693,9 @@
</span><span class="cx"> if ( !$user = $this->login($username, $password) )
</span><span class="cx"> return $this->error;
</span><span class="cx">
</span><ins>+ if ( ! get_post( $post_ID ) )
+ return new IXR_Error( 404, __( 'Invalid post ID.' ) );
+
</ins><span class="cx"> if ( !current_user_can( 'edit_post', $post_ID ) )
</span><span class="cx"> return new IXR_Error( 401, __( 'Sorry, you can not edit this post.' ) );
</span><span class="cx">
</span><span class="lines">@@ -4729,6 +4739,9 @@
</span><span class="cx">
</span><span class="cx"> do_action('xmlrpc_call', 'mt.setPostCategories');
</span><span class="cx">
</span><ins>+ if ( ! get_post( $post_ID ) )
+ return new IXR_Error( 404, __( 'Invalid post ID.' ) );
+
</ins><span class="cx"> if ( !current_user_can('edit_post', $post_ID) )
</span><span class="cx"> return new IXR_Error(401, __('Sorry, you cannot edit this post.'));
</span><span class="cx">
</span><span class="lines">@@ -4836,11 +4849,13 @@
</span><span class="cx">
</span><span class="cx"> do_action('xmlrpc_call', 'mt.publishPost');
</span><span class="cx">
</span><ins>+ $postdata = wp_get_single_post($post_ID, ARRAY_A);
+ if ( ! $postdata )
+ return new IXR_Error( 404, __( 'Invalid post ID.' ) );
+
</ins><span class="cx"> if ( !current_user_can('publish_posts') || !current_user_can('edit_post', $post_ID) )
</span><span class="cx"> return new IXR_Error(401, __('Sorry, you cannot publish this post.'));
</span><span class="cx">
</span><del>- $postdata = wp_get_single_post($post_ID,ARRAY_A);
-
</del><span class="cx"> $postdata['post_status'] = 'publish';
</span><span class="cx">
</span><span class="cx"> // retain old cats
</span></span></pre>
</div>
</div>
</body>
</html>