<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[20585] trunk/wp-includes: Theme Customizer: For clarity, wp.customize.Setting.method to wp.customize.Setting.transport.</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/20585">20585</a></dd>
<dt>Author</dt> <dd>koopersmith</dd>
<dt>Date</dt> <dd>2012-04-25 16:04:51 +0000 (Wed, 25 Apr 2012)</dd>
</dl>

<h3>Log Message</h3>
<pre>Theme Customizer: For clarity, wp.customize.Setting.method to wp.customize.Setting.transport. Add WP_Customize_Setting-&gt;transport to allow setting the transport method via PHP. see <a href="http://core.trac.wordpress.org/ticket/19910">#19910</a>.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludesclasswpcustomizesettingphp">trunk/wp-includes/class-wp-customize-setting.php</a></li>
<li><a href="#trunkwpincludesclasswpcustomizephp">trunk/wp-includes/class-wp-customize.php</a></li>
<li><a href="#trunkwpincludescustomizecontrolsphp">trunk/wp-includes/customize-controls.php</a></li>
<li><a href="#trunkwpincludesjscustomizecontrolsdevjs">trunk/wp-includes/js/customize-controls.dev.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludesclasswpcustomizesettingphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/class-wp-customize-setting.php (20584 => 20585)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/class-wp-customize-setting.php        2012-04-25 15:44:06 UTC (rev 20584)
+++ trunk/wp-includes/class-wp-customize-setting.php        2012-04-25 16:04:51 UTC (rev 20585)
</span><span class="lines">@@ -16,6 +16,7 @@
</span><span class="cx">         public $theme_supports    = '';
</span><span class="cx">         public $default           = '';
</span><span class="cx">         public $sanitize_callback = '';
</span><ins>+        public $transport         = 'refresh';
</ins><span class="cx"> 
</span><span class="cx">         protected $id_data = array();
</span><span class="cx">         private $_post_value; // Cached, sanitized $_POST value.
</span></span></pre></div>
<a id="trunkwpincludesclasswpcustomizephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/class-wp-customize.php (20584 => 20585)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/class-wp-customize.php        2012-04-25 15:44:06 UTC (rev 20584)
+++ trunk/wp-includes/class-wp-customize.php        2012-04-25 16:04:51 UTC (rev 20585)
</span><span class="lines">@@ -580,6 +580,7 @@
</span><span class="cx">                         'default'           =&gt; get_theme_support( 'custom-background', 'default-color' ),
</span><span class="cx">                         'sanitize_callback' =&gt; 'sanitize_hexcolor',
</span><span class="cx">                         'theme_supports'    =&gt; 'custom-background',
</span><ins>+                        'transport'         =&gt; 'postMessage',
</ins><span class="cx">                 ) );
</span><span class="cx"> 
</span><span class="cx">                 $this-&gt;add_control( 'background_color', array(
</span></span></pre></div>
<a id="trunkwpincludescustomizecontrolsphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/customize-controls.php (20584 => 20585)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/customize-controls.php        2012-04-25 15:44:06 UTC (rev 20584)
+++ trunk/wp-includes/customize-controls.php        2012-04-25 16:04:51 UTC (rev 20585)
</span><span class="lines">@@ -104,7 +104,8 @@
</span><span class="cx"> 
</span><span class="cx">         foreach ( $this-&gt;settings as $id =&gt; $setting ) {
</span><span class="cx">                 $settings['settings'][ $id ] = array(
</span><del>-                        'value'   =&gt; $setting-&gt;value(),
</del><ins>+                        'value'     =&gt; $setting-&gt;value(),
+                        'transport' =&gt; $setting-&gt;transport,
</ins><span class="cx">                 );
</span><span class="cx">         }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkwpincludesjscustomizecontrolsdevjs"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/js/customize-controls.dev.js (20584 => 20585)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/js/customize-controls.dev.js        2012-04-25 15:44:06 UTC (rev 20584)
+++ trunk/wp-includes/js/customize-controls.dev.js        2012-04-25 16:04:51 UTC (rev 20585)
</span><span class="lines">@@ -4,7 +4,7 @@
</span><span class="cx">         /*
</span><span class="cx">          * @param options
</span><span class="cx">          * - previewer - The Previewer instance to sync with.
</span><del>-         * - method    - The method to use for previewing. Supports 'refresh' and 'postMessage'.
</del><ins>+         * - transport - The transport to use for previewing. Supports 'refresh' and 'postMessage'.
</ins><span class="cx">          */
</span><span class="cx">         api.Setting = api.Value.extend({
</span><span class="cx">                 initialize: function( id, value, options ) {
</span><span class="lines">@@ -13,7 +13,7 @@
</span><span class="cx">                         api.Value.prototype.initialize.call( this, value, options );
</span><span class="cx"> 
</span><span class="cx">                         this.id = id;
</span><del>-                        this.method = this.method || 'refresh';
</del><ins>+                        this.transport = this.transport || 'refresh';
</ins><span class="cx"> 
</span><span class="cx">                         element = $( '&lt;input /&gt;', {
</span><span class="cx">                                 type:  'hidden',
</span><span class="lines">@@ -28,7 +28,7 @@
</span><span class="cx">                         this.bind( this.preview );
</span><span class="cx">                 },
</span><span class="cx">                 preview: function() {
</span><del>-                        switch ( this.method ) {
</del><ins>+                        switch ( this.transport ) {
</ins><span class="cx">                                 case 'refresh':
</span><span class="cx">                                         return this.previewer.refresh();
</span><span class="cx">                                 case 'postMessage':
</span><span class="lines">@@ -403,6 +403,7 @@
</span><span class="cx"> 
</span><span class="cx">                 $.each( api.settings.settings, function( id, data ) {
</span><span class="cx">                         api.set( id, id, data.value, {
</span><ins>+                                transport: data.transport,
</ins><span class="cx">                                 previewer: previewer
</span><span class="cx">                         } );
</span><span class="cx">                 });
</span><span class="lines">@@ -434,11 +435,6 @@
</span><span class="cx">                         event.preventDefault();
</span><span class="cx">                 });
</span><span class="cx"> 
</span><del>-                // Background color uses postMessage by default
-                api( 'background_color', function( setting ) {
-                        setting.method = 'postMessage';
-                });
-
</del><span class="cx">                 // Control visibility for default controls
</span><span class="cx">                 $.each({
</span><span class="cx">                         'background_image': {
</span></span></pre>
</div>
</div>

</body>
</html>