<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[20549] trunk/wp-includes/category-template.php: Add $id parameter to get_the_tag_list() for consistency with get_the_(category|term)_list().</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/20549">20549</a></dd>
<dt>Author</dt> <dd>duck_</dd>
<dt>Date</dt> <dd>2012-04-20 10:06:05 +0000 (Fri, 20 Apr 2012)</dd>
</dl>
<h3>Log Message</h3>
<pre>Add $id parameter to get_the_tag_list() for consistency with get_the_(category|term)_list(). Props kawauso. Fixes <a href="http://core.trac.wordpress.org/ticket/20072">#20072</a>.
Also remove 'default' value of 0 for $id parameter in generic taxonomy functions
as it is a required parameter, and fix a notice when get_the_terms() is called
when $id = 0 and the $post global is not an object.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludescategorytemplatephp">trunk/wp-includes/category-template.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludescategorytemplatephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/category-template.php (20548 => 20549)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/category-template.php 2012-04-20 04:58:21 UTC (rev 20548)
+++ trunk/wp-includes/category-template.php 2012-04-20 10:06:05 UTC (rev 20549)
</span><span class="lines">@@ -995,10 +995,11 @@
</span><span class="cx"> * @param string $before Optional. Before tags.
</span><span class="cx"> * @param string $sep Optional. Between tags.
</span><span class="cx"> * @param string $after Optional. After tags.
</span><ins>+ * @param int $id Optional. Post ID. Defaults to the current post.
</ins><span class="cx"> * @return string
</span><span class="cx"> */
</span><del>-function get_the_tag_list( $before = '', $sep = '', $after = '' ) {
- return apply_filters( 'the_tags', get_the_term_list( 0, 'post_tag', $before, $sep, $after ), $before, $sep, $after);
</del><ins>+function get_the_tag_list( $before = '', $sep = '', $after = '', $id = 0 ) {
+ return apply_filters( 'the_tags', get_the_term_list( $id, 'post_tag', $before, $sep, $after ), $before, $sep, $after, $id );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><span class="lines">@@ -1053,17 +1054,17 @@
</span><span class="cx"> *
</span><span class="cx"> * @since 2.5.0
</span><span class="cx"> *
</span><del>- * @param int $id Post ID. Is not optional.
</del><ins>+ * @param int $id Post ID.
</ins><span class="cx"> * @param string $taxonomy Taxonomy name.
</span><span class="cx"> * @return array|bool False on failure. Array of term objects on success.
</span><span class="cx"> */
</span><del>-function get_the_terms( $id = 0, $taxonomy ) {
</del><ins>+function get_the_terms( $id, $taxonomy ) {
</ins><span class="cx"> global $post;
</span><span class="cx">
</span><span class="cx"> $id = (int) $id;
</span><span class="cx">
</span><span class="cx"> if ( !$id ) {
</span><del>- if ( !$post->ID )
</del><ins>+ if ( empty( $post->ID ) )
</ins><span class="cx"> return false;
</span><span class="cx"> else
</span><span class="cx"> $id = (int) $post->ID;
</span><span class="lines">@@ -1095,7 +1096,7 @@
</span><span class="cx"> * @param string $after Optional. After list.
</span><span class="cx"> * @return string
</span><span class="cx"> */
</span><del>-function get_the_term_list( $id = 0, $taxonomy, $before = '', $sep = '', $after = '' ) {
</del><ins>+function get_the_term_list( $id, $taxonomy, $before = '', $sep = '', $after = '' ) {
</ins><span class="cx"> $terms = get_the_terms( $id, $taxonomy );
</span><span class="cx">
</span><span class="cx"> if ( is_wp_error( $terms ) )
</span><span class="lines">@@ -1128,7 +1129,7 @@
</span><span class="cx"> * @param string $after Optional. After list.
</span><span class="cx"> * @return null|bool False on WordPress error. Returns null when displaying.
</span><span class="cx"> */
</span><del>-function the_terms( $id = 0, $taxonomy, $before = '', $sep = ', ', $after = '' ) {
</del><ins>+function the_terms( $id, $taxonomy, $before = '', $sep = ', ', $after = '' ) {
</ins><span class="cx"> $term_list = get_the_term_list( $id, $taxonomy, $before, $sep, $after );
</span><span class="cx">
</span><span class="cx"> if ( is_wp_error( $term_list ) )
</span></span></pre>
</div>
</div>
</body>
</html>