<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[20428] trunk/wp-includes/js/wplink.dev.js: Fix inserting links in the HTML editor in IE9, fixes #19528</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/20428">20428</a></dd>
<dt>Author</dt> <dd>azaozz</dd>
<dt>Date</dt> <dd>2012-04-11 00:20:42 +0000 (Wed, 11 Apr 2012)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix inserting links in the HTML editor in IE9, fixes <a href="http://core.trac.wordpress.org/ticket/19528">#19528</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludesjswplinkdevjs">trunk/wp-includes/js/wplink.dev.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludesjswplinkdevjs"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/js/wplink.dev.js (20427 => 20428)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/js/wplink.dev.js 2012-04-10 21:58:27 UTC (rev 20427)
+++ trunk/wp-includes/js/wplink.dev.js 2012-04-11 00:20:42 UTC (rev 20428)
</span><span class="lines">@@ -160,7 +160,7 @@
</span><span class="cx"> },
</span><span class="cx">
</span><span class="cx"> htmlUpdate : function() {
</span><del>- var attrs, html, start, end, cursor,
</del><ins>+ var attrs, html, begin, end, cursor,
</ins><span class="cx"> textarea = wpLink.textarea;
</span><span class="cx">
</span><span class="cx"> if ( ! textarea )
</span><span class="lines">@@ -183,35 +183,34 @@
</span><span class="cx"> html += '>';
</span><span class="cx">
</span><span class="cx"> // Insert HTML
</span><del>- // W3C
- if ( typeof textarea.selectionStart !== 'undefined' ) {
- start = textarea.selectionStart;
</del><ins>+ if ( document.selection && wpLink.range ) {
+ // IE
+ // Note: If no text is selected, IE will not place the cursor
+ // inside the closing tag.
+ textarea.focus();
+ wpLink.range.text = html + wpLink.range.text + '</a>';
+ wpLink.range.moveToBookmark( wpLink.range.getBookmark() );
+ wpLink.range.select();
+
+ wpLink.range = null;
+ } else if ( typeof textarea.selectionStart !== 'undefined' ) {
+ // W3C
+ begin = textarea.selectionStart;
</ins><span class="cx"> end = textarea.selectionEnd;
</span><del>- selection = textarea.value.substring( start, end );
</del><ins>+ selection = textarea.value.substring( begin, end );
</ins><span class="cx"> html = html + selection + '</a>';
</span><del>- cursor = start + html.length;
</del><ins>+ cursor = begin + html.length;
</ins><span class="cx">
</span><span class="cx"> // If no next is selected, place the cursor inside the closing tag.
</span><del>- if ( start == end )
</del><ins>+ if ( begin == end )
</ins><span class="cx"> cursor -= '</a>'.length;
</span><span class="cx">
</span><del>- textarea.value = textarea.value.substring( 0, start )
</del><ins>+ textarea.value = textarea.value.substring( 0, begin )
</ins><span class="cx"> + html
</span><span class="cx"> + textarea.value.substring( end, textarea.value.length );
</span><span class="cx">
</span><span class="cx"> // Update cursor position
</span><span class="cx"> textarea.selectionStart = textarea.selectionEnd = cursor;
</span><del>-
- // IE
- // Note: If no text is selected, IE will not place the cursor
- // inside the closing tag.
- } else if ( document.selection && wpLink.range ) {
- textarea.focus();
- wpLink.range.text = html + wpLink.range.text + '</a>';
- wpLink.range.moveToBookmark( wpLink.range.getBookmark() );
- wpLink.range.select();
-
- wpLink.range = null;
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> wpLink.close();
</span></span></pre>
</div>
</div>
</body>
</html>