<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[20100] trunk/wp-admin/includes: Allow WP_List_Table::_js_vars() to take an array of additional args to add.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/20100">20100</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2012-03-02 23:06:31 +0000 (Fri, 02 Mar 2012)</dd>
</dl>
<h3>Log Message</h3>
<pre>Allow WP_List_Table::_js_vars() to take an array of additional args to add. Allows us to have a single variable printing data when child classes need more data. Also, fix compact() call in <a href="http://core.trac.wordpress.org/changeset/20094">[20094]</a>. see <a href="http://core.trac.wordpress.org/ticket/19815">#19815</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminincludesclasswplisttablephp">trunk/wp-admin/includes/class-wp-list-table.php</a></li>
<li><a href="#trunkwpadminincludesclasswpthemeinstalllisttablephp">trunk/wp-admin/includes/class-wp-theme-install-list-table.php</a></li>
<li><a href="#trunkwpadminincludesclasswpthemeslisttablephp">trunk/wp-admin/includes/class-wp-themes-list-table.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminincludesclasswplisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/class-wp-list-table.php (20099 => 20100)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/class-wp-list-table.php 2012-03-02 22:51:29 UTC (rev 20099)
+++ trunk/wp-admin/includes/class-wp-list-table.php 2012-03-02 23:06:31 UTC (rev 20100)
</span><span class="lines">@@ -903,7 +903,7 @@
</span><span class="cx"> *
</span><span class="cx"> * @access private
</span><span class="cx"> */
</span><del>- function _js_vars() {
</del><ins>+ function _js_vars( $extra_args = array() ) {
</ins><span class="cx"> $current_screen = get_current_screen();
</span><span class="cx">
</span><span class="cx"> $args = array(
</span><span class="lines">@@ -914,6 +914,9 @@
</span><span class="cx"> )
</span><span class="cx"> );
</span><span class="cx">
</span><ins>+ if ( is_array( $extra_args ) )
+ $args = array_merge( $args, $extra_args );
+
</ins><span class="cx"> printf( "<script type='text/javascript'>list_args = %s;</script>\n", json_encode( $args ) );
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkwpadminincludesclasswpthemeinstalllisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/class-wp-theme-install-list-table.php (20099 => 20100)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/class-wp-theme-install-list-table.php 2012-03-02 22:51:29 UTC (rev 20099)
+++ trunk/wp-admin/includes/class-wp-theme-install-list-table.php 2012-03-02 23:06:31 UTC (rev 20100)
</span><span class="lines">@@ -170,7 +170,7 @@
</span><span class="cx"> * @uses $type Global; type of search.
</span><span class="cx"> */
</span><span class="cx"> function _js_vars() {
</span><del>- global $tab, $type;
- parent::_js_vars( compact( $tab, $type ) );
</del><ins>+ global $tab, $type;
+ parent::_js_vars( compact( 'tab', 'type' ) );
</ins><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkwpadminincludesclasswpthemeslisttablephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/class-wp-themes-list-table.php (20099 => 20100)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/class-wp-themes-list-table.php 2012-03-02 22:51:29 UTC (rev 20099)
+++ trunk/wp-admin/includes/class-wp-themes-list-table.php 2012-03-02 23:06:31 UTC (rev 20100)
</span><span class="lines">@@ -217,21 +217,16 @@
</span><span class="cx"> function _js_vars( $extra_args = array() ) {
</span><span class="cx"> $search_string = isset( $_REQUEST['s'] ) ? esc_attr( stripslashes( $_REQUEST['s'] ) ) : '';
</span><span class="cx">
</span><del>- $total_pages = 1;
- if ( ! empty( $this->_pagination_args['total_pages'] ) )
- $total_pages = $this->_pagination_args['total_pages'];
-
</del><span class="cx"> $args = array(
</span><span class="cx"> 'search' => $search_string,
</span><span class="cx"> 'features' => $this->features,
</span><span class="cx"> 'paged' => $this->get_pagenum(),
</span><del>- 'total_pages' => $total_pages,
</del><ins>+ 'total_pages' => ! empty( $this->_pagination_args['total_pages'] ) ? $this->_pagination_args['total_pages'] : 1,
</ins><span class="cx"> );
</span><span class="cx">
</span><span class="cx"> if ( is_array( $extra_args ) )
</span><del>- $args = array_merge( $args, $extra_args );
</del><ins>+ $args = array_merge( $args, $extra_args );
</ins><span class="cx">
</span><del>- printf( "<script type='text/javascript'>var theme_list_args = %s;</script>\n", json_encode( $args ) );
- parent::_js_vars();
</del><ins>+ parent::_js_vars( $args );
</ins><span class="cx"> }
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>