<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[20080] trunk: Don't autoload the uninstall_plugins option.</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/20080">20080</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2012-03-02 20:13:35 +0000 (Fri, 02 Mar 2012)</dd>
</dl>

<h3>Log Message</h3>
<pre>Don't autoload the uninstall_plugins option. fixes <a href="http://core.trac.wordpress.org/ticket/16741">#16741</a>.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminincludesschemaphp">trunk/wp-admin/includes/schema.php</a></li>
<li><a href="#trunkwpadminincludesupgradephp">trunk/wp-admin/includes/upgrade.php</a></li>
<li><a href="#trunkwpincludesversionphp">trunk/wp-includes/version.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminincludesschemaphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/schema.php (20079 => 20080)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/schema.php        2012-03-02 20:00:21 UTC (rev 20079)
+++ trunk/wp-admin/includes/schema.php        2012-03-02 20:13:35 UTC (rev 20080)
</span><span class="lines">@@ -470,6 +470,7 @@
</span><span class="cx">         'widget_categories' =&gt; array(),
</span><span class="cx">         'widget_text' =&gt; array(),
</span><span class="cx">         'widget_rss' =&gt; array(),
</span><ins>+        'uninstall_plugins' =&gt; array(),
</ins><span class="cx"> 
</span><span class="cx">         // 2.8
</span><span class="cx">         'timezone_string' =&gt; $timezone_string,
</span><span class="lines">@@ -501,7 +502,7 @@
</span><span class="cx">         }
</span><span class="cx"> 
</span><span class="cx">         // Set autoload to no for these options
</span><del>-        $fat_options = array( 'moderation_keys', 'recently_edited', 'blacklist_keys' );
</del><ins>+        $fat_options = array( 'moderation_keys', 'recently_edited', 'blacklist_keys', 'uninstall_plugins' );
</ins><span class="cx"> 
</span><span class="cx">         $existing_options = $wpdb-&gt;get_col(&quot;SELECT option_name FROM $wpdb-&gt;options&quot;);
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkwpadminincludesupgradephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/upgrade.php (20079 => 20080)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/upgrade.php        2012-03-02 20:00:21 UTC (rev 20079)
+++ trunk/wp-admin/includes/upgrade.php        2012-03-02 20:13:35 UTC (rev 20080)
</span><span class="lines">@@ -457,7 +457,7 @@
</span><span class="cx">         if ( $wp_current_db_version &lt; 19389 )
</span><span class="cx">                 upgrade_330();
</span><span class="cx"> 
</span><del>-        if ( $wp_current_db_version &lt; 20022 )
</del><ins>+        if ( $wp_current_db_version &lt; 20080 )
</ins><span class="cx">                 upgrade_340();
</span><span class="cx"> 
</span><span class="cx">         maybe_disable_automattic_widgets();
</span><span class="lines">@@ -1152,11 +1152,6 @@
</span><span class="cx">                 $wpdb-&gt;query( &quot;DELETE FROM $wpdb-&gt;usermeta WHERE meta_key IN ('show_admin_bar_admin', 'plugins_last_view')&quot; );
</span><span class="cx">         }
</span><span class="cx"> 
</span><del>-        // 3.3-beta. Can remove before release.
-        if ( $wp_current_db_version &gt; 18715 &amp;&amp; $wp_current_db_version &lt; 19389
-                &amp;&amp; is_main_site() &amp;&amp; ! defined( 'DO_NOT_UPGRADE_GLOBAL_TABLES' ) )
-                        delete_metadata( 'user', 0, 'dismissed_wp_pointers', '', true );
-
</del><span class="cx">         if ( $wp_current_db_version &gt;= 11548 )
</span><span class="cx">                 return;
</span><span class="cx"> 
</span><span class="lines">@@ -1237,6 +1232,14 @@
</span><span class="cx">         if ( $wp_current_db_version &lt; 20022 &amp;&amp; is_main_site() &amp;&amp; ! defined( 'DO_NOT_UPGRADE_GLOBAL_TABLES' ) ) {
</span><span class="cx">                 $wpdb-&gt;query( &quot;DELETE FROM $wpdb-&gt;usermeta WHERE meta_key = 'themes_last_view'&quot; );
</span><span class="cx">         }
</span><ins>+
+        if ( $wp_current_db_version &lt; 20080 ) {
+                if ( 'yes' == $wpdb-&gt;get_var( &quot;SELECT autoload FROM $wpdb-&gt;options WHERE option_name = 'uninstall_plugins'&quot; ) ) {
+                        $uninstall_plugins = get_option( 'uninstall_plugins' );
+                        delete_option( 'uninstall_plugins' );
+                        add_option( 'uninstall_plugins', $uninstall_plugins, null, 'no' );
+                }
+        }
</ins><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> /**
</span></span></pre></div>
<a id="trunkwpincludesversionphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/version.php (20079 => 20080)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/version.php        2012-03-02 20:00:21 UTC (rev 20079)
+++ trunk/wp-includes/version.php        2012-03-02 20:13:35 UTC (rev 20080)
</span><span class="lines">@@ -11,7 +11,7 @@
</span><span class="cx">  *
</span><span class="cx">  * @global int $wp_db_version
</span><span class="cx">  */
</span><del>-$wp_db_version = 20022;
</del><ins>+$wp_db_version = 20080;
</ins><span class="cx"> 
</span><span class="cx"> /**
</span><span class="cx">  * Holds the TinyMCE version
</span></span></pre>
</div>
</div>

</body>
</html>