<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[19734] trunk/wp-includes/post.php: Update hierarchy for all hierarchical post types when deleting a parent post, not just for pages.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/19734">19734</a></dd>
<dt>Author</dt> <dd>duck_</dd>
<dt>Date</dt> <dd>2012-01-13 18:37:46 +0000 (Fri, 13 Jan 2012)</dd>
</dl>
<h3>Log Message</h3>
<pre>Update hierarchy for all hierarchical post types when deleting a parent post, not just for pages. Fixes <a href="http://core.trac.wordpress.org/ticket/19637">#19637</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludespostphp">trunk/wp-includes/post.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludespostphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/post.php (19733 => 19734)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/post.php 2012-01-13 18:15:55 UTC (rev 19733)
+++ trunk/wp-includes/post.php 2012-01-13 18:37:46 UTC (rev 19734)
</span><span class="lines">@@ -1984,6 +1984,14 @@
</span><span class="cx"> $parent_data = array( 'post_parent' => $post->post_parent );
</span><span class="cx"> $parent_where = array( 'post_parent' => $postid );
</span><span class="cx">
</span><ins>+ if ( is_post_type_hierarchical( $post->post_type ) ) {
+ // Point children of this page to its parent, also clean the cache of affected children
+ $children_query = $wpdb->prepare( "SELECT * FROM $wpdb->posts WHERE post_parent = %d AND post_type = %s", $postid, $post->post_type );
+ $children = $wpdb->get_results( $children_query );
+
+ $wpdb->update( $wpdb->posts, $parent_data, $parent_where + array( 'post_type' => $post->post_type ) );
+ }
+
</ins><span class="cx"> if ( 'page' == $post->post_type) {
</span><span class="cx"> // if the page is defined in option page_on_front or post_for_posts,
</span><span class="cx"> // adjust the corresponding options
</span><span class="lines">@@ -1994,12 +2002,6 @@
</span><span class="cx"> if ( get_option('page_for_posts') == $postid ) {
</span><span class="cx"> delete_option('page_for_posts');
</span><span class="cx"> }
</span><del>-
- // Point children of this page to its parent, also clean the cache of affected children
- $children_query = $wpdb->prepare("SELECT * FROM $wpdb->posts WHERE post_parent = %d AND post_type='page'", $postid);
- $children = $wpdb->get_results($children_query);
-
- $wpdb->update( $wpdb->posts, $parent_data, $parent_where + array( 'post_type' => 'page' ) );
</del><span class="cx"> } else {
</span><span class="cx"> unstick_post($postid);
</span><span class="cx"> }
</span><span class="lines">@@ -2035,13 +2037,15 @@
</span><span class="cx">
</span><span class="cx"> if ( 'page' == $post->post_type ) {
</span><span class="cx"> clean_page_cache($postid);
</span><del>-
- foreach ( (array) $children as $child )
- clean_page_cache($child->ID);
</del><span class="cx"> } else {
</span><span class="cx"> clean_post_cache($postid);
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ if ( is_post_type_hierarchical( $post->post_type ) ) {
+ foreach ( (array) $children as $child )
+ clean_post_cache( $child->ID );
+ }
+
</ins><span class="cx"> wp_clear_scheduled_hook('publish_future_post', array( $postid ) );
</span><span class="cx">
</span><span class="cx"> do_action('after_delete_post', $postid);
</span></span></pre>
</div>
</div>
</body>
</html>