<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[19708] trunk/wp-admin/includes/plugin-install.php: s/Faq/FAQ/ for Plugin Installer tabs, Gains Translation support for Tabs/Titles as well.</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/19708">19708</a></dd>
<dt>Author</dt> <dd>dd32</dd>
<dt>Date</dt> <dd>2012-01-08 05:39:49 +0000 (Sun, 08 Jan 2012)</dd>
</dl>

<h3>Log Message</h3>
<pre>s/Faq/FAQ/ for Plugin Installer tabs, Gains Translation support for Tabs/Titles as well. Fixes <a href="http://core.trac.wordpress.org/ticket/16580">#16580</a></pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminincludesplugininstallphp">trunk/wp-admin/includes/plugin-install.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminincludesplugininstallphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/plugin-install.php (19707 => 19708)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/plugin-install.php        2012-01-08 03:48:05 UTC (rev 19707)
+++ trunk/wp-admin/includes/plugin-install.php        2012-01-08 05:39:49 UTC (rev 19708)
</span><span class="lines">@@ -250,6 +250,17 @@
</span><span class="cx">                                                                 'div' =&gt; array(), 'p' =&gt; array(), 'ul' =&gt; array(), 'ol' =&gt; array(), 'li' =&gt; array(),
</span><span class="cx">                                                                 'h1' =&gt; array(), 'h2' =&gt; array(), 'h3' =&gt; array(), 'h4' =&gt; array(), 'h5' =&gt; array(), 'h6' =&gt; array(),
</span><span class="cx">                                                                 'img' =&gt; array('src' =&gt; array(), 'class' =&gt; array(), 'alt' =&gt; array()));
</span><ins>+
+        $plugins_section_titles = array(
+                                                                        'description'  =&gt; _x('Description',  'Plugin installer section title'),
+                                                                        'installation' =&gt; _x('Installation', 'Plugin installer section title'),
+                                                                        'faq'          =&gt; _x('FAQ',          'Plugin installer section title'),
+                                                                        'screenshots'  =&gt; _x('Screenshots',  'Plugin installer section title'),
+                                                                        'changelog'    =&gt; _x('Changelog',    'Plugin installer section title'),
+                                                                        'other_notes'  =&gt; _x('Other Notes',  'Plugin installer section title')
+                                                                        );
+
+
</ins><span class="cx">         //Sanitize HTML
</span><span class="cx">         foreach ( (array)$api-&gt;sections as $section_name =&gt; $content )
</span><span class="cx">                 $api-&gt;sections[$section_name] = wp_kses($content, $plugins_allowedtags);
</span><span class="lines">@@ -267,14 +278,16 @@
</span><span class="cx">         echo &quot;&lt;ul id='sidemenu'&gt;\n&quot;;
</span><span class="cx">         foreach ( (array)$api-&gt;sections as $section_name =&gt; $content ) {
</span><span class="cx"> 
</span><del>-                $title = $section_name;
-                $title = ucwords(str_replace('_', ' ', $title));
</del><ins>+                if ( isset( $plugins_section_titles[ $section_name ] ) )
+                        $title = $plugins_section_titles[ $section_name ];
+                else
+                        $title = ucwords( str_replace( '_', ' ', $section_name ) );
</ins><span class="cx"> 
</span><span class="cx">                 $class = ( $section_name == $section ) ? ' class=&quot;current&quot;' : '';
</span><span class="cx">                 $href = add_query_arg( array('tab' =&gt; $tab, 'section' =&gt; $section_name) );
</span><span class="cx">                 $href = esc_url($href);
</span><del>-                $san_title = esc_attr(sanitize_title_with_dashes($title));
-                echo &quot;\t&lt;li&gt;&lt;a name='$san_title' target='' href='$href'$class&gt;$title&lt;/a&gt;&lt;/li&gt;\n&quot;;
</del><ins>+                $san_section = esc_attr( $section_name );
+                echo &quot;\t&lt;li&gt;&lt;a name='$san_section' href='$href' $class&gt;$title&lt;/a&gt;&lt;/li&gt;\n&quot;;
</ins><span class="cx">         }
</span><span class="cx">         echo &quot;&lt;/ul&gt;\n&quot;;
</span><span class="cx">         echo &quot;&lt;/div&gt;\n&quot;;
</span><span class="lines">@@ -346,18 +359,20 @@
</span><span class="cx">                         echo '&lt;div class=&quot;updated&quot;&gt;&lt;p&gt;' . __('&lt;strong&gt;Warning:&lt;/strong&gt; This plugin has &lt;strong&gt;not been marked as compatible&lt;/strong&gt; with your version of WordPress.') . '&lt;/p&gt;&lt;/div&gt;';
</span><span class="cx"> 
</span><span class="cx">                 foreach ( (array)$api-&gt;sections as $section_name =&gt; $content ) {
</span><del>-                        $title = $section_name;
-                        $title[0] = strtoupper($title[0]);
-                        $title = str_replace('_', ' ', $title);
</del><span class="cx"> 
</span><ins>+                        if ( isset( $plugins_section_titles[ $section_name ] ) )
+                                $title = $plugins_section_titles[ $section_name ];
+                        else
+                                $title = ucwords( str_replace( '_', ' ', $section_name ) );
+
</ins><span class="cx">                         $content = links_add_base_url($content, 'http://wordpress.org/extend/plugins/' . $api-&gt;slug . '/');
</span><span class="cx">                         $content = links_add_target($content, '_blank');
</span><span class="cx"> 
</span><del>-                        $san_title = esc_attr(sanitize_title_with_dashes($title));
</del><ins>+                        $san_section = esc_attr( $section_name );
</ins><span class="cx"> 
</span><span class="cx">                         $display = ( $section_name == $section ) ? 'block' : 'none';
</span><span class="cx"> 
</span><del>-                        echo &quot;\t&lt;div id='section-{$san_title}' class='section' style='display: {$display};'&gt;\n&quot;;
</del><ins>+                        echo &quot;\t&lt;div id='section-{$san_section}' class='section' style='display: {$display};'&gt;\n&quot;;
</ins><span class="cx">                         echo &quot;\t\t&lt;h2 class='long-header'&gt;$title&lt;/h2&gt;&quot;;
</span><span class="cx">                         echo $content;
</span><span class="cx">                         echo &quot;\t&lt;/div&gt;\n&quot;;
</span></span></pre>
</div>
</div>

</body>
</html>