<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[19683] trunk/wp-includes/update.php: Check for plugin and theme updates more often when visitng update-core.php.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/19683">19683</a></dd>
<dt>Author</dt> <dd>ryan</dd>
<dt>Date</dt> <dd>2012-01-05 19:49:47 +0000 (Thu, 05 Jan 2012)</dd>
</dl>
<h3>Log Message</h3>
<pre>Check for plugin and theme updates more often when visitng update-core.php. Props kurtpayne. fixes <a href="http://core.trac.wordpress.org/ticket/18876">#18876</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludesupdatephp">trunk/wp-includes/update.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludesupdatephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/update.php (19682 => 19683)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/update.php 2012-01-05 18:29:40 UTC (rev 19682)
+++ trunk/wp-includes/update.php 2012-01-05 19:49:47 UTC (rev 19683)
</span><span class="lines">@@ -34,6 +34,12 @@
</span><span class="cx"> $current->version_checked = $wp_version;
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ // Wait 60 seconds between multiple version check requests
+ $timeout = 60;
+ $time_not_changed = isset( $current->last_checked ) && $timeout > ( time() - $current->last_checked );
+ if ( $time_not_changed )
+ return false;
+
</ins><span class="cx"> $locale = apply_filters( 'core_version_check_locale', get_locale() );
</span><span class="cx">
</span><span class="cx"> // Update last_checked for current to prevent multiple blocking requests if request hangs
</span><span class="lines">@@ -143,31 +149,45 @@
</span><span class="cx">
</span><span class="cx"> $new_option = new stdClass;
</span><span class="cx"> $new_option->last_checked = time();
</span><del>- // Check for updated every 60 minutes if hitting update pages; else, check every 12 hours.
- $timeout = in_array( current_filter(), array( 'load-plugins.php', 'load-update.php', 'load-update-core.php' ) ) ? 3600 : 43200;
</del><ins>+
+ // Check for update on a different schedule, depending on the page.
+ switch ( current_filter() ) {
+ case 'load-update-core.php' :
+ $timeout = 60; // 1 min
+ break;
+ case 'load-plugins.php' :
+ case 'load-update.php' :
+ $timeout = 3600; // 1 hour
+ break;
+ default :
+ $timeout = 43200; // 12 hours
+ }
+
</ins><span class="cx"> $time_not_changed = isset( $current->last_checked ) && $timeout > ( time() - $current->last_checked );
</span><span class="cx">
</span><del>- $plugin_changed = false;
- foreach ( $plugins as $file => $p ) {
- $new_option->checked[ $file ] = $p['Version'];
</del><ins>+ if ( $time_not_changed ) {
+ $plugin_changed = false;
+ foreach ( $plugins as $file => $p ) {
+ $new_option->checked[ $file ] = $p['Version'];
</ins><span class="cx">
</span><del>- if ( !isset( $current->checked[ $file ] ) || strval($current->checked[ $file ]) !== strval($p['Version']) )
- $plugin_changed = true;
- }
</del><ins>+ if ( !isset( $current->checked[ $file ] ) || strval($current->checked[ $file ]) !== strval($p['Version']) )
+ $plugin_changed = true;
+ }
</ins><span class="cx">
</span><del>- if ( isset ( $current->response ) && is_array( $current->response ) ) {
- foreach ( $current->response as $plugin_file => $update_details ) {
- if ( ! isset($plugins[ $plugin_file ]) ) {
- $plugin_changed = true;
- break;
</del><ins>+ if ( isset ( $current->response ) && is_array( $current->response ) ) {
+ foreach ( $current->response as $plugin_file => $update_details ) {
+ if ( ! isset($plugins[ $plugin_file ]) ) {
+ $plugin_changed = true;
+ break;
+ }
</ins><span class="cx"> }
</span><span class="cx"> }
</span><ins>+
+ // Bail if we've checked recently and if nothing has changed
+ if ( ! $plugin_changed )
+ return false;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- // Bail if we've checked in the last 12 hours and if nothing has changed
- if ( $time_not_changed && !$plugin_changed )
- return false;
-
</del><span class="cx"> // Update last_checked for current to prevent multiple blocking requests if request hangs
</span><span class="cx"> $current->last_checked = time();
</span><span class="cx"> set_site_transient( 'update_plugins', $current );
</span><span class="lines">@@ -222,10 +242,6 @@
</span><span class="cx"> if ( ! is_object($last_update) )
</span><span class="cx"> $last_update = new stdClass;
</span><span class="cx">
</span><del>- // Check for updated every 60 minutes if hitting update pages; else, check every 12 hours.
- $timeout = in_array( current_filter(), array( 'load-themes.php', 'load-update.php', 'load-update-core.php' ) ) ? 3600 : 43200;
- $time_not_changed = isset( $last_update->last_checked ) && $timeout > ( time( ) - $last_update->last_checked );
-
</del><span class="cx"> $themes = array();
</span><span class="cx"> $checked = array();
</span><span class="cx"> $exclude_fields = array('Template Files', 'Stylesheet Files', 'Status', 'Theme Root', 'Theme Root URI', 'Template Dir', 'Stylesheet Dir', 'Description', 'Tags', 'Screenshot');
</span><span class="lines">@@ -246,26 +262,44 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- $theme_changed = false;
- foreach ( $checked as $slug => $v ) {
- $update_request->checked[ $slug ] = $v;
-
- if ( !isset( $last_update->checked[ $slug ] ) || strval($last_update->checked[ $slug ]) !== strval($v) )
- $theme_changed = true;
</del><ins>+ // Check for update on a different schedule, depending on the page.
+ switch ( current_filter() ) {
+ case 'load-update-core.php' :
+ $timeout = 60; // 1 min
+ break;
+ case 'load-plugins.php' :
+ case 'load-update.php' :
+ $timeout = 3600; // 1 hour
+ break;
+ default :
+ $timeout = 43200; // 12 hours
</ins><span class="cx"> }
</span><ins>+
+ $time_not_changed = isset( $last_update->last_checked ) && $timeout > ( time( ) - $last_update->last_checked );
</ins><span class="cx">
</span><del>- if ( isset ( $last_update->response ) && is_array( $last_update->response ) ) {
- foreach ( $last_update->response as $slug => $update_details ) {
- if ( ! isset($checked[ $slug ]) ) {
</del><ins>+ if ( $time_not_changed ) {
+ $theme_changed = false;
+ foreach ( $checked as $slug => $v ) {
+ $update_request->checked[ $slug ] = $v;
+
+ if ( !isset( $last_update->checked[ $slug ] ) || strval($last_update->checked[ $slug ]) !== strval($v) )
</ins><span class="cx"> $theme_changed = true;
</span><del>- break;
</del><ins>+ }
+
+ if ( isset ( $last_update->response ) && is_array( $last_update->response ) ) {
+ foreach ( $last_update->response as $slug => $update_details ) {
+ if ( ! isset($checked[ $slug ]) ) {
+ $theme_changed = true;
+ break;
+ }
</ins><span class="cx"> }
</span><span class="cx"> }
</span><ins>+
+ // Bail if we've checked recently and if nothing has changed
+ if ( ! $theme_changed )
+ return false;
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- if ( $time_not_changed && !$theme_changed )
- return false;
-
</del><span class="cx"> // Update last_checked for current to prevent multiple blocking requests if request hangs
</span><span class="cx"> $last_update->last_checked = time();
</span><span class="cx"> set_site_transient( 'update_themes', $last_update );
</span></span></pre>
</div>
</div>
</body>
</html>