<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[19582] trunk/wp-content/themes: More consistent attribute escaping.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/19582">19582</a></dd>
<dt>Author</dt> <dd>ryan</dd>
<dt>Date</dt> <dd>2011-12-10 19:18:51 +0000 (Sat, 10 Dec 2011)</dd>
</dl>
<h3>Log Message</h3>
<pre>More consistent attribute escaping. Props nacin.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpcontentthemestwentyelevencontentimagephp">trunk/wp-content/themes/twentyeleven/content-image.php</a></li>
<li><a href="#trunkwpcontentthemestwentyelevencontentsinglephp">trunk/wp-content/themes/twentyeleven/content-single.php</a></li>
<li><a href="#trunkwpcontentthemestwentyelevenfunctionsphp">trunk/wp-content/themes/twentyeleven/functions.php</a></li>
<li><a href="#trunkwpcontentthemestwentyelevenimagephp">trunk/wp-content/themes/twentyeleven/image.php</a></li>
<li><a href="#trunkwpcontentthemestwentyelevenstylecss">trunk/wp-content/themes/twentyeleven/style.css</a></li>
<li><a href="#trunkwpcontentthemestwentytenfunctionsphp">trunk/wp-content/themes/twentyten/functions.php</a></li>
<li><a href="#trunkwpcontentthemestwentytenloopattachmentphp">trunk/wp-content/themes/twentyten/loop-attachment.php</a></li>
<li><a href="#trunkwpcontentthemestwentytenloopsinglephp">trunk/wp-content/themes/twentyten/loop-single.php</a></li>
<li><a href="#trunkwpcontentthemestwentytenstylecss">trunk/wp-content/themes/twentyten/style.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpcontentthemestwentyelevencontentimagephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-content/themes/twentyeleven/content-image.php (19581 => 19582)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-content/themes/twentyeleven/content-image.php 2011-12-10 18:47:17 UTC (rev 19581)
+++ trunk/wp-content/themes/twentyeleven/content-image.php 2011-12-10 19:18:51 UTC (rev 19582)
</span><span class="lines">@@ -36,7 +36,7 @@
</span><span class="cx"> get_the_date( 'c' ),
</span><span class="cx"> get_the_date(),
</span><span class="cx"> esc_url( get_author_posts_url( get_the_author_meta( 'ID' ) ) ),
</span><del>- sprintf( esc_attr__( 'View all posts by %s', 'twentyeleven' ), get_the_author() ),
</del><ins>+ esc_attr( sprintf( __( 'View all posts by %s', 'twentyeleven' ), get_the_author() ) ),
</ins><span class="cx"> get_the_author()
</span><span class="cx"> );
</span><span class="cx"> ?>
</span></span></pre></div>
<a id="trunkwpcontentthemestwentyelevencontentsinglephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-content/themes/twentyeleven/content-single.php (19581 => 19582)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-content/themes/twentyeleven/content-single.php 2011-12-10 18:47:17 UTC (rev 19581)
+++ trunk/wp-content/themes/twentyeleven/content-single.php 2011-12-10 19:18:51 UTC (rev 19582)
</span><span class="lines">@@ -57,7 +57,7 @@
</span><span class="cx"> <?php echo get_avatar( get_the_author_meta( 'user_email' ), apply_filters( 'twentyeleven_author_bio_avatar_size', 68 ) ); ?>
</span><span class="cx"> </div><!-- #author-avatar -->
</span><span class="cx"> <div id="author-description">
</span><del>- <h2><?php printf( esc_attr__( 'About %s', 'twentyeleven' ), get_the_author() ); ?></h2>
</del><ins>+ <h2><?php printf( __( 'About %s', 'twentyeleven' ), get_the_author() ); ?></h2>
</ins><span class="cx"> <?php the_author_meta( 'description' ); ?>
</span><span class="cx"> <div id="author-link">
</span><span class="cx"> <a href="<?php echo esc_url( get_author_posts_url( get_the_author_meta( 'ID' ) ) ); ?>" rel="author">
</span></span></pre></div>
<a id="trunkwpcontentthemestwentyelevenfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-content/themes/twentyeleven/functions.php (19581 => 19582)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-content/themes/twentyeleven/functions.php 2011-12-10 18:47:17 UTC (rev 19581)
+++ trunk/wp-content/themes/twentyeleven/functions.php 2011-12-10 19:18:51 UTC (rev 19582)
</span><span class="lines">@@ -567,8 +567,8 @@
</span><span class="cx"> esc_attr( get_the_date( 'c' ) ),
</span><span class="cx"> esc_html( get_the_date() ),
</span><span class="cx"> esc_url( get_author_posts_url( get_the_author_meta( 'ID' ) ) ),
</span><del>- sprintf( esc_attr__( 'View all posts by %s', 'twentyeleven' ), get_the_author() ),
- esc_html( get_the_author() )
</del><ins>+ esc_attr( sprintf( __( 'View all posts by %s', 'twentyeleven' ), get_the_author() ) ),
+ get_the_author()
</ins><span class="cx"> );
</span><span class="cx"> }
</span><span class="cx"> endif;
</span><span class="lines">@@ -582,9 +582,8 @@
</span><span class="cx"> */
</span><span class="cx"> function twentyeleven_body_classes( $classes ) {
</span><span class="cx">
</span><del>- if ( ! is_multi_author() ) {
</del><ins>+ if ( function_exists( 'is_multi_author' ) && ! is_multi_author() )
</ins><span class="cx"> $classes[] = 'single-author';
</span><del>- }
</del><span class="cx">
</span><span class="cx"> if ( is_singular() && ! is_home() && ! is_page_template( 'showcase.php' ) && ! is_page_template( 'sidebar-page.php' ) )
</span><span class="cx"> $classes[] = 'singular';
</span></span></pre></div>
<a id="trunkwpcontentthemestwentyelevenimagephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-content/themes/twentyeleven/image.php (19581 => 19582)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-content/themes/twentyeleven/image.php 2011-12-10 18:47:17 UTC (rev 19581)
+++ trunk/wp-content/themes/twentyeleven/image.php 2011-12-10 19:18:51 UTC (rev 19582)
</span><span class="lines">@@ -27,13 +27,14 @@
</span><span class="cx"> <div class="entry-meta">
</span><span class="cx"> <?php
</span><span class="cx"> $metadata = wp_get_attachment_metadata();
</span><del>- printf( __( '<span class="meta-prep meta-prep-entry-date">Published </span> <span class="entry-date"><abbr class="published" title="%1$s">%2$s</abbr></span> at <a href="%3$s" title="Link to full-size image">%4$s &times; %5$s</a> in <a href="%6$s" title="Return to %7$s" rel="gallery">%7$s</a>', 'twentyeleven' ),
</del><ins>+ printf( __( '<span class="meta-prep meta-prep-entry-date">Published </span> <span class="entry-date"><abbr class="published" title="%1$s">%2$s</abbr></span> at <a href="%3$s" title="Link to full-size image">%4$s &times; %5$s</a> in <a href="%6$s" title="Return to %7$s" rel="gallery">%8$s</a>', 'twentyeleven' ),
</ins><span class="cx"> esc_attr( get_the_time() ),
</span><span class="cx"> get_the_date(),
</span><span class="cx"> esc_url( wp_get_attachment_url() ),
</span><span class="cx"> $metadata['width'],
</span><span class="cx"> $metadata['height'],
</span><span class="cx"> esc_url( get_permalink( $post->post_parent ) ),
</span><ins>+ esc_attr( strip_tags( get_the_title( $post->post_parent ) ) ),
</ins><span class="cx"> get_the_title( $post->post_parent )
</span><span class="cx"> );
</span><span class="cx"> ?>
</span><span class="lines">@@ -70,7 +71,7 @@
</span><span class="cx"> $next_attachment_url = wp_get_attachment_url();
</span><span class="cx"> }
</span><span class="cx"> ?>
</span><del>- <a href="<?php echo esc_url( $next_attachment_url ); ?>" title="<?php echo esc_attr( get_the_title() ); ?>" rel="attachment"><?php
</del><ins>+ <a href="<?php echo esc_url( $next_attachment_url ); ?>" title="<?php the_title_attribute(); ?>" rel="attachment"><?php
</ins><span class="cx"> $attachment_size = apply_filters( 'twentyeleven_attachment_size', 848 );
</span><span class="cx"> echo wp_get_attachment_image( $post->ID, array( $attachment_size, 1024 ) ); // filterable image width with 1024px limit for image height.
</span><span class="cx"> ?></a>
</span></span></pre></div>
<a id="trunkwpcontentthemestwentyelevenstylecss"></a>
<div class="modfile"><h4>Modified: trunk/wp-content/themes/twentyeleven/style.css (19581 => 19582)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-content/themes/twentyeleven/style.css 2011-12-10 18:47:17 UTC (rev 19581)
+++ trunk/wp-content/themes/twentyeleven/style.css 2011-12-10 19:18:51 UTC (rev 19582)
</span><span class="lines">@@ -4,7 +4,7 @@
</span><span class="cx"> Author: the WordPress team
</span><span class="cx"> Author URI: http://wordpress.org/
</span><span class="cx"> Description: The 2011 theme for WordPress is sophisticated, lightweight, and adaptable. Make it yours with a custom menu, header image, and background -- then go further with available theme options for light or dark color scheme, custom link colors, and three layout choices. Twenty Eleven comes equipped with a Showcase page template that transforms your front page into a showcase to show off your best content, widget support galore (sidebar, three footer areas, and a Showcase page widget area), and a custom "Ephemera" widget to display your Aside, Link, Quote, or Status posts. Included are styles for print and for the admin editor, support for featured images (as custom header images on posts and pages and as large images on featured "sticky" posts), and special styles for six different post formats.
</span><del>-Version: 1.2
</del><ins>+Version: 1.3
</ins><span class="cx"> License: GNU General Public License
</span><span class="cx"> License URI: license.txt
</span><span class="cx"> Tags: dark, light, white, black, gray, one-column, two-columns, left-sidebar, right-sidebar, fixed-width, flexible-width, custom-background, custom-colors, custom-header, custom-menu, editor-style, featured-image-header, featured-images, full-width-template, microformats, post-formats, rtl-language-support, sticky-post, theme-options, translation-ready
</span></span></pre></div>
<a id="trunkwpcontentthemestwentytenfunctionsphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-content/themes/twentyten/functions.php (19581 => 19582)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-content/themes/twentyten/functions.php 2011-12-10 18:47:17 UTC (rev 19581)
+++ trunk/wp-content/themes/twentyten/functions.php 2011-12-10 19:18:51 UTC (rev 19582)
</span><span class="lines">@@ -473,7 +473,7 @@
</span><span class="cx"> ),
</span><span class="cx"> sprintf( '<span class="author vcard"><a class="url fn n" href="%1$s" title="%2$s">%3$s</a></span>',
</span><span class="cx"> get_author_posts_url( get_the_author_meta( 'ID' ) ),
</span><del>- sprintf( esc_attr__( 'View all posts by %s', 'twentyten' ), get_the_author() ),
</del><ins>+ esc_attr( sprintf( __( 'View all posts by %s', 'twentyten' ), get_the_author() ) ),
</ins><span class="cx"> get_the_author()
</span><span class="cx"> )
</span><span class="cx"> );
</span></span></pre></div>
<a id="trunkwpcontentthemestwentytenloopattachmentphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-content/themes/twentyten/loop-attachment.php (19581 => 19582)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-content/themes/twentyten/loop-attachment.php 2011-12-10 18:47:17 UTC (rev 19581)
+++ trunk/wp-content/themes/twentyten/loop-attachment.php 2011-12-10 19:18:51 UTC (rev 19582)
</span><span class="lines">@@ -18,7 +18,7 @@
</span><span class="cx"> <?php if ( have_posts() ) while ( have_posts() ) : the_post(); ?>
</span><span class="cx">
</span><span class="cx"> <?php if ( ! empty( $post->post_parent ) ) : ?>
</span><del>- <p class="page-title"><a href="<?php echo get_permalink( $post->post_parent ); ?>" title="<?php esc_attr( printf( __( 'Return to %s', 'twentyten' ), get_the_title( $post->post_parent ) ) ); ?>" rel="gallery"><?php
</del><ins>+ <p class="page-title"><a href="<?php echo get_permalink( $post->post_parent ); ?>" title="<?php echo esc_attr( sprintf( __( 'Return to %s', 'twentyten' ), strip_tags( get_the_title( $post->post_parent ) ) ) ); ?>" rel="gallery"><?php
</ins><span class="cx"> /* translators: %s - title of parent post */
</span><span class="cx"> printf( __( '<span class="meta-nav">&larr;</span> %s', 'twentyten' ), get_the_title( $post->post_parent ) );
</span><span class="cx"> ?></a></p>
</span><span class="lines">@@ -33,7 +33,7 @@
</span><span class="cx"> 'meta-prep meta-prep-author',
</span><span class="cx"> sprintf( '<span class="author vcard"><a class="url fn n" href="%1$s" title="%2$s" rel="author">%3$s</a></span>',
</span><span class="cx"> get_author_posts_url( get_the_author_meta( 'ID' ) ),
</span><del>- sprintf( esc_attr__( 'View all posts by %s', 'twentyten' ), get_the_author() ),
</del><ins>+ esc_attr( sprintf( __( 'View all posts by %s', 'twentyten' ), get_the_author() ) ),
</ins><span class="cx"> get_the_author()
</span><span class="cx"> )
</span><span class="cx"> );
</span><span class="lines">@@ -85,7 +85,7 @@
</span><span class="cx"> $next_attachment_url = wp_get_attachment_url();
</span><span class="cx"> }
</span><span class="cx"> ?>
</span><del>- <p class="attachment"><a href="<?php echo $next_attachment_url; ?>" title="<?php echo esc_attr( get_the_title() ); ?>" rel="attachment"><?php
</del><ins>+ <p class="attachment"><a href="<?php echo $next_attachment_url; ?>" title="<?php the_title_attribute(); ?>" rel="attachment"><?php
</ins><span class="cx"> $attachment_width = apply_filters( 'twentyten_attachment_size', 900 );
</span><span class="cx"> $attachment_height = apply_filters( 'twentyten_attachment_height', 900 );
</span><span class="cx"> echo wp_get_attachment_image( $post->ID, array( $attachment_width, $attachment_height ) ); // filterable image width with, essentially, no limit for image height.
</span><span class="lines">@@ -96,7 +96,7 @@
</span><span class="cx"> <div class="nav-next"><?php next_image_link( false ); ?></div>
</span><span class="cx"> </div><!-- #nav-below -->
</span><span class="cx"> <?php else : ?>
</span><del>- <a href="<?php echo wp_get_attachment_url(); ?>" title="<?php echo esc_attr( get_the_title() ); ?>" rel="attachment"><?php echo basename( get_permalink() ); ?></a>
</del><ins>+ <a href="<?php echo wp_get_attachment_url(); ?>" title="<?php the_title_attribute(); ?>" rel="attachment"><?php echo basename( get_permalink() ); ?></a>
</ins><span class="cx"> <?php endif; ?>
</span><span class="cx"> </div><!-- .entry-attachment -->
</span><span class="cx"> <div class="entry-caption"><?php if ( !empty( $post->post_excerpt ) ) the_excerpt(); ?></div>
</span></span></pre></div>
<a id="trunkwpcontentthemestwentytenloopsinglephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-content/themes/twentyten/loop-single.php (19581 => 19582)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-content/themes/twentyten/loop-single.php 2011-12-10 18:47:17 UTC (rev 19581)
+++ trunk/wp-content/themes/twentyten/loop-single.php 2011-12-10 19:18:51 UTC (rev 19582)
</span><span class="lines">@@ -40,7 +40,7 @@
</span><span class="cx"> <?php echo get_avatar( get_the_author_meta( 'user_email' ), apply_filters( 'twentyten_author_bio_avatar_size', 60 ) ); ?>
</span><span class="cx"> </div><!-- #author-avatar -->
</span><span class="cx"> <div id="author-description">
</span><del>- <h2><?php printf( esc_attr__( 'About %s', 'twentyten' ), get_the_author() ); ?></h2>
</del><ins>+ <h2><?php printf( __( 'About %s', 'twentyten' ), get_the_author() ); ?></h2>
</ins><span class="cx"> <?php the_author_meta( 'description' ); ?>
</span><span class="cx"> <div id="author-link">
</span><span class="cx"> <a href="<?php echo get_author_posts_url( get_the_author_meta( 'ID' ) ); ?>" rel="author">
</span></span></pre></div>
<a id="trunkwpcontentthemestwentytenstylecss"></a>
<div class="modfile"><h4>Modified: trunk/wp-content/themes/twentyten/style.css (19581 => 19582)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-content/themes/twentyten/style.css 2011-12-10 18:47:17 UTC (rev 19581)
+++ trunk/wp-content/themes/twentyten/style.css 2011-12-10 19:18:51 UTC (rev 19582)
</span><span class="lines">@@ -3,7 +3,7 @@
</span><span class="cx"> Theme URI: http://wordpress.org/
</span><span class="cx"> Description: The 2010 theme for WordPress is stylish, customizable, simple, and readable -- make it yours with a custom menu, header image, and background. Twenty Ten supports six widgetized areas (two in the sidebar, four in the footer) and featured images (thumbnails for gallery posts and custom header images for posts and pages). It includes stylesheets for print and the admin Visual Editor, special styles for posts in the "Asides" and "Gallery" categories, and has an optional one-column page template that removes the sidebar.
</span><span class="cx"> Author: the WordPress team
</span><del>-Version: 1.2
</del><ins>+Version: 1.3
</ins><span class="cx"> License: GNU General Public License
</span><span class="cx"> License URI: license.txt
</span><span class="cx"> Tags: black, blue, white, two-columns, fixed-width, custom-header, custom-background, threaded-comments, sticky-post, translation-ready, microformats, rtl-language-support, editor-style, custom-menu
</span></span></pre>
</div>
</div>
</body>
</html>