<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[19379] trunk/wp-content/themes/twentyeleven: TwentyEleven: Always call the loop properly in all template files rather than just calling the_post().</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg > ul, #logmsg > ol { margin-left: 0; margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://core.trac.wordpress.org/changeset/19379">19379</a></dd>
<dt>Author</dt> <dd>westi</dd>
<dt>Date</dt> <dd>2011-11-21 16:20:49 +0000 (Mon, 21 Nov 2011)</dd>
</dl>

<h3>Log Message</h3>
<pre>TwentyEleven: Always call the loop properly in all template files rather than just calling the_post(). Fixes <a href="http://core.trac.wordpress.org/ticket/18794">#18794</a> props mfields.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpcontentthemestwentyelevenimagephp">trunk/wp-content/themes/twentyeleven/image.php</a></li>
<li><a href="#trunkwpcontentthemestwentyelevenpagephp">trunk/wp-content/themes/twentyeleven/page.php</a></li>
<li><a href="#trunkwpcontentthemestwentyelevenshowcasephp">trunk/wp-content/themes/twentyeleven/showcase.php</a></li>
<li><a href="#trunkwpcontentthemestwentyelevensidebarpagephp">trunk/wp-content/themes/twentyeleven/sidebar-page.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpcontentthemestwentyelevenimagephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-content/themes/twentyeleven/image.php (19378 => 19379)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-content/themes/twentyeleven/image.php        2011-11-21 15:47:49 UTC (rev 19378)
+++ trunk/wp-content/themes/twentyeleven/image.php        2011-11-21 16:20:49 UTC (rev 19379)
</span><span class="lines">@@ -12,40 +12,40 @@
</span><span class="cx">                 &lt;div id=&quot;primary&quot; class=&quot;image-attachment&quot;&gt;
</span><span class="cx">                         &lt;div id=&quot;content&quot; role=&quot;main&quot;&gt;
</span><span class="cx"> 
</span><del>-                        &lt;?php the_post(); ?&gt;
</del><ins>+                        &lt;?php while ( have_posts() ) : the_post(); ?&gt;
</ins><span class="cx"> 
</span><del>-                        &lt;nav id=&quot;nav-single&quot;&gt;
-                                &lt;h3 class=&quot;assistive-text&quot;&gt;&lt;?php _e( 'Image navigation', 'twentyeleven' ); ?&gt;&lt;/h3&gt;
-                                &lt;span class=&quot;nav-previous&quot;&gt;&lt;?php previous_image_link( false, __( '&amp;larr; Previous' , 'twentyeleven' ) ); ?&gt;&lt;/span&gt;
-                                &lt;span class=&quot;nav-next&quot;&gt;&lt;?php next_image_link( false, __( 'Next &amp;rarr;' , 'twentyeleven' ) ); ?&gt;&lt;/span&gt;
-                        &lt;/nav&gt;&lt;!-- #nav-single --&gt;
</del><ins>+                                &lt;nav id=&quot;nav-single&quot;&gt;
+                                        &lt;h3 class=&quot;assistive-text&quot;&gt;&lt;?php _e( 'Image navigation', 'twentyeleven' ); ?&gt;&lt;/h3&gt;
+                                        &lt;span class=&quot;nav-previous&quot;&gt;&lt;?php previous_image_link( false, __( '&amp;larr; Previous' , 'twentyeleven' ) ); ?&gt;&lt;/span&gt;
+                                        &lt;span class=&quot;nav-next&quot;&gt;&lt;?php next_image_link( false, __( 'Next &amp;rarr;' , 'twentyeleven' ) ); ?&gt;&lt;/span&gt;
+                                &lt;/nav&gt;&lt;!-- #nav-single --&gt;
</ins><span class="cx"> 
</span><del>-                                &lt;article id=&quot;post-&lt;?php the_ID(); ?&gt;&quot; &lt;?php post_class(); ?&gt;&gt;
-                                        &lt;header class=&quot;entry-header&quot;&gt;
-                                                &lt;h1 class=&quot;entry-title&quot;&gt;&lt;?php the_title(); ?&gt;&lt;/h1&gt;
</del><ins>+                                        &lt;article id=&quot;post-&lt;?php the_ID(); ?&gt;&quot; &lt;?php post_class(); ?&gt;&gt;
+                                                &lt;header class=&quot;entry-header&quot;&gt;
+                                                        &lt;h1 class=&quot;entry-title&quot;&gt;&lt;?php the_title(); ?&gt;&lt;/h1&gt;
</ins><span class="cx"> 
</span><del>-                                                &lt;div class=&quot;entry-meta&quot;&gt;
-                                                        &lt;?php
-                                                                $metadata = wp_get_attachment_metadata();
-                                                                printf( __( '&lt;span class=&quot;meta-prep meta-prep-entry-date&quot;&gt;Published &lt;/span&gt; &lt;span class=&quot;entry-date&quot;&gt;&lt;abbr class=&quot;published&quot; title=&quot;%1$s&quot;&gt;%2$s&lt;/abbr&gt;&lt;/span&gt; at &lt;a href=&quot;%3$s&quot; title=&quot;Link to full-size image&quot;&gt;%4$s &amp;times; %5$s&lt;/a&gt; in &lt;a href=&quot;%6$s&quot; title=&quot;Return to %7$s&quot; rel=&quot;gallery&quot;&gt;%7$s&lt;/a&gt;', 'twentyeleven' ),
-                                                                        esc_attr( get_the_time() ),
-                                                                        get_the_date(),
-                                                                        esc_url( wp_get_attachment_url() ),
-                                                                        $metadata['width'],
-                                                                        $metadata['height'],
-                                                                        esc_url( get_permalink( $post-&gt;post_parent ) ),
-                                                                        get_the_title( $post-&gt;post_parent )
-                                                                );
-                                                        ?&gt;
-                                                        &lt;?php edit_post_link( __( 'Edit', 'twentyeleven' ), '&lt;span class=&quot;edit-link&quot;&gt;', '&lt;/span&gt;' ); ?&gt;
-                                                &lt;/div&gt;&lt;!-- .entry-meta --&gt;
</del><ins>+                                                        &lt;div class=&quot;entry-meta&quot;&gt;
+                                                                &lt;?php
+                                                                        $metadata = wp_get_attachment_metadata();
+                                                                        printf( __( '&lt;span class=&quot;meta-prep meta-prep-entry-date&quot;&gt;Published &lt;/span&gt; &lt;span class=&quot;entry-date&quot;&gt;&lt;abbr class=&quot;published&quot; title=&quot;%1$s&quot;&gt;%2$s&lt;/abbr&gt;&lt;/span&gt; at &lt;a href=&quot;%3$s&quot; title=&quot;Link to full-size image&quot;&gt;%4$s &amp;times; %5$s&lt;/a&gt; in &lt;a href=&quot;%6$s&quot; title=&quot;Return to %7$s&quot; rel=&quot;gallery&quot;&gt;%7$s&lt;/a&gt;', 'twentyeleven' ),
+                                                                                esc_attr( get_the_time() ),
+                                                                                get_the_date(),
+                                                                                esc_url( wp_get_attachment_url() ),
+                                                                                $metadata['width'],
+                                                                                $metadata['height'],
+                                                                                esc_url( get_permalink( $post-&gt;post_parent ) ),
+                                                                                get_the_title( $post-&gt;post_parent )
+                                                                        );
+                                                                ?&gt;
+                                                                &lt;?php edit_post_link( __( 'Edit', 'twentyeleven' ), '&lt;span class=&quot;edit-link&quot;&gt;', '&lt;/span&gt;' ); ?&gt;
+                                                        &lt;/div&gt;&lt;!-- .entry-meta --&gt;
</ins><span class="cx"> 
</span><del>-                                        &lt;/header&gt;&lt;!-- .entry-header --&gt;
</del><ins>+                                                &lt;/header&gt;&lt;!-- .entry-header --&gt;
</ins><span class="cx"> 
</span><del>-                                        &lt;div class=&quot;entry-content&quot;&gt;
</del><ins>+                                                &lt;div class=&quot;entry-content&quot;&gt;
</ins><span class="cx"> 
</span><del>-                                                &lt;div class=&quot;entry-attachment&quot;&gt;
-                                                        &lt;div class=&quot;attachment&quot;&gt;
</del><ins>+                                                        &lt;div class=&quot;entry-attachment&quot;&gt;
+                                                                &lt;div class=&quot;attachment&quot;&gt;
</ins><span class="cx"> &lt;?php
</span><span class="cx">         /**
</span><span class="cx">          * Grab the IDs of all the image attachments in a gallery so we can get the URL of the next adjacent image in a gallery,
</span><span class="lines">@@ -70,31 +70,33 @@
</span><span class="cx">                 $next_attachment_url = wp_get_attachment_url();
</span><span class="cx">         }
</span><span class="cx"> ?&gt;
</span><del>-                                                                &lt;a href=&quot;&lt;?php echo esc_url( $next_attachment_url ); ?&gt;&quot; title=&quot;&lt;?php echo esc_attr( get_the_title() ); ?&gt;&quot; rel=&quot;attachment&quot;&gt;&lt;?php
-                                                                $attachment_size = apply_filters( 'twentyeleven_attachment_size', 848 );
-                                                                echo wp_get_attachment_image( $post-&gt;ID, array( $attachment_size, 1024 ) ); // filterable image width with 1024px limit for image height.
-                                                                ?&gt;&lt;/a&gt;
</del><ins>+                                                                        &lt;a href=&quot;&lt;?php echo esc_url( $next_attachment_url ); ?&gt;&quot; title=&quot;&lt;?php echo esc_attr( get_the_title() ); ?&gt;&quot; rel=&quot;attachment&quot;&gt;&lt;?php
+                                                                        $attachment_size = apply_filters( 'twentyeleven_attachment_size', 848 );
+                                                                        echo wp_get_attachment_image( $post-&gt;ID, array( $attachment_size, 1024 ) ); // filterable image width with 1024px limit for image height.
+                                                                        ?&gt;&lt;/a&gt;
</ins><span class="cx"> 
</span><del>-                                                                &lt;?php if ( ! empty( $post-&gt;post_excerpt ) ) : ?&gt;
-                                                                &lt;div class=&quot;entry-caption&quot;&gt;
-                                                                        &lt;?php the_excerpt(); ?&gt;
-                                                                &lt;/div&gt;
-                                                                &lt;?php endif; ?&gt;
-                                                        &lt;/div&gt;&lt;!-- .attachment --&gt;
</del><ins>+                                                                        &lt;?php if ( ! empty( $post-&gt;post_excerpt ) ) : ?&gt;
+                                                                        &lt;div class=&quot;entry-caption&quot;&gt;
+                                                                                &lt;?php the_excerpt(); ?&gt;
+                                                                        &lt;/div&gt;
+                                                                        &lt;?php endif; ?&gt;
+                                                                &lt;/div&gt;&lt;!-- .attachment --&gt;
</ins><span class="cx"> 
</span><del>-                                                &lt;/div&gt;&lt;!-- .entry-attachment --&gt;
</del><ins>+                                                        &lt;/div&gt;&lt;!-- .entry-attachment --&gt;
</ins><span class="cx"> 
</span><del>-                                                &lt;div class=&quot;entry-description&quot;&gt;
-                                                        &lt;?php the_content(); ?&gt;
-                                                        &lt;?php wp_link_pages( array( 'before' =&gt; '&lt;div class=&quot;page-link&quot;&gt;&lt;span&gt;' . __( 'Pages:', 'twentyeleven' ) . '&lt;/span&gt;', 'after' =&gt; '&lt;/div&gt;' ) ); ?&gt;
-                                                &lt;/div&gt;&lt;!-- .entry-description --&gt;
</del><ins>+                                                        &lt;div class=&quot;entry-description&quot;&gt;
+                                                                &lt;?php the_content(); ?&gt;
+                                                                &lt;?php wp_link_pages( array( 'before' =&gt; '&lt;div class=&quot;page-link&quot;&gt;&lt;span&gt;' . __( 'Pages:', 'twentyeleven' ) . '&lt;/span&gt;', 'after' =&gt; '&lt;/div&gt;' ) ); ?&gt;
+                                                        &lt;/div&gt;&lt;!-- .entry-description --&gt;
</ins><span class="cx"> 
</span><del>-                                        &lt;/div&gt;&lt;!-- .entry-content --&gt;
</del><ins>+                                                &lt;/div&gt;&lt;!-- .entry-content --&gt;
</ins><span class="cx"> 
</span><del>-                                &lt;/article&gt;&lt;!-- #post-&lt;?php the_ID(); ?&gt; --&gt;
</del><ins>+                                        &lt;/article&gt;&lt;!-- #post-&lt;?php the_ID(); ?&gt; --&gt;
</ins><span class="cx"> 
</span><del>-                                &lt;?php comments_template(); ?&gt;
</del><ins>+                                        &lt;?php comments_template(); ?&gt;
</ins><span class="cx"> 
</span><ins>+                                &lt;?php endwhile; // end of the loop. ?&gt;
+
</ins><span class="cx">                         &lt;/div&gt;&lt;!-- #content --&gt;
</span><span class="cx">                 &lt;/div&gt;&lt;!-- #primary --&gt;
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkwpcontentthemestwentyelevenpagephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-content/themes/twentyeleven/page.php (19378 => 19379)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-content/themes/twentyeleven/page.php        2011-11-21 15:47:49 UTC (rev 19378)
+++ trunk/wp-content/themes/twentyeleven/page.php        2011-11-21 16:20:49 UTC (rev 19379)
</span><span class="lines">@@ -17,12 +17,14 @@
</span><span class="cx">                 &lt;div id=&quot;primary&quot;&gt;
</span><span class="cx">                         &lt;div id=&quot;content&quot; role=&quot;main&quot;&gt;
</span><span class="cx"> 
</span><del>-                                &lt;?php the_post(); ?&gt;
</del><ins>+                                &lt;?php while ( have_posts() ) : the_post(); ?&gt;
</ins><span class="cx"> 
</span><del>-                                &lt;?php get_template_part( 'content', 'page' ); ?&gt;
</del><ins>+                                        &lt;?php get_template_part( 'content', 'page' ); ?&gt;
</ins><span class="cx"> 
</span><del>-                                &lt;?php comments_template( '', true ); ?&gt;
</del><ins>+                                        &lt;?php comments_template( '', true ); ?&gt;
</ins><span class="cx"> 
</span><ins>+                                &lt;?php endwhile; // end of the loop. ?&gt;
+
</ins><span class="cx">                         &lt;/div&gt;&lt;!-- #content --&gt;
</span><span class="cx">                 &lt;/div&gt;&lt;!-- #primary --&gt;
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunkwpcontentthemestwentyelevenshowcasephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-content/themes/twentyeleven/showcase.php (19378 => 19379)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-content/themes/twentyeleven/showcase.php        2011-11-21 15:47:49 UTC (rev 19378)
+++ trunk/wp-content/themes/twentyeleven/showcase.php        2011-11-21 16:20:49 UTC (rev 19379)
</span><span class="lines">@@ -22,7 +22,7 @@
</span><span class="cx">                 &lt;div id=&quot;primary&quot; class=&quot;showcase&quot;&gt;
</span><span class="cx">                         &lt;div id=&quot;content&quot; role=&quot;main&quot;&gt;
</span><span class="cx"> 
</span><del>-                                &lt;?php the_post(); ?&gt;
</del><ins>+                                &lt;?php while ( have_posts() ) : the_post(); ?&gt;
</ins><span class="cx"> 
</span><span class="cx">                                 &lt;?php
</span><span class="cx">                                         /**
</span><span class="lines">@@ -33,6 +33,8 @@
</span><span class="cx">                                                 get_template_part( 'content', 'intro' );
</span><span class="cx">                                 ?&gt;
</span><span class="cx"> 
</span><ins>+                                &lt;?php endwhile; ?&gt;
+
</ins><span class="cx">                                 &lt;?php
</span><span class="cx">                                         /**
</span><span class="cx">                                          * Begin the featured posts section.
</span></span></pre></div>
<a id="trunkwpcontentthemestwentyelevensidebarpagephp"></a>
<div class="modfile"><h4>Modified: trunk/wp-content/themes/twentyeleven/sidebar-page.php (19378 => 19379)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-content/themes/twentyeleven/sidebar-page.php        2011-11-21 15:47:49 UTC (rev 19378)
+++ trunk/wp-content/themes/twentyeleven/sidebar-page.php        2011-11-21 16:20:49 UTC (rev 19379)
</span><span class="lines">@@ -13,12 +13,14 @@
</span><span class="cx">                 &lt;div id=&quot;primary&quot;&gt;
</span><span class="cx">                         &lt;div id=&quot;content&quot; role=&quot;main&quot;&gt;
</span><span class="cx"> 
</span><del>-                                &lt;?php the_post(); ?&gt;
</del><ins>+                                &lt;?php while ( have_posts() ) : the_post(); ?&gt;
</ins><span class="cx"> 
</span><del>-                                &lt;?php get_template_part( 'content', 'page' ); ?&gt;
</del><ins>+                                        &lt;?php get_template_part( 'content', 'page' ); ?&gt;
</ins><span class="cx"> 
</span><del>-                                &lt;?php comments_template( '', true ); ?&gt;
</del><ins>+                                        &lt;?php comments_template( '', true ); ?&gt;
</ins><span class="cx"> 
</span><ins>+                                &lt;?php endwhile; // end of the loop. ?&gt;
+
</ins><span class="cx">                         &lt;/div&gt;&lt;!-- #content --&gt;
</span><span class="cx">                 &lt;/div&gt;&lt;!-- #primary --&gt;
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>