<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[17296] trunk/wp-includes/admin-bar.php:
Rename wp_admin_bar_init to _wp_admin_bar_init and add a note that removing this action is the wrong way to do it
.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/17296">17296</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2011-01-14 05:57:25 +0000 (Fri, 14 Jan 2011)</dd>
</dl>
<h3>Log Message</h3>
<pre>Rename wp_admin_bar_init to _wp_admin_bar_init and add a note that removing this action is the wrong way to do it.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludesadminbarphp">trunk/wp-includes/admin-bar.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludesadminbarphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/admin-bar.php (17295 => 17296)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/admin-bar.php 2011-01-14 02:25:24 UTC (rev 17295)
+++ trunk/wp-includes/admin-bar.php 2011-01-14 05:57:25 UTC (rev 17296)
</span><span class="lines">@@ -8,10 +8,14 @@
</span><span class="cx"> /**
</span><span class="cx"> * Instantiate the admin bar object and set it up as a global for access elsewhere.
</span><span class="cx"> *
</span><ins>+ * To hide the admin bar, you're looking in the wrong place. Unhooking this function will not
+ * properly remove the admin bar. For that, use show_admin_bar(false) or the show_admin_bar filter.
+ *
</ins><span class="cx"> * @since 3.1.0
</span><ins>+ * @access private
</ins><span class="cx"> * @return bool Whether the admin bar was successfully initialized.
</span><span class="cx"> */
</span><del>-function wp_admin_bar_init() {
</del><ins>+function _wp_admin_bar_init() {
</ins><span class="cx"> global $wp_admin_bar;
</span><span class="cx">
</span><span class="cx"> if ( ! is_admin_bar_showing() )
</span><span class="lines">@@ -32,7 +36,7 @@
</span><span class="cx">
</span><span class="cx"> return true;
</span><span class="cx"> }
</span><del>-add_action( 'init', 'wp_admin_bar_init' );
</del><ins>+add_action( 'init', '_wp_admin_bar_init' ); // Don't remove. Wrong way to disable.
</ins><span class="cx">
</span><span class="cx"> /**
</span><span class="cx"> * Render the admin bar to the page based on the $wp_admin_bar->menu member var.
</span></span></pre>
</div>
</div>
</body>
</html>