<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[17170] trunk/wp-includes: get_meta_sql should be private.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/17170">17170</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2010-12-29 19:31:35 +0000 (Wed, 29 Dec 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>get_meta_sql should be private. see <a href="http://trac.wordpress.org/ticket/14645">#14645</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludesmetaphp">trunk/wp-includes/meta.php</a></li>
<li><a href="#trunkwpincludesqueryphp">trunk/wp-includes/query.php</a></li>
<li><a href="#trunkwpincludesuserphp">trunk/wp-includes/user.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludesmetaphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/meta.php (17169 => 17170)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/meta.php 2010-12-29 16:25:22 UTC (rev 17169)
+++ trunk/wp-includes/meta.php 2010-12-29 19:31:35 UTC (rev 17170)
</span><span class="lines">@@ -356,6 +356,7 @@
</span><span class="cx"> * Given a meta query, generates SQL clauses to be appended to a main query
</span><span class="cx"> *
</span><span class="cx"> * @since 3.1.0
</span><ins>+ * @access private
</ins><span class="cx"> *
</span><span class="cx"> * @param array $meta_query List of metadata queries. A single query is an associative array:
</span><span class="cx"> * - 'key' string The meta key
</span><span class="lines">@@ -373,7 +374,7 @@
</span><span class="cx"> * @param object $context (optional) The main query object
</span><span class="cx"> * @return array( 'join' => $join_sql, 'where' => $where_sql )
</span><span class="cx"> */
</span><del>-function get_meta_sql( $meta_query, $meta_type, $primary_table, $primary_id_column, $context = null ) {
</del><ins>+function _get_meta_sql( $meta_query, $meta_type, $primary_table, $primary_id_column, $context = null ) {
</ins><span class="cx"> global $wpdb;
</span><span class="cx">
</span><span class="cx"> if ( ! $meta_table = _get_meta_table( $meta_type ) )
</span></span></pre></div>
<a id="trunkwpincludesqueryphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/query.php (17169 => 17170)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/query.php 2010-12-29 16:25:22 UTC (rev 17169)
+++ trunk/wp-includes/query.php 2010-12-29 19:31:35 UTC (rev 17170)
</span><span class="lines">@@ -2347,7 +2347,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if ( !empty( $q['meta_query'] ) ) {
</span><del>- $clauses = call_user_func_array( 'get_meta_sql', array( $q['meta_query'], 'post', $wpdb->posts, 'ID', &$this) );
</del><ins>+ $clauses = call_user_func_array( '_get_meta_sql', array( $q['meta_query'], 'post', $wpdb->posts, 'ID', &$this) );
</ins><span class="cx"> $join .= $clauses['join'];
</span><span class="cx"> $where .= $clauses['where'];
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkwpincludesuserphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/user.php (17169 => 17170)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/user.php 2010-12-29 16:25:22 UTC (rev 17169)
+++ trunk/wp-includes/user.php 2010-12-29 19:31:35 UTC (rev 17170)
</span><span class="lines">@@ -508,7 +508,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> if ( !empty( $qv['meta_query'] ) ) {
</span><del>- $clauses = call_user_func_array( 'get_meta_sql', array( $qv['meta_query'], 'user', $wpdb->users, 'ID', &$this ) );
</del><ins>+ $clauses = call_user_func_array( '_get_meta_sql', array( $qv['meta_query'], 'user', $wpdb->users, 'ID', &$this ) );
</ins><span class="cx"> $this->query_from .= $clauses['join'];
</span><span class="cx"> $this->query_where .= $clauses['where'];
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>