<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[16947] trunk/wp-includes/query.php: You are doing it wrong in query.php.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/16947">16947</a></dd>
<dt>Author</dt> <dd>nacin</dd>
<dt>Date</dt> <dd>2010-12-15 12:21:27 +0000 (Wed, 15 Dec 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>You are doing it wrong in query.php. see <a href="http://trac.wordpress.org/ticket/15824">#15824</a>, see <a href="http://trac.wordpress.org/ticket/14729">#14729</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludesqueryphp">trunk/wp-includes/query.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludesqueryphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/query.php (16946 => 16947)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/query.php 2010-12-15 12:09:53 UTC (rev 16946)
+++ trunk/wp-includes/query.php 2010-12-15 12:21:27 UTC (rev 16947)
</span><span class="lines">@@ -142,6 +142,11 @@
</span><span class="cx"> function is_archive() {
</span><span class="cx"> global $wp_query;
</span><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_archive();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -158,6 +163,11 @@
</span><span class="cx"> function is_post_type_archive( $post_types = '' ) {
</span><span class="cx"> global $wp_query;
</span><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_post_type_archive( $post_types );
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -173,6 +183,11 @@
</span><span class="cx"> function is_attachment() {
</span><span class="cx"> global $wp_query;
</span><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_attachment();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -192,6 +207,11 @@
</span><span class="cx"> function is_author( $author = '' ) {
</span><span class="cx"> global $wp_query;
</span><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_author( $author );
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -211,6 +231,11 @@
</span><span class="cx"> function is_category( $category = '' ) {
</span><span class="cx"> global $wp_query;
</span><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_category( $category );
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -230,6 +255,11 @@
</span><span class="cx"> function is_tag( $slug = '' ) {
</span><span class="cx"> global $wp_query;
</span><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_tag( $slug );
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -252,8 +282,13 @@
</span><span class="cx"> * @return bool
</span><span class="cx"> */
</span><span class="cx"> function is_tax( $taxonomy = '', $term = '' ) {
</span><del>- global $wp_query, $wp_taxonomies;
</del><ins>+ global $wp_query;
</ins><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_tax( $taxonomy, $term );
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -269,6 +304,11 @@
</span><span class="cx"> function is_comments_popup() {
</span><span class="cx"> global $wp_query;
</span><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_comments_popup();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -284,6 +324,11 @@
</span><span class="cx"> function is_date() {
</span><span class="cx"> global $wp_query;
</span><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_date();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -299,6 +344,11 @@
</span><span class="cx"> function is_day() {
</span><span class="cx"> global $wp_query;
</span><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_day();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -315,6 +365,11 @@
</span><span class="cx"> function is_feed( $feeds = '' ) {
</span><span class="cx"> global $wp_query;
</span><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_feed( $feeds );
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -330,6 +385,11 @@
</span><span class="cx"> function is_comment_feed() {
</span><span class="cx"> global $wp_query;
</span><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_comment_feed();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -355,6 +415,11 @@
</span><span class="cx"> function is_front_page() {
</span><span class="cx"> global $wp_query;
</span><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_front_page();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -379,6 +444,11 @@
</span><span class="cx"> function is_home() {
</span><span class="cx"> global $wp_query;
</span><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_home();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -394,6 +464,11 @@
</span><span class="cx"> function is_month() {
</span><span class="cx"> global $wp_query;
</span><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_month();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -416,6 +491,11 @@
</span><span class="cx"> function is_page( $page = '' ) {
</span><span class="cx"> global $wp_query;
</span><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_page( $page );
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -431,6 +511,11 @@
</span><span class="cx"> function is_paged() {
</span><span class="cx"> global $wp_query;
</span><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_paged();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -446,6 +531,11 @@
</span><span class="cx"> function is_preview() {
</span><span class="cx"> global $wp_query;
</span><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_preview();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -461,6 +551,11 @@
</span><span class="cx"> function is_robots() {
</span><span class="cx"> global $wp_query;
</span><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_robots();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -476,6 +571,11 @@
</span><span class="cx"> function is_search() {
</span><span class="cx"> global $wp_query;
</span><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_search();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -500,6 +600,11 @@
</span><span class="cx"> function is_single( $post = '' ) {
</span><span class="cx"> global $wp_query;
</span><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_single( $post );
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -522,6 +627,11 @@
</span><span class="cx"> function is_singular( $post_types = '' ) {
</span><span class="cx"> global $wp_query;
</span><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_singular( $post_types );
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -537,6 +647,11 @@
</span><span class="cx"> function is_time() {
</span><span class="cx"> global $wp_query;
</span><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_time();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -552,6 +667,11 @@
</span><span class="cx"> function is_trackback() {
</span><span class="cx"> global $wp_query;
</span><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_trackback();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -567,6 +687,11 @@
</span><span class="cx"> function is_year() {
</span><span class="cx"> global $wp_query;
</span><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_year();
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -582,6 +707,11 @@
</span><span class="cx"> function is_404() {
</span><span class="cx"> global $wp_query;
</span><span class="cx">
</span><ins>+ if ( ! isset( $wp_query ) ) {
+ _doing_it_wrong( __FUNCTION__, __( 'Conditional query tags do not work before the init hook. They always return false.' ), '3.1' );
+ // return false;
+ }
+
</ins><span class="cx"> return $wp_query->is_404();
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>