<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[16974] trunk/wp-includes/user.php:
Fetch only the required field in wp_dropdown_users().</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/16974">16974</a></dd>
<dt>Author</dt> <dd>scribu</dd>
<dt>Date</dt> <dd>2010-12-15 23:56:53 +0000 (Wed, 15 Dec 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fetch only the required field in wp_dropdown_users(). See <a href="http://trac.wordpress.org/ticket/14572">#14572</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludesuserphp">trunk/wp-includes/user.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludesuserphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/user.php (16973 => 16974)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/user.php 2010-12-15 23:21:07 UTC (rev 16973)
+++ trunk/wp-includes/user.php 2010-12-15 23:56:53 UTC (rev 16974)
</span><span class="lines">@@ -351,7 +351,8 @@
</span><span class="cx"> */
</span><span class="cx"> var $total_users = 0;
</span><span class="cx">
</span><del>- // SQL pieces
</del><ins>+ // SQL clauses
+ var $query_fields;
</ins><span class="cx"> var $query_from;
</span><span class="cx"> var $query_where;
</span><span class="cx"> var $query_orderby;
</span><span class="lines">@@ -406,9 +407,20 @@
</span><span class="cx">
</span><span class="cx"> $qv = &$this->query_vars;
</span><span class="cx">
</span><del>- $this->query_from = " FROM $wpdb->users";
- $this->query_where = " WHERE 1=1";
</del><ins>+ if ( is_array( $qv['fields'] ) ) {
+ $qv['fields'] = array_unique( $qv['fields'] );
</ins><span class="cx">
</span><ins>+ $this->query_fields = array();
+ foreach ( $qv['fields'] as $field )
+ $this->query_fields[] = $wpdb->users . '.' . esc_sql( $field );
+ $this->query_fields = implode( ',', $this->query_fields );
+ } else {
+ $this->query_fields = "$wpdb->users.ID";
+ }
+
+ $this->query_from = "FROM $wpdb->users";
+ $this->query_where = "WHERE 1=1";
+
</ins><span class="cx"> // sorting
</span><span class="cx"> if ( in_array( $qv['orderby'], array('nicename', 'email', 'url', 'registered') ) ) {
</span><span class="cx"> $orderby = 'user_' . $qv['orderby'];
</span><span class="lines">@@ -437,14 +449,14 @@
</span><span class="cx"> $order = 'ASC';
</span><span class="cx"> else
</span><span class="cx"> $order = 'DESC';
</span><del>- $this->query_orderby = " ORDER BY $orderby $order";
</del><ins>+ $this->query_orderby = "ORDER BY $orderby $order";
</ins><span class="cx">
</span><span class="cx"> // limit
</span><span class="cx"> if ( $qv['number'] ) {
</span><span class="cx"> if ( $qv['offset'] )
</span><del>- $this->query_limit = $wpdb->prepare(" LIMIT %d, %d", $qv['offset'], $qv['number']);
</del><ins>+ $this->query_limit = $wpdb->prepare("LIMIT %d, %d", $qv['offset'], $qv['number']);
</ins><span class="cx"> else
</span><del>- $this->query_limit = $wpdb->prepare(" LIMIT %d", $qv['number']);
</del><ins>+ $this->query_limit = $wpdb->prepare("LIMIT %d", $qv['number']);
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> $search = trim( $qv['search'] );
</span><span class="lines">@@ -510,13 +522,17 @@
</span><span class="cx"> function query() {
</span><span class="cx"> global $wpdb;
</span><span class="cx">
</span><del>- $this->results = $wpdb->get_col("SELECT $wpdb->users.ID" . $this->query_from . $this->query_where . $this->query_orderby . $this->query_limit);
</del><ins>+ if ( is_array( $this->query_vars['fields'] ) ) {
+ $this->results = $wpdb->get_results("SELECT $this->query_fields $this->query_from $this->query_where $this->query_orderby $this->query_limit");
+ } else {
+ $this->results = $wpdb->get_col("SELECT $this->query_fields $this->query_from $this->query_where $this->query_orderby $this->query_limit");
+ }
</ins><span class="cx">
</span><span class="cx"> if ( !$this->results )
</span><span class="cx"> return;
</span><span class="cx">
</span><span class="cx"> if ( $this->query_vars['count_total'] )
</span><del>- $this->total_users = $wpdb->get_var("SELECT COUNT($wpdb->users.ID)" . $this->query_from . $this->query_where);
</del><ins>+ $this->total_users = $wpdb->get_var("SELECT COUNT($wpdb->users.ID) $this->query_from $this->query_where $this->query_orderby $this->query_limit");
</ins><span class="cx">
</span><span class="cx"> if ( 'all' == $this->query_vars['fields'] ) {
</span><span class="cx"> cache_users($this->results);
</span><span class="lines">@@ -967,8 +983,11 @@
</span><span class="cx"> $r = wp_parse_args( $args, $defaults );
</span><span class="cx"> extract( $r, EXTR_SKIP );
</span><span class="cx">
</span><del>- $users = get_users( wp_array_slice_assoc( $r, array( 'blog_id', 'include', 'exclude', 'orderby', 'order' ) ) );
</del><ins>+ $query_args = wp_array_slice_assoc( $r, array( 'blog_id', 'include', 'exclude', 'orderby', 'order' ) );
+ $query_args['fields'] = array( 'ID', $show );
</ins><span class="cx">
</span><ins>+ $users = get_users( $query_args );
+
</ins><span class="cx"> $output = '';
</span><span class="cx"> if ( !empty($users) ) {
</span><span class="cx"> $name = esc_attr( $name );
</span></span></pre>
</div>
</div>
</body>
</html>