<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[16670] trunk/wp-includes/post.php:
  Throw WP_Error if post_type passed to register_post_type()
  is longer than schema allows.</title>
</head>
<body>

<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/16670">16670</a></dd>
<dt>Author</dt> <dd>markjaquith</dd>
<dt>Date</dt> <dd>2010-12-01 20:43:39 +0000 (Wed, 01 Dec 2010)</dd>
</dl>

<h3>Log Message</h3>
<pre>Throw WP_Error if post_type passed to register_post_type() is longer than schema allows. props phrostypoison. fixes <a href="http://trac.wordpress.org/ticket/13709">#13709</a></pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludespostphp">trunk/wp-includes/post.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludespostphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/post.php (16669 => 16670)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/post.php        2010-12-01 20:41:47 UTC (rev 16669)
+++ trunk/wp-includes/post.php        2010-12-01 20:43:39 UTC (rev 16670)
</span><span class="lines">@@ -884,7 +884,7 @@
</span><span class="cx">  *
</span><span class="cx">  * @param string $post_type Name of the post type.
</span><span class="cx">  * @param array|string $args See above description.
</span><del>- * @return object the registered post type object
</del><ins>+ * @return object|WP_Error the registered post type object, or an error object
</ins><span class="cx">  */
</span><span class="cx"> function register_post_type($post_type, $args = array()) {
</span><span class="cx">         global $wp_post_types, $wp_rewrite, $wp;
</span><span class="lines">@@ -908,6 +908,9 @@
</span><span class="cx">         $post_type = sanitize_key($post_type);
</span><span class="cx">         $args-&gt;name = $post_type;
</span><span class="cx"> 
</span><ins>+        if ( strlen( $post_type ) &gt; 20 )
+                        return new WP_Error( 'post_type_too_long', __( 'Post types cannot exceed 20 characters in length' ) );
+
</ins><span class="cx">         // If not set, default to the setting for public.
</span><span class="cx">         if ( null === $args-&gt;publicly_queryable )
</span><span class="cx">                 $args-&gt;publicly_queryable = $args-&gt;public;
</span></span></pre>
</div>
</div>

</body>
</html>