<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[16622] trunk/wp-admin/includes/misc.php: Proper spacing in win_is_writable
(), according to the coding standards</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/16622">16622</a></dd>
<dt>Author</dt> <dd>nbachiyski</dd>
<dt>Date</dt> <dd>2010-11-30 19:13:27 +0000 (Tue, 30 Nov 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Proper spacing in win_is_writable(), according to the coding standards</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminincludesmiscphp">trunk/wp-admin/includes/misc.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminincludesmiscphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/misc.php (16621 => 16622)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/misc.php 2010-11-30 19:11:09 UTC (rev 16621)
+++ trunk/wp-admin/includes/misc.php 2010-11-30 19:13:27 UTC (rev 16622)
</span><span class="lines">@@ -570,25 +570,25 @@
</span><span class="cx"> * @param object $path
</span><span class="cx"> * @return bool
</span><span class="cx"> */
</span><del>-function win_is_writable($path) {
</del><ins>+function win_is_writable( $path ) {
</ins><span class="cx"> /* will work in despite of Windows ACLs bug
</span><span class="cx"> * NOTE: use a trailing slash for folders!!!
</span><span class="cx"> * see http://bugs.php.net/bug.php?id=27609
</span><span class="cx"> * see http://bugs.php.net/bug.php?id=30931
</span><span class="cx"> */
</span><span class="cx">
</span><del>- if ( $path[strlen($path)-1] == '/' ) // recursively return a temporary file path
- return win_is_writable($path . uniqid(mt_rand()) . '.tmp');
- else if ( is_dir($path) )
- return win_is_writable($path . '/' . uniqid(mt_rand()) . '.tmp');
</del><ins>+ if ( $path[strlen( $path ) - 1] == '/' ) // recursively return a temporary file path
+ return win_is_writable( $path . uniqid( mt_rand() ) . '.tmp');
+ else if ( is_dir( $path ) )
+ return win_is_writable( $path . '/' . uniqid( mt_rand() ) . '.tmp' );
</ins><span class="cx"> // check tmp file for read/write capabilities
</span><del>- $rm = file_exists($path);
- $f = @fopen($path, 'a');
- if ($f===false)
</del><ins>+ $rm = file_exists( $path );
+ $f = @fopen( $path, 'a' );
+ if ( $f === false )
</ins><span class="cx"> return false;
</span><del>- fclose($f);
</del><ins>+ fclose( $f );
</ins><span class="cx"> if ( ! $rm )
</span><del>- unlink($path);
</del><ins>+ unlink( $path );
</ins><span class="cx"> return true;
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>