<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[16634] trunk/wp-admin/includes/misc.php: Run the iis7_supports_permalinks(
 ) check first</title>
</head>
<body>

<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/16634">16634</a></dd>
<dt>Author</dt> <dd>nbachiyski</dd>
<dt>Date</dt> <dd>2010-11-30 20:50:59 +0000 (Tue, 30 Nov 2010)</dd>
</dl>

<h3>Log Message</h3>
<pre>Run the iis7_supports_permalinks() check first

 * It's cheapest, most of the others involve disk operations
 * Doesn't go through win_is_writable(), which can't avoid relying on the @ operator</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpadminincludesmiscphp">trunk/wp-admin/includes/misc.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpadminincludesmiscphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-admin/includes/misc.php (16633 => 16634)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-admin/includes/misc.php        2010-11-30 20:45:40 UTC (rev 16633)
+++ trunk/wp-admin/includes/misc.php        2010-11-30 20:50:59 UTC (rev 16634)
</span><span class="lines">@@ -155,14 +155,12 @@
</span><span class="cx">         $web_config_file = $home_path . 'web.config';
</span><span class="cx"> 
</span><span class="cx">         // Using win_is_writable() instead of is_writable() because of a bug in Windows PHP
</span><del>-        if ( ( ! file_exists($web_config_file) &amp;&amp; win_is_writable($home_path) &amp;&amp; $wp_rewrite-&gt;using_mod_rewrite_permalinks() ) || win_is_writable($web_config_file) ) {
-                if ( iis7_supports_permalinks() ) {
-                        $rule = $wp_rewrite-&gt;iis7_url_rewrite_rules(false, '', '');
-                        if ( ! empty($rule) ) {
-                                return iis7_add_rewrite_rule($web_config_file, $rule);
-                        } else {
-                                return iis7_delete_rewrite_rule($web_config_file);
-                        }
</del><ins>+        if ( iis7_supports_permalinks() &amp;&amp; ( ! file_exists($web_config_file) &amp;&amp; win_is_writable($home_path) &amp;&amp; $wp_rewrite-&gt;using_mod_rewrite_permalinks() ) || win_is_writable($web_config_file) ) {
+                $rule = $wp_rewrite-&gt;iis7_url_rewrite_rules(false, '', '');
+                if ( ! empty($rule) ) {
+                        return iis7_add_rewrite_rule($web_config_file, $rule);
+                } else {
+                        return iis7_delete_rewrite_rule($web_config_file);
</ins><span class="cx">                 }
</span><span class="cx">         }
</span><span class="cx">         return false;
</span></span></pre>
</div>
</div>

</body>
</html>