<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[16537] trunk: Fix 'timeinfo' cache invalidation.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/16537">16537</a></dd>
<dt>Author</dt> <dd>scribu</dd>
<dt>Date</dt> <dd>2010-11-22 21:45:45 +0000 (Mon, 22 Nov 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix 'timeinfo' cache invalidation. Fixes <a href="http://trac.wordpress.org/ticket/14922">#14922</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludespostphp">trunk/wp-includes/post.php</a></li>
<li><a href="#trunkwpsettingsphp">trunk/wp-settings.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludespostphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/post.php (16536 => 16537)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/post.php 2010-11-22 17:17:31 UTC (rev 16536)
+++ trunk/wp-includes/post.php 2010-11-22 21:45:45 UTC (rev 16537)
</span><span class="lines">@@ -4171,23 +4171,20 @@
</span><span class="cx"> if ( !in_array( $field, array( 'date', 'modified' ) ) )
</span><span class="cx"> return false;
</span><span class="cx">
</span><del>- $post_types = get_query_var('post_type');
- if ( empty($post_types) )
- $post_types = 'post';
</del><ins>+ $timezone = strtolower( $timezone );
</ins><span class="cx">
</span><del>- $post_types = apply_filters( "get_lastpost{$field}_post_types", (array) $post_types );
</del><ins>+ $key = "lastpost{$field}:$timezone";
</ins><span class="cx">
</span><del>- $key = "lastpost{$field}:" . get_current_blog_id() . ":$timezone:" . md5( serialize( $post_types ) );
-
</del><span class="cx"> $date = wp_cache_get( $key, 'timeinfo' );
</span><span class="cx">
</span><span class="cx"> if ( !$date ) {
</span><span class="cx"> $add_seconds_server = date('Z');
</span><span class="cx">
</span><ins>+ $post_types = get_post_types( array( 'publicly_queryable' => true ) );
</ins><span class="cx"> array_walk( $post_types, array( &$wpdb, 'escape_by_ref' ) );
</span><span class="cx"> $post_types = "'" . implode( "', '", $post_types ) . "'";
</span><span class="cx">
</span><del>- switch ( strtolower( $timezone ) ) {
</del><ins>+ switch ( $timezone ) {
</ins><span class="cx"> case 'gmt':
</span><span class="cx"> $date = $wpdb->get_var("SELECT post_{$field}_gmt FROM $wpdb->posts WHERE post_status = 'publish' AND post_type IN ({$post_types}) ORDER BY post_{$field}_gmt DESC LIMIT 1");
</span><span class="cx"> break;
</span><span class="lines">@@ -4450,9 +4447,10 @@
</span><span class="cx">
</span><span class="cx"> // If published posts changed clear the lastpostmodified cache
</span><span class="cx"> if ( 'publish' == $new_status || 'publish' == $old_status) {
</span><del>- wp_cache_delete( 'lastpostmodified:server', 'timeinfo' );
- wp_cache_delete( 'lastpostmodified:gmt', 'timeinfo' );
- wp_cache_delete( 'lastpostmodified:blog', 'timeinfo' );
</del><ins>+ foreach ( array( 'server', 'gmt', 'blog' ) as $timezone ) {
+ wp_cache_delete( "lastpostmodified:$timezone", 'timeinfo' );
+ wp_cache_delete( "lastpostdate:$timezone", 'timeinfo' );
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> // Always clears the hook in case the post status bounced from future to draft.
</span></span></pre></div>
<a id="trunkwpsettingsphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-settings.php (16536 => 16537)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-settings.php 2010-11-22 17:17:31 UTC (rev 16536)
+++ trunk/wp-settings.php 2010-11-22 21:45:45 UTC (rev 16537)
</span><span class="lines">@@ -35,7 +35,7 @@
</span><span class="cx"> wp_unregister_GLOBALS();
</span><span class="cx">
</span><span class="cx"> // Ensure these global variables do not exist so they do not interfere with WordPress.
</span><del>-unset( $wp_filter, $cache_lastcommentmodified, $cache_lastpostdate );
</del><ins>+unset( $wp_filter, $cache_lastcommentmodified );
</ins><span class="cx">
</span><span class="cx"> // Standardize $_SERVER variables across setups.
</span><span class="cx"> wp_fix_server_vars();
</span></span></pre>
</div>
</div>
</body>
</html>