<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[16515] trunk/wp-includes/query.php: Don'
t do any taxonomy stuff if is_singular.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/16515">16515</a></dd>
<dt>Author</dt> <dd>scribu</dd>
<dt>Date</dt> <dd>2010-11-20 21:51:21 +0000 (Sat, 20 Nov 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Don't do any taxonomy stuff if is_singular. See <a href="http://trac.wordpress.org/ticket/15487">#15487</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludesqueryphp">trunk/wp-includes/query.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludesqueryphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/query.php (16514 => 16515)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/query.php 2010-11-20 21:44:11 UTC (rev 16514)
+++ trunk/wp-includes/query.php 2010-11-20 21:51:21 UTC (rev 16515)
</span><span class="lines">@@ -1593,19 +1593,17 @@
</span><span class="cx"> );
</span><span class="cx"> }
</span><span class="cx">
</span><del>- if ( !$this->is_singular() ) {
- foreach ( $tax_query as $query ) {
- if ( 'IN' == $query['operator'] ) {
- switch ( $query['taxonomy'] ) {
- case 'category':
- $this->is_category = true;
- break;
- case 'post_tag':
- $this->is_tag = true;
- break;
- default:
- $this->is_tax = true;
- }
</del><ins>+ foreach ( $tax_query as $query ) {
+ if ( 'IN' == $query['operator'] ) {
+ switch ( $query['taxonomy'] ) {
+ case 'category':
+ $this->is_category = true;
+ break;
+ case 'post_tag':
+ $this->is_tag = true;
+ break;
+ default:
+ $this->is_tax = true;
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="lines">@@ -1945,46 +1943,48 @@
</span><span class="cx"> $search = apply_filters_ref_array('posts_search', array( $search, &$this ) );
</span><span class="cx">
</span><span class="cx"> // Taxonomies
</span><del>- $this->tax_query = $this->parse_tax_query( $q );
- if ( !empty( $this->tax_query ) ) {
- $clauses = call_user_func_array( 'get_tax_sql', array( $this->tax_query, $wpdb->posts, 'ID', &$this) );
</del><ins>+ if ( !$this->is_singular ) {
+ $this->tax_query = $this->parse_tax_query( $q );
+ if ( !empty( $this->tax_query ) ) {
+ $clauses = call_user_func_array( 'get_tax_sql', array( $this->tax_query, $wpdb->posts, 'ID', &$this) );
</ins><span class="cx">
</span><del>- $join .= $clauses['join'];
- $where .= $clauses['where'];
</del><ins>+ $join .= $clauses['join'];
+ $where .= $clauses['where'];
</ins><span class="cx">
</span><del>- if ( $this->is_tax ) {
- if ( empty($post_type) ) {
- $post_type = 'any';
- $post_status_join = true;
- } elseif ( in_array('attachment', (array) $post_type) ) {
- $post_status_join = true;
</del><ins>+ if ( $this->is_tax ) {
+ if ( empty($post_type) ) {
+ $post_type = 'any';
+ $post_status_join = true;
+ } elseif ( in_array('attachment', (array) $post_type) ) {
+ $post_status_join = true;
+ }
</ins><span class="cx"> }
</span><del>- }
</del><span class="cx">
</span><del>- // Back-compat
- $tax_query_in = wp_list_filter( $this->tax_query, array( 'operator' => 'IN' ) );
- if ( !empty( $tax_query_in ) ) {
- if ( !isset( $q['taxonomy'] ) ) {
- foreach ( $tax_query_in as $a_tax_query ) {
- if ( !in_array( $a_tax_query['taxonomy'], array( 'category', 'post_tag' ) ) ) {
- $q['taxonomy'] = $a_tax_query['taxonomy'];
- if ( 'slug' == $a_tax_query['field'] )
- $q['term'] = $a_tax_query['terms'][0];
- else
- $q['term_id'] = $a_tax_query['terms'][0];
</del><ins>+ // Back-compat
+ $tax_query_in = wp_list_filter( $this->tax_query, array( 'operator' => 'IN' ) );
+ if ( !empty( $tax_query_in ) ) {
+ if ( !isset( $q['taxonomy'] ) ) {
+ foreach ( $tax_query_in as $a_tax_query ) {
+ if ( !in_array( $a_tax_query['taxonomy'], array( 'category', 'post_tag' ) ) ) {
+ $q['taxonomy'] = $a_tax_query['taxonomy'];
+ if ( 'slug' == $a_tax_query['field'] )
+ $q['term'] = $a_tax_query['terms'][0];
+ else
+ $q['term_id'] = $a_tax_query['terms'][0];
</ins><span class="cx">
</span><del>- break;
</del><ins>+ break;
+ }
</ins><span class="cx"> }
</span><span class="cx"> }
</span><del>- }
</del><span class="cx">
</span><del>- $cat_query = wp_list_filter( $tax_query_in, array( 'taxonomy' => 'category' ) );
- if ( !empty( $cat_query ) ) {
- $cat_query = reset( $cat_query );
- $cat = get_term_by( $cat_query['field'], $cat_query['terms'][0], 'category' );
- if ( $cat ) {
- $this->set( 'cat', $cat->term_id );
- $this->set( 'category_name', $cat->slug );
</del><ins>+ $cat_query = wp_list_filter( $tax_query_in, array( 'taxonomy' => 'category' ) );
+ if ( !empty( $cat_query ) ) {
+ $cat_query = reset( $cat_query );
+ $cat = get_term_by( $cat_query['field'], $cat_query['terms'][0], 'category' );
+ if ( $cat ) {
+ $this->set( 'cat', $cat->term_id );
+ $this->set( 'category_name', $cat->slug );
+ }
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>