<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--
#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }
#msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<title>[16410] trunk/wp-includes/meta.php: Minor get_meta_sql() cleanup.</title>
</head>
<body>
<div id="msg">
<dl>
<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/16410">16410</a></dd>
<dt>Author</dt> <dd>scribu</dd>
<dt>Date</dt> <dd>2010-11-17 00:27:34 +0000 (Wed, 17 Nov 2010)</dd>
</dl>
<h3>Log Message</h3>
<pre>Minor get_meta_sql() cleanup. See <a href="http://trac.wordpress.org/ticket/9124">#9124</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkwpincludesmetaphp">trunk/wp-includes/meta.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkwpincludesmetaphp"></a>
<div class="modfile"><h4>Modified: trunk/wp-includes/meta.php (16409 => 16410)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/wp-includes/meta.php 2010-11-16 22:18:48 UTC (rev 16409)
+++ trunk/wp-includes/meta.php 2010-11-17 00:27:34 UTC (rev 16410)
</span><span class="lines">@@ -380,8 +380,6 @@
</span><span class="cx">
</span><span class="cx"> $meta_id_column = esc_sql( $meta_type . '_id' );
</span><span class="cx">
</span><del>- $clauses = array();
-
</del><span class="cx"> $join = '';
</span><span class="cx"> $where = '';
</span><span class="cx"> $i = 0;
</span><span class="lines">@@ -424,9 +422,7 @@
</span><span class="cx"> continue;
</span><span class="cx">
</span><span class="cx"> if ( 'IN' == substr( $meta_compare, -2) ) {
</span><del>- $meta_field_types = substr( str_repeat( ',%s', count( $meta_value ) ), 1 );
- $meta_compare_string = "($meta_field_types)";
- unset( $meta_field_types );
</del><ins>+ $meta_compare_string = '(' . substr( str_repeat( ',%s', count( $meta_value ) ), 1 ) . ')';
</ins><span class="cx"> } elseif ( 'BETWEEN' == substr( $meta_compare, -7) ) {
</span><span class="cx"> $meta_value = array_slice( $meta_value, 0, 2 );
</span><span class="cx"> $meta_compare_string = '%s AND %s';
</span><span class="lines">@@ -437,8 +433,6 @@
</span><span class="cx"> $meta_compare_string = '%s';
</span><span class="cx"> }
</span><span class="cx"> $where .= $wpdb->prepare( " AND CAST($alias.meta_value AS {$meta_type}) {$meta_compare} {$meta_compare_string}", $meta_value );
</span><del>-
- unset( $meta_compare_string );
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> return apply_filters_ref_array( 'get_meta_sql', array( compact( 'join', 'where' ), $meta_query, $meta_type, $primary_table, $primary_id_column, &$context ) );
</span></span></pre>
</div>
</div>
</body>
</html>