
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"

"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">

<html xmlns="http://www.w3.org/1999/xhtml">

<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style type="text/css"><!--

#msg dl { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }

#msg dt { float: left; width: 6em; font-weight: bold; }

#msg dt:after { content:':';}

#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }

#msg dl a { font-weight: bold}

#msg dl a:link    { color:#fc3; }

#msg dl a:active  { color:#ff0; }

#msg dl a:visited { color:#cc6; }

h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }

#msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: 6px; }

#msg ul, pre { overflow: auto; }

#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }

#patch { width: 100%; }

#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}

#patch .propset h4, #patch .binary h4 {margin:0;}

#patch pre {padding:0;line-height:1.2em;margin:0;}

#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}

#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}

#patch span {display:block;padding:0 10px;}

#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}

#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}

#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}

#patch .lines, .info {color:#888;background:#fff;}

--></style>

<title>[16373] branches/3.0/wp-admin/plugins.php: Some escaping</title>

</head>

<body>


<div id="msg">

<dl>

<dt>Revision</dt> <dd><a href="http://trac.wordpress.org/changeset/16373">16373</a></dd>

<dt>Author</dt> <dd>ryan</dd>

<dt>Date</dt> <dd>2010-11-14 18:38:55 +0000 (Sun, 14 Nov 2010)</dd>

</dl>


<h3>Log Message</h3>

<pre>Some escaping</pre>


<h3>Modified Paths</h3>

<ul>

<li><a href="#branches30wpadminpluginsphp">branches/3.0/wp-admin/plugins.php</a></li>

</ul>


</div>

<div id="patch">

<h3>Diff</h3>

<a id="branches30wpadminpluginsphp"></a>

<div class="modfile"><h4>Modified: branches/3.0/wp-admin/plugins.php (16372 => 16373)</h4>

<pre class="diff"><span>

<span class="info">--- branches/3.0/wp-admin/plugins.php        2010-11-14 18:34:59 UTC (rev 16372)

+++ branches/3.0/wp-admin/plugins.php        2010-11-14 18:38:55 UTC (rev 16373)

</span><span class="lines">@@ -255,11 +255,11 @@

</span><span class="cx">                                                 foreach ( $plugin_info as $plugin ) {

</span><span class="cx">                                                         if ( $plugin['is_uninstallable'] ) {

</span><span class="cx">                                                                 /* translators: 1: plugin name, 2: plugin author */

</span><del>-                                                                echo '&lt;li&gt;', sprintf( __( '&lt;strong&gt;%1$s&lt;/strong&gt; by &lt;em&gt;%2$s&lt;/em&gt; (will also &lt;strong&gt;delete its data&lt;/strong&gt;)' ), $plugin['Name'], $plugin['Author'] ), '&lt;/li&gt;';

</del><ins>+                                                                echo '&lt;li&gt;', sprintf( __( '&lt;strong&gt;%1$s&lt;/strong&gt; by &lt;em&gt;%2$s&lt;/em&gt; (will also &lt;strong&gt;delete its data&lt;/strong&gt;)' ), esc_html($plugin['Name']), esc_html($plugin['Author']) ), '&lt;/li&gt;';

</ins><span class="cx">                                                                 $data_to_delete = true;

</span><span class="cx">                                                         } else {

</span><span class="cx">                                                                 /* translators: 1: plugin name, 2: plugin author */

</span><del>-                                                                echo '&lt;li&gt;', sprintf( __('&lt;strong&gt;%1$s&lt;/strong&gt; by &lt;em&gt;%2$s&lt;/em&gt;' ), $plugin['Name'], $plugin['Author'] ), '&lt;/li&gt;';

</del><ins>+                                                                echo '&lt;li&gt;', sprintf( __('&lt;strong&gt;%1$s&lt;/strong&gt; by &lt;em&gt;%2$s&lt;/em&gt;' ), esc_html($plugin['Name']), esc_html($plugin['Author']) ), '&lt;/li&gt;';

</ins><span class="cx">                                                         }

</span><span class="cx">                                                 }

</span><span class="cx">                                                 ?&gt;

</span><span class="lines">@@ -289,7 +289,7 @@

</span><span class="cx">                                         &lt;ul class=&quot;code&quot;&gt;

</span><span class="cx">                                         &lt;?php

</span><span class="cx">                                                 foreach ( (array)$files_to_delete as $file )

</span><del>-                                                        echo '&lt;li&gt;' . str_replace(WP_PLUGIN_DIR, '', $file) . '&lt;/li&gt;';

</del><ins>+                                                        echo '&lt;li&gt;' . esc_html(str_replace(WP_PLUGIN_DIR, '', $file)) . '&lt;/li&gt;';

</ins><span class="cx">                                         ?&gt;

</span><span class="cx">                                         &lt;/ul&gt;

</span><span class="cx">                                 &lt;/div&gt;

</span></span></pre>

</div>

</div>


</body>

</html>